Newly created bitmap files should not indiscriminately overwrite old ones
Bug #1111144 reported by
Laurynas Biveinis
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Server moved to https://jira.percona.com/projects/PS |
Fix Released
|
Medium
|
Laurynas Biveinis | ||
| 5.1 |
Fix Released
|
Medium
|
Laurynas Biveinis | ||
| 5.5 |
Fix Released
|
Medium
|
Laurynas Biveinis | ||
Bug Description
Split off bug 1105709.
The current bitmap writer code passes OS_FILE_OVERWRITE to os_file_create, thus if an old file happened to be there with the same name, it was destroyed.
As the old bitmap files should not be laying around, it's better to make this situation an error.
Zero-sized old files are a special case, they might occur during regular bitmap tracking (i.e. RO workload only between server restarts), and they should be overwritten.
Related branches
lp:~laurynas-biveinis/percona-server/bug1105709-5.1
- Stewart Smith (community): Approve
- George Ormond Lorch III (community): Approve (g2)
-
Diff: 188 lines (+149/-5)3 files modifiedPercona-Server/mysql-test/suite/innodb_plugin/r/percona_changed_page_bmp_flush.result (+19/-0)
Percona-Server/mysql-test/suite/innodb_plugin/t/percona_changed_page_bmp_flush.test (+93/-0)
Percona-Server/storage/innodb_plugin/log/log0online.c (+37/-5)
lp:~laurynas-biveinis/percona-server/bug1105709-5.5
- Stewart Smith (community): Approve
- George Ormond Lorch III (community): Approve (g2)
-
Diff: 190 lines (+150/-6)3 files modifiedPercona-Server/mysql-test/suite/innodb/r/percona_changed_page_bmp_flush.result (+19/-0)
Percona-Server/mysql-test/suite/innodb/t/percona_changed_page_bmp_flush.test (+93/-0)
Percona-Server/storage/innobase/log/log0online.c (+38/-6)
| summary: |
- Newly created bitmap files should indiscriminately overwrite old ones + Newly created bitmap files should not indiscriminately overwrite old + ones |
| tags: | added: xtradb |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #1 |
To post a comment you must log in.
Percona now uses JIRA for bug reports so this bug report is migrated to: https:/