input/event.h & MirEvent have confused purposes
Bug #1110117 reported by
Daniel van Vugt
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Released
|
Medium
|
Daniel van Vugt | ||
Bug Description
input/event.h & MirEvent have confused purposes.
On one hand, they are used exclusively for input right now so "input/event.h" is accurate. On the other handle, the type "MirEvent" is a generic name in a file that is specifically about input.
There is similar confusion in: include/
All the comments and some identifiers say MirEvent is only for input. But the name "MirEvent" suggests it could be for any event type.
This is a source of confusion that we need to resolve because I am presently developing generic "events" that are not "input" at all.
Related branches
lp:~vanvugt/mir/generalize-event
- Chris Halse Rogers: Approve
- Robert Ancell: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 302 lines (+31/-31)14 files modifiedinclude/client/mir_toolkit/mir_client_library.h (+2/-2)
include/server/mir/input/event_filter.h (+1/-1)
include/shared/mir/input/android/android_input_lexicon.h (+1/-1)
include/shared/mir_toolkit/c_types.h (+5/-5)
include/shared/mir_toolkit/event.h (+6/-6)
include/test/mir_test_doubles/mock_event_filter.h (+4/-4)
src/client/input/android_input_receiver.h (+1/-1)
src/client/input/android_input_receiver_thread.h (+1/-1)
src/client/input/input_platform.h (+1/-1)
src/client/mir_surface.cpp (+1/-1)
src/server/input/android/transport/android_input_lexicon.cpp (+2/-2)
tests/client-language/c89.c (+1/-1)
tests/unit-tests/client/input/test_android_input_receiver.cpp (+2/-2)
tests/unit-tests/input/android/test_android_input_lexicon.cpp (+3/-3)
| Changed in mir: | |
| importance: | Undecided → Medium |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #1 |
| summary: |
- event.h needs to be moved out of "input/" + event.h needs to be moved/split out of "input/" |
| information type: | Proprietary → Public |
| Changed in mir: | |
| status: | New → Fix Committed |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote Re: event.h needs to be moved/split out of "input/" | #2 |
| Changed in mir: | |
| status: | Fix Committed → Triaged |
Revision history for this message
| Thomas Voß (thomas-voss) wrote | #3 |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #4 |
| Changed in mir: | |
| status: | Triaged → Invalid |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #5 |
| summary: |
- event.h needs to be moved/split out of "input/" + input/event.h & MirEvent have confused purposes |
| description: | updated |
| Changed in mir: | |
| status: | Invalid → Confirmed |
| Changed in mir: | |
| assignee: | nobody → Daniel van Vugt (vanvugt) |
| milestone: | none → 0.0.3 |
| Changed in mir: | |
| status: | Confirmed → In Progress |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #6 |
| Changed in mir: | |
| status: | In Progress → Fix Committed |
| Changed in mir: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Sorry, I mean the generic definition of MirEvent and event.h should not be in input/. However the input event definitions should probably stay under input/ somehow.