Cinder

Typo in cinder/db/api.py

Bug #1108766 reported by Ollie Leahy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
Unassigned
Cinder 2013.1 "grizzly"
Folsom
Fix Released
Medium
John Griffith
Cinder 2012.2.4

Bug Description

The metod quota_destroy_all_by_project() in cinder/db/api.py calls the
sqlalchemy method quota_get_all_by_project() I would guess that it
should call the sqlalchemy method quota_destroy_all_by_project()

That is:

 def quota_destroy_all_by_project(context, project_id):
     """Destroy all quotas associated with a given project."""
    return IMPL.quota_get_all_by_project(context, project_id)

should be changed to

 def quota_destroy_all_by_project(context, project_id):
     """Destroy all quotas associated with a given project."""
    return IMPL.quota_destroy_all_by_project(context, project_id)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/20682

Changed in cinder:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/20682
Committed: http://github.com/openstack/cinder/commit/b79e1f485c85cbb16280adc8d590886e25694c87
Submitter: Jenkins
Branch: master

commit b79e1f485c85cbb16280adc8d590886e25694c87
Author: Ollie Leahy <email address hidden>
Date: Tue Jan 29 11:25:27 2013 +0000

    Fix typo in cinder/db/api.py

    The api method quota_destroy_all_by_project() calls the implementation
    quota_get_all_by_project()

    Change-Id: I11927e1fd29c6248ce755dfd236bf0f9adf39d94
    Fixes: bug #1108766

Changed in cinder:
status: In Progress → Fix Committed
Vish Ishaya (vishvananda)
Changed in cinder:
importance: Undecided → Medium
tags: added: folsom-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/folsom)

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/20971

Mark McLoughlin (markmc)
tags: removed: folsom-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (stable/folsom)

Reviewed: https://review.openstack.org/20971
Committed: http://github.com/openstack/cinder/commit/a8caa79fd93e9837055660904494141251572413
Submitter: Jenkins
Branch: stable/folsom

commit a8caa79fd93e9837055660904494141251572413
Author: Ollie Leahy <email address hidden>
Date: Tue Jan 29 11:25:27 2013 +0000

    Fix typo in cinder/db/api.py

    The api method quota_destroy_all_by_project() calls the implementation
    quota_get_all_by_project()

    Change-Id: I11927e1fd29c6248ce755dfd236bf0f9adf39d94
    Fixes: bug #1108766
    (cherry picked from commit b79e1f485c85cbb16280adc8d590886e25694c87)

Thierry Carrez (ttx)
Changed in cinder:
milestone: none → grizzly-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: grizzly-3 → 2013.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.