Compiz

Coverity CHECKED_RETURN - CID 12406 - src/privatescreen/tests/test-privatescreen.cpp - in function: privatescreen_ButtonPressEdgeEventManagementTest_NoTriggerOnUnboundAction_Test::TestBody() - No check of the return value of "option.set(value)".

Bug #1101413 reported by Product Strategy Coverity Bug Uploader on 2013-01-18

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Compiz	Fix Released	Medium	Stephen M. Webb	Compiz 0.9.12.1
0.9.9	Won't Fix	Medium	Unassigned
compiz (Ubuntu)	Fix Released	Undecided	Unassigned

Bug Description

This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
CID: 12406
Checker: CHECKED_RETURN
Category: No category available
CWE definition: http://cwe.mitre.org/data/definitions/252.html
File: /tmp/buildd/compiz-0.9.9~daily13.01.14/src/privatescreen/tests/test-privatescreen.cpp
Function: privatescreen_ButtonPressEdgeEventManagementTest_NoTriggerOnUnboundAction_Test::TestBody()
Code snippet:
1239 MockTriggerableAction triggerableAction;
1240 ce::EventArguments arguments;
1241 int edgeMask = 1 << SCREEN_EDGE_TOP;
1242
CID 12406 - CHECKED_RETURN
Calling function "CompOption::set(CompOption::Value &)" without checking return value (as is done elsewhere 1171 out of 1219 times).
No check of the return value of "option.set(value)".
1243 option.set (value);
1244
1245 const ce::ActionModsMatchesEventStateFunc &matchEventState =
1246 GetMatchEventStateFuncForMock (triggerableAction);
1247
1248 EXPECT_FALSE (ce::activateButtonPressOnEdgeBindingOption (option,

Tags:

Related branches

lp:~bregma/compiz/lp-1101413

Merged into lp:compiz/0.9.12 at revision 3914

Christopher Townsend: Approve on 2014-12-02

PS Jenkins bot (community): Approve (continuous-integration) on 2014-12-02

lp:ubuntu/vivid-proposed/compiz

Revision history for this message

Product Strategy Coverity Bug Uploader (coverity-uploader) wrote on 2013-01-18: compiz-0.9.9: /tmp/buildd/compiz-0.9.9~daily13.01.14/src/privatescreen/tests/test-privatescreen.cpp

compiz-0.9.9: /tmp/buildd/compiz-0.9.9~daily13.01.14/src/privatescreen/tests/test-privatescreen.cpp Edit (275.0 KiB, text/html)

Source file with Coverity annotations.

Changed in compiz:
importance:	Undecided → Medium

MC Return (mc-return) on 2013-07-06

summary:	- Coverity CHECKED_RETURN - CID 12406 + Coverity CHECKED_RETURN - CID 12406 - src/privatescreen/tests/test- + privatescreen.cpp - in function: + privatescreen_ButtonPressEdgeEventManagementTest_NoTriggerOnUnboundAction_Test::TestBody() + - No check of the return value of "option.set(value)".
Changed in compiz:
milestone:	none → 0.9.10.0

MC Return (mc-return) on 2013-07-24

Changed in compiz:
milestone:	0.9.10.0 → 0.9.11.0

Stephen M. Webb (bregma) on 2014-12-02

Changed in compiz:
status:	New → Triaged
assignee:	nobody → Stephen M. Webb (bregma)
milestone:	0.9.11.0 → 0.9.12.1

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-12-18:

This bug was fixed in the package compiz - 1:0.9.12.0+15.04.20141210.2-0ubuntu1

---------------
compiz (1:0.9.12.0+15.04.20141210.2-0ubuntu1) vivid; urgency=medium

  [ James Jones ]
  * Added support for GL_EXT_x11_sync_object OpenGL extension for Nvidia
    based GPUs to avoid screen refresh issues. (LP: #269904)

  [ Kyle Brenneman ]
  * Added support for GL_EXT_x11_sync_object OpenGL extension for Nvidia
    based GPUs to avoid screen refresh issues. (LP: #269904)

  [ Viktor A. Danilov ]
  * Added support for GL_EXT_x11_sync_object OpenGL extension for Nvidia
    based GPUs to avoid screen refresh issues. (LP: #269904)

  [ Chris Townsend ]
  * Added support for GL_EXT_x11_sync_object OpenGL extension for Nvidia
    based GPUs to avoid screen refresh issues. (LP: #269904)

  [ Stephen M. Webb ]
  * Added support for GL_EXT_x11_sync_object OpenGL extension for Nvidia
    based GPUs to avoid screen refresh issues. (LP: #269904)
  * libdecoration/CMakeLists.txt: use correct variable for link
    directories (LP: #1392715)
  * Switcher Plugin: renamed a local variable so it does not hide a
    function parameter. (LP: #1101585)
  * added support for multi-arch installations (LP: #1395105, #959282)
  * libcompizconfig: reorder stat() and open() calls to eliminate a race
    condition (LP: #1101608)
  * dodge plugin: avoid potential null pointer dereferences (LP:
    #1101554)
  * PrivateScreen unit tests: added additional assertions to verify the
    tests are run in an expected state (LP: #1101413)

[ Ubuntu daily release ]
* New rebuild forced

  [ Brandon Schaefer ]
  * Rev 3891 change caused 2 known regressions. (Could be more).
    Reverting. (LP: #1398512, #1393020)
-- Ubuntu daily release <email address hidden> Wed, 10 Dec 2014 19:52:06 +0000