Compiz

[needs-packaging] xorg-gtest 0.6 or 0.7

Bug #1100382 reported by Daniel van Vugt on 2013-01-16

This bug affects 1 person

	Status	Importance	Assigned to
Compiz	Won't Fix	Medium	Unassigned
compiz (Ubuntu)	Invalid	Medium	Unassigned
xorg-gtest (Ubuntu)	Fix Released	Medium	Stephen M. Webb

Bug Description

The version of xorg-gtest in the raring repositories is out of date. Currently we are shipping 0.3 which is about 7 months old. It would be better to ship a newer version such as either 0.6 or 0.7, so that all of the users can use the new API.

ORIGINAL DESCRIPTION:

When I build with -DBUILD_XORG_GTEST=ON ...

In file included from /home/dan/bzr/compiz/trunk/tests/system/xorg-gtest/src/compiz-xorg-gtest.cpp:30:0:
/home/dan/bzr/compiz/trunk/tests/system/xorg-gtest/include/compiz-xorg-gtest.h:110:3: error: ‘State’ in ‘class xorg::testing::Process’ does not name a type
/home/dan/bzr/compiz/trunk/tests/system/xorg-gtest/include/compiz-xorg-gtest.h:128:3: error: ‘State’ in ‘class xorg::testing::Process’ does not name a type
[ 88%] Built target resize
/home/dan/bzr/compiz/trunk/tests/system/xorg-gtest/src/compiz-xorg-gtest.cpp: In function ‘bool compiz::testing::WaitForEventOfTypeOnWindow(Display*, Window, int, int, int, int)’:
/home/dan/bzr/compiz/trunk/tests/system/xorg-gtest/src/compiz-xorg-gtest.cpp:102:27: error: ‘xorg::testing::XServer’ has not been declared
[ 88%] Built target showmouse
/home/dan/bzr/compiz/trunk/tests/system/xorg-gtest/src/compiz-xorg-gtest.cpp: In constructor ‘compiz::testing::CompizProcess::CompizProcess(Display*, compiz::testing::CompizProcess::StartupFlags, unsigned int)’:
/home/dan/bzr/compiz/trunk/tests/system/xorg-gtest/src/compiz-xorg-gtest.cpp:394:49: error: cannot pass objects of non-trivially-copyable type ‘class std::vector<std::basic_string<char> >’ through ‘...’
/home/dan/bzr/compiz/trunk/tests/system/xorg-gtest/src/compiz-xorg-gtest.cpp:395:5: error: ‘class xorg::testing::Process’ has no member named ‘GetState’
/home/dan/bzr/compiz/trunk/tests/system/xorg-gtest/src/compiz-xorg-gtest.cpp:395:5: error: template argument 1 is invalid
/home/dan/bzr/compiz/trunk/tests/system/xorg-gtest/src/compiz-xorg-gtest.cpp:395:5: error: ‘class xorg::testing::Process’ has no member named ‘GetState’
/home/dan/bzr/compiz/trunk/tests/system/xorg-gtest/src/compiz-xorg-gtest.cpp:395:5: error: ‘RUNNING’ is not a member of ‘xorg::testing::Process’
/home/dan/bzr/compiz/trunk/tests/system/xorg-gtest/src/compiz-xorg-gtest.cpp: In destructor ‘compiz::testing::CompizProcess::~CompizProcess()’:
/home/dan/bzr/compiz/trunk/tests/system/xorg-gtest/src/compiz-xorg-gtest.cpp:403:24: error: ‘class xorg::testing::Process’ has no member named ‘GetState’
/home/dan/bzr/compiz/trunk/tests/system/xorg-gtest/src/compiz-xorg-gtest.cpp:403:39: error: ‘RUNNING’ is not a member of ‘xorg::testing::Process’
/home/dan/bzr/compiz/trunk/tests/system/xorg-gtest/src/compiz-xorg-gtest.cpp: At global scope:
/home/dan/bzr/compiz/trunk/tests/system/xorg-gtest/src/compiz-xorg-gtest.cpp:407:1: error: ‘State’ in ‘class xorg::testing::Process’ does not name a type
/home/dan/bzr/compiz/trunk/tests/system/xorg-gtest/src/compiz-xorg-gtest.cpp:445:1: error: ‘State’ in ‘class xorg::testing::Process’ does not name a type
[ 88%] Built target staticswitcher

See original description

Tags:

Related branches

lp:~bregma/xorg-gtest/xorg-gtest

Merged into lp:ubuntu/raring/xorg-gtest at revision 9

Daniel Holbach (community): Approve on 2013-01-21

Ubuntu branches: Pending requested 2013-01-21

lp:ubuntu/raring-proposed/xorg-gtest

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2013-01-16:

Looks like a missing build-dep. But cmake should have told me about that...

Changed in compiz (Ubuntu):
importance:	Undecided → Medium

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2013-01-16:

No, I think the upstream API has probably changed *sigh*

I'll have a look into it now.

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2013-01-17:

BTW, when reporting build errors, please don't use -jN, it makes the output annoying to read.

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2013-01-17:

Huh, I have the most up-to-date version of xorg-gtest and it is still compiling fine.

Where did you get xorg-gtest from, and what version are you running? Are you running it from git?

The build errors you got would indicate that there's no enum State in xorg::testing::Process, but its definitely there on my version:

  /**
   * Return the state of the process.
   *
   * @return The current state of the process
   */
  enum Process::State GetState();

   /**
    * Describes the state of a process as seen by this library. This state
    * changes some behaviors inside the library, most notably:
    * * A process in state ERROR or NONE will fail to Kill() or Terminate()
    * * A process in state FINISHED_SUCCESS or FINISHED_FAILURE will always
    * succeed to Kill() or Terminate()
    * * A process in state TERMINATED may change state to FINISHED_SUCCESS
    * or FINISHED_FAILURE when queried again.
    */
   enum State {
     ERROR, /**< An error has occured, state is now unknown */
     NONE, /**< The process has not been started yet */
     RUNNING, /**< The process has been started */
     FINISHED_SUCCESS, /**< The process finished with an exit code of 0 */
     FINISHED_FAILURE, /**< The process finished with a non-zero exit code */
     TERMINATED, /**< The process was successfully terminated by this
                             library but it's state is currently unknown */
   };

what are the contents of your /usr/include/xorg/gtest/xorg-gtest-process.h?

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2013-01-17:

Yeah the Ubuntu packages are extremely old:
https://launchpad.net/ubuntu/+source/xorg-gtest

But the trunk branch in launchpad is much newer and has the missing stuff:
http://bazaar.launchpad.net/~oif-team/xorg-gtest/upstream/view/head:/include/xorg/gtest/xorg-gtest-process.h

It's just not been packaged yet.

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2013-01-17:

The xorg-gtest-dev package in ubuntu is way out of date. It is currently using 0.3 which is 7 months old. Compiz should really depend on a later version, like at least 0.6 or 0.7.

The old version is dangerous to use because of a race condition that causes tests to fail randomly.

Changed in compiz:
status:	New → Won't Fix
Changed in compiz (Ubuntu):
status:	New → Invalid
summary:	- compiz-xorg-gtest FTBFS + [needs-packaging] xorg-gtest version 0.6
Changed in compiz:
assignee:	Sam Spilsbury (smspillaz) → nobody
milestone:	0.9.9.0 → none

Sam Spilsbury (smspillaz) on 2013-01-17

description:	updated
summary:	- [needs-packaging] xorg-gtest version 0.6 + [needs-packaging] xorg-gtest 0.6 or 0.7
tags:	added: needs-packaging xorg-gtest

Stephen M. Webb (bregma) on 2013-01-17

Changed in xorg-gtest (Ubuntu):
status:	New → In Progress
assignee:	nobody → Stephen M. Webb (bregma)
importance:	Undecided → Medium

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-01-21:

This bug was fixed in the package xorg-gtest - 0.7.0-0ubuntu1

---------------
xorg-gtest (0.7.0-0ubuntu1) raring; urgency=low

  * New upstream release (lp: #1100382).
  * debian/control: added valgrind as a build dependency (for tests).
  * debian/source/format: changed to 3.0 (quilt)
  * fixed 'make check' target so it does not fail in Ubuntu
  * debian/control (Standards-Version): updated to 3.9.4 (no changes required)
  * debian/copyright: updated
-- <email address hidden> (Stephen M. Webb) Fri, 18 Jan 2013 16:11:32 -0500

Changed in xorg-gtest (Ubuntu):
status:	In Progress → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.