Nuvola Apps Runtime (Nuvola Player)

Notification artwork out of sync on KDE

Bug #1099825 reported by Ian Whyman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Nuvola Apps Runtime (Nuvola Player)
Fix Released
Medium
Unassigned
Nuvola Apps Runtime (Nuvola Player) 2.1.0
1.1.x
Fix Released
High
Unassigned
Nuvola Apps Runtime (Nuvola Player) 1.1.3
2.0.x
Fix Released
High
Unassigned
Nuvola Apps Runtime (Nuvola Player) 2.0.3

Bug Description

Version: 2.0.2
Distribution: Gentoo amd64

Steps to reproduce:
1. Enable notification plugin.
2. Skip tracks.
3. Artwork gets out of sync, random albums are shown as cover art.

This is a really nice app, btw.

Additional Info:
I am using google music, shuffle on all on tracks.

Webkit GTK version is 1.8.3

------
On further investigation it seems to happen across all services and seems to be some kind of cache issue as artwork from albums that exist only on other services are shown.

See original description
Ian Whyman (thev00d00)
description: updated
Ian Whyman (thev00d00)
description: updated
Revision history for this message
Ian Whyman (thev00d00) wrote :

Same when testing with webkit-gtk 1.10.2

Revision history for this message
Jiří Janoušek (fenryxo) wrote : Re: [Bug 1099825] Re: Notification artwork out of sync

Thanks for taking the time to report this bug. Unfortunately, I cannot
reproduce your issue. Could you open a directory ~/.cache/nuvolaplayer
and check whether a right album art image is downloaded when you skip
a track? The filename is album_art.0 - album_art.0.

  status incomplete

Changed in nuvola-player:
status: New → Incomplete
Revision history for this message
Ian Whyman (thev00d00) wrote : Re: Notification artwork out of sync

There is a ~/.cache/nuvolaplayer/album_art.# present and it always matches the track correctly.

Revision history for this message
Ian Whyman (thev00d00) wrote :

I should add I am on KDE

Revision history for this message
Jiří Janoušek (fenryxo) wrote :

> There is a ~/.cache/nuvolaplayer/album_art.# present and it always matches the track correctly.

The KDE notification daemon may cache icons of notifications. Could you try out an attached patch that increases count of album art files to 100?

summary: - Notification artwork out of sync
+ Notification artwork out of sync on KDE
Revision history for this message
Ian Whyman (thev00d00) wrote :

The attached patch seemed to work, however (once I had forwarded 100 times(!)) the same issue occurred.

Revision history for this message
Ian Whyman (thev00d00) wrote :

I guess the fix will be to be to pass the actual image data over dbus rather than a reference to the file, thus avoiding any caching any of the notification systems may implement.

Revision history for this message
Jiří Janoušek (fenryxo) wrote :

> The attached patch seemed to work, however (once I had forwarded 100
> times(!)) the same issue occurred.

The patch was intended to only confirm the cause of the issue, not to fix it.

> I guess the fix will be to be to pass the actual image data over dbus
> rather than a reference to the file, thus avoiding any caching any of
> the notification systems may implement.

Yes, this should work. Could you try out the attached patch that pass image data over dbus?

Revision history for this message
Ian Whyman (thev00d00) wrote :

That works beautifully.

I was actually putting together a patch that was almost exactly the same as yours.

Any chance of getting a 2.0.3 with this in it?

Jiří Janoušek (fenryxo)
Changed in nuvola-player:
milestone: none → 2.1.0
status: Incomplete → In Progress
importance: Undecided → Medium
Revision history for this message
Jiří Janoušek (fenryxo) wrote :

> Any chance of getting a 2.0.3 with this in it?

The patch will be released in 1.1.3 & 2.0.3 (no ETA though).

Revision history for this message
Jiří Janoušek (fenryxo) wrote :

Fix committed to lp:nuvola-player as r646.
<http://bazaar.launchpad.net/~fenryxo/nuvola-player/trunk/revision/646>

Fix committed to lp:nuvola-player/2.0.x as r593.
<http://bazaar.launchpad.net/~fenryxo/nuvola-player/2.0.x/revision/593>

Fix committed to lp:nuvola-player/1.1.x as r555.
<http://bazaar.launchpad.net/~fenryxo/nuvola-player/1.1.x/revision/555>

Changed in nuvola-player:
status: In Progress → Fix Committed
Revision history for this message
Jiří Janoušek (fenryxo) wrote :

Fix released in Nuvola Player 1.1.3 and 2.0.3.

Revision history for this message
Jiří Janoušek (fenryxo) wrote :

The fix has been released in a freshly baken Nuvola Player 2.1.0.

Changed in nuvola-player:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.