xpci fails to run on quantal

Bug #1098390 reported by Bryce Harrington
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
xdiagnose (Ubuntu)
Fix Released
Low
Bryce Harrington
Quantal
Fix Released
Low
Bryce Harrington
Raring
Fix Released
Low
Bryce Harrington

Bug Description

[Test Case]
On quantal, run `xpci`

Expected output:

rv730 (1002:9490) xserver-xorg-video-ati

Actual output:

Traceback (most recent call last):
  File "/usr/bin/xpci", line 42, in <module>
    from taskhelm import info
ImportError: No module named taskhelm

Bryce Harrington (bryce)
Changed in xdiagnose (Ubuntu Raring):
status: New → In Progress
Changed in xdiagnose (Ubuntu Quantal):
status: New → In Progress
assignee: nobody → Bryce Harrington (bryce)
Changed in xdiagnose (Ubuntu Raring):
assignee: nobody → Bryce Harrington (bryce)
Changed in xdiagnose (Ubuntu Quantal):
importance: Undecided → Low
Changed in xdiagnose (Ubuntu Raring):
importance: Undecided → Low
Bryce Harrington (bryce)
Changed in xdiagnose (Ubuntu Quantal):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xdiagnose - 3.4

---------------
xdiagnose (3.4) raring; urgency=low

  * bin/xrotate: Add new script to manually rotate screen and input.
    Designed for the Nexus 7 tablet; will need extended to support other
    devices.
  * bin/xedid: Add new script for viewing and installing EDID files into
    firmware.
    + Fixes situation where EDID is unavailable, corrupted, or invalid
      (LP: #575985)
    + Fixes situation where KVM corrupts the EDID the monitor provides.
      (LP: #992346)
  * bin/xpci: Fix two string issues so xpci will run.
    (LP: #1098390)
  * apport/source_xorg.py: Gracefully skip Xorg.0.log parsing if the
    parsing fails.
    (LP: #1098395)
  * apport/apport-gpu-error-intel.py: Gracefully skip DMI parsing if
    the parsing fails.
    (LP: #1062042)
  * xdiagnose/applet.py: Fix bug where a stray =1 gets added to
    GRUB_CMDLINE_LINUX_DEFAULT.
    (LP: #954123)
  * tests: Add sample Xorg.*.log files rather than using the on-disk one
 -- Bryce Harrington <email address hidden> Wed, 09 Jan 2013 18:17:24 -0800

Changed in xdiagnose (Ubuntu Raring):
status: In Progress → Fix Released
Revision history for this message
Clint Byrum (clint-fewbar) wrote : Please test proposed package

Hello Bryce, or anyone else affected,

Accepted xdiagnose into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/xdiagnose/3.2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Revision history for this message
Bryce Harrington (bryce) wrote :

It appears that when installed on quantal, even though the script specifies /usr/bin/python3, that gets stripped off and the binary is run as python2. The xpci code then gets hung up on a bytes/string conversion in python3-specific code.

tags: added: verification-failed
removed: verification-needed
tags: removed: verification-failed
Revision history for this message
Bryce Harrington (bryce) wrote :

I've uploaded a new 3.2.2 version with a fix - explicitly check if we're running as python2 rather than 3, and use python2-compatible string conversion in that case.

Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Bryce, or anyone else affected,

Accepted xdiagnose into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/xdiagnose/3.2.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Revision history for this message
Bryce Harrington (bryce) wrote :

Verified fixed on quantal:

root@blumonc:~# xpci
redwood (1002:68d8) xserver-xorg-video-ati,fglrx-installer

tags: added: verification-done
removed: verification-needed
Revision history for this message
Colin Watson (cjwatson) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package xdiagnose - 3.2.2

---------------
xdiagnose (3.2.2) quantal-proposed; urgency=low

  * xpci: Conditionalize text decode syntax if defaulting to python2 instead of
    python3.
    (LP: #1098390)

xdiagnose (3.2.1) quantal-proposed; urgency=low

  * xpci: Fix two string errors and an import error to enable script to
    run properly.
    (LP: #1098390)
 -- Bryce Harrington <email address hidden> Tue, 29 Jan 2013 12:48:59 -0800

Changed in xdiagnose (Ubuntu Quantal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.