Get rid of thd->write_to_slow_log

Bug #1091712 reported by Laurynas Biveinis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Fix Released
Undecided
Laurynas Biveinis
5.1
Fix Released
Undecided
Laurynas Biveinis
5.5
Fix Released
Undecided
Laurynas Biveinis

Bug Description

Split off bug 712396.

THD already has enable_slow_log. The slow query log extensions added write_to_slow_log, presumably for rate limiting implementation. The effect is that both these flags must be set for a given query to be slow-logged, and sometimes one is forgotten (i.e. slave SQL thread, the linked bug).

If possible, rate limit check could be moved right before the slow query log output, without requiring this new flag. If not possible, then at least keep write_to_slow_log as TRUE by default until rate limit check sets it to FALSE.

Related branches

tags: added: slow-extended
no longer affects: percona-server/5.6
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.