Zorba

fn-generate-id failures

Bug #1090514 reported by Juan Zacarias on 2012-12-14

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Zorba	Fix Committed	High	Markos Zaharioudakis	Zorba 3.0 "Kratos"

Bug Description

The assertion matches fails for the following test:
generate-id-001 generate-id-002 generate-id-003 generate-id-004 generate-id-005
generate-id-006 generate-id-014

Query
import module namespace xqxq = 'http://www.zorba-xquery.com/modules/xqxq'; variable $queryID := xqxq:prepare-main-module(' xquery version "3.0"; declare namespace ma = "http://www.example.com/AuctionWatch"; declare namespace xlink = "http://www.w3.org/1999/xlink"; declare namespace anyzone = "http://www.example.com/auctioneers#anyzone"; declare namespace eachbay = "http://www.example.com/auctioneers#eachbay"; declare namespace yabadoo = "http://www.example.com/auctioneers#yabadoo"; generate-id(/*)' ); variable $contextItem := doc("file:///home/juanza/FOTS/2011/QT3-test-suite/docs/auction.xml"); xqxq:bind-context-item($queryID, $contextItem); xqxq:evaluate($queryID)

Error
Assertion matches($result, '^[A-Za-z][A-Za-z0-9]*$') failed

Tags:

Related branches

lp:~zorba-coders/zorba/bug-1090514

Merged into lp:zorba at revision 11437

Chris Hillery: Approve on 2013-05-07

Paul J. Lucas: Approve on 2013-05-06

Revision history for this message

Dana Florescu (dflorescu) wrote on 2013-03-28:

Please re-assign to right person.

Changed in zorba:
importance:	Undecided → Critical
assignee:	nobody → Sorin Marian Nasoi (sorin.marian.nasoi)
milestone:	none → 2.9

Sorin Marian Nasoi (sorin.marian.nasoi) on 2013-03-28

summary:

- FOTS: fn-generate-id assertion matches failed
+ fn-generate-id failures (at least 12)

Revision history for this message

Sorin Marian Nasoi (sorin.marian.nasoi) wrote on 2013-03-28: Re: fn-generate-id failures (at least 12)

There are 12 test cases failing in "fn-generate-id" test set:

"generate-id-001,generate-id-002,generate-id-003,generate-id-004,generate-id-005,generate-id-006,generate-id-012,generate-id-013,generate-id-014,generate-id-015,generate-id-017,generate-id-018"

Assigning to Markos because according to bzr he made most of the changes in this part of the code.
@Markos please reassign if necessary.

tags:	added: fots
Changed in zorba:
assignee:	Sorin Marian Nasoi (sorin.marian.nasoi) → Markos Zaharioudakis (markos-za)

Dana Florescu (dflorescu) on 2013-04-05

tags:

added: function-library

Revision history for this message

Markos Zaharioudakis (markos-za) wrote on 2013-04-24:

Paul, Matthias told me that you are the one who implemented the id generator, so I am transfering this to you. I guess the priority does not really need to be "critical".

Changed in zorba:
assignee:	Markos Zaharioudakis (markos-za) → Paul J. Lucas (paul-lucas)

Revision history for this message

Paul J. Lucas (paul-lucas) wrote on 2013-04-25:

Such a bug report is useless.
1. It makes use of a local file -- and no copy of said file is attached to this bug report.
2. It would have been much better simply to post what $result is since this seems like a regex problem and not a generate-id problem.

For the record, I wrote the code for uuid ONLY, not generate-id and have no idea if they're related. Assigning back to Juan so he can write a decent description.

Changed in zorba:
assignee:	Paul J. Lucas (paul-lucas) → Juan Zacarias (juan457)

Revision history for this message

Sorin Marian Nasoi (sorin.marian.nasoi) wrote on 2013-05-01:

Detailed log for the 9 failures in "fn-generate-id" test-set. Edit (19.9 KiB, text/xml)

Paul I have attached the detailed report for the 9 failing test-cases in "fn-generate-id" test-set.

As you pointed out this could be a regex issue: can you please take a look and reassign if necessary?

Thanks for the help.

Changed in zorba:
assignee:	Juan Zacarias (juan457) → Paul J. Lucas (paul-lucas)
summary:	- fn-generate-id failures (at least 12) + fn-generate-id failures (at least 9)

Sorin Marian Nasoi (sorin.marian.nasoi) on 2013-05-04

summary:

- fn-generate-id failures (at least 9)
+ fn-generate-id failures

Paul J. Lucas (paul-lucas) on 2013-05-05

Changed in zorba:
status:	New → In Progress
importance:	Critical → High

Revision history for this message

Paul J. Lucas (paul-lucas) wrote on 2013-05-06:

The ID generator code was/is fine. It was the FnGenerateId code that used it that was completely wrong. However, despite fixes to that code, the FOTS tests generate-id-015 and generate-id-017 still fail with the error "static type must not be empty-sequence()". Markos: can you please take a look?