Incorrect implementation of os_file_set_eof_at on Windows
Bug #1087218 reported by
Vladislav Vaintroub
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Server moved to https://jira.percona.com/projects/PS |
Fix Released
|
Medium
|
Laurynas Biveinis | ||
| 5.1 |
Fix Released
|
Medium
|
Laurynas Biveinis | ||
| 5.5 |
Fix Released
|
Medium
|
Laurynas Biveinis | ||
| 5.6 |
Invalid
|
Undecided
|
Unassigned | ||
Bug Description
Current implementation incorrectly assumes that os_file_t is a C runtime file descriptor (i.e stemms from open() call). However os_file_t is a Windows HANDLE, and it cannot be chsize_s()'ed.
I'll attach a patch against MariaDB 5.1.66 shortly
Related branches
lp:~laurynas-biveinis/percona-server/BT-16274-bug1087202-1087218-5.1
- Stewart Smith (community): Approve
- Laurynas Biveinis (community): Approve
- Sergei Glushchenko: Pending (g2) requested
-
Diff: 158 lines (+40/-16)6 files modifiedPercona-Server/storage/innodb_plugin/handler/i_s.cc (+2/-2)
Percona-Server/storage/innodb_plugin/include/ut0ut.h (+9/-0)
Percona-Server/storage/innodb_plugin/include/ut0ut.ic (+13/-0)
Percona-Server/storage/innodb_plugin/log/log0log.c (+2/-2)
Percona-Server/storage/innodb_plugin/log/log0online.c (+10/-10)
Percona-Server/storage/innodb_plugin/os/os0file.c (+4/-2)
lp:~laurynas-biveinis/percona-server/BT-16274-bug1087202-1087218-5.5
- Stewart Smith (community): Approve
- Sergei Glushchenko (community): Approve (g2)
-
Diff: 143 lines (+36/-12)6 files modifiedPercona-Server/storage/innobase/handler/i_s.cc (+2/-2)
Percona-Server/storage/innobase/include/ut0ut.h (+9/-0)
Percona-Server/storage/innobase/include/ut0ut.ic (+13/-0)
Percona-Server/storage/innobase/log/log0log.c (+2/-2)
Percona-Server/storage/innobase/log/log0online.c (+6/-6)
Percona-Server/storage/innobase/os/os0file.c (+4/-2)
Revision history for this message
| Vladislav Vaintroub (wlad-montyprogram) wrote | #1 |
Revision history for this message
| Laurynas Biveinis (laurynas-biveinis) wrote | #2 |
| tags: | added: contribution |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #3 |
To post a comment you must log in.
Thank you.