[6.1] write in mail.message fails because of non existing variable in fetchmail overriding function
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Odoo Addons (MOVED TO GITHUB) |
Won't Fix
|
Undecided
|
Unassigned | |||
Therp Backports (Deprecated) | Status tracked in Addons-6.1 | |||||
Addons-6.1 |
Fix Released
|
Medium
|
Unassigned |
Bug Description
When calling mail_message.send, the call fails because fetchmail.py overrides the mail_message.write function with a function containing a not existing variable.
Error in log:
File "/home/
self.write(cr, uid, ids, {'state': 'outgoing'}, context=context)
NameError: global name 'server_id' is not defined
These kind of errors should never happen if modern IDE's were used that would catch these errors immediately.
Anyway below is the failing part of the code:
def write(self, cr, uid, ids, values, context=None):
if context is None:
if fetchmail_
res = super(mail_
return res
The variable server_id in the third line from below does not exist. it should be fetchmail_
This has been fixed in trunk / 7.0 in revision r8037, but left unchanged in 6.1.
Related branches
- Stefan Rijnhart (Opener) (community): Approve
- OpenERP Core Team: Pending requested
-
Diff: 11 lines (+1/-1)1 file modifiedfetchmail/fetchmail.py (+1/-1)
- Stefan Rijnhart (Opener) (community): Approve
-
Diff: 11 lines (+1/-1)1 file modifiedfetchmail/fetchmail.py (+1/-1)
Changed in therp-backports: | |
milestone: | none → 6.1-maintenance |
Changed in therp-backports: | |
importance: | Undecided → Medium |
Changed in therp-backports: | |
status: | New → Fix Committed |
Changed in therp-backports: | |
status: | Fix Committed → Fix Released |
Changed in therp-backports: | |
milestone: | 6.1-maintenance → 7.0-maintenance |
no longer affects: | therp-backports/addons-7.0 |
Hello,
Currently, We have improved our code in latest trunk as well as in 7.0. That's why we can not consider this Issue.
So,If you have a support and maintenance contract with us then you can contact with our OPW team at <email address hidden> ,they will definitely help you.
I hope you understand.
Thank you..