nova-compute (folsom) fails to start, compute_driver is None

Bug #1081836 reported by Adam Gandelman
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Invalid
Undecided
Unassigned
Folsom
Fix Released
Critical
Adam Gandelman
nova (Ubuntu)
Fix Released
High
Unassigned
Quantal
Fix Released
Undecided
Unassigned

Bug Description

Running from stable/folsom in preparation for 2012.2.1, nova-compute fails to start using the same config thats been working fine with folsom so far.

~# nova-compute --config-file /etc/nova/nova.conf --config-file /etc/nova/nova-compute.conf
2012-11-21 18:48:20 INFO nova.compute.manager [-] Loading compute driver 'None'
2012-11-21 18:48:20 CRITICAL nova [-] 'NoneType' object has no attribute 'rpartition'
2012-11-21 18:48:20 TRACE nova Traceback (most recent call last):
2012-11-21 18:48:20 TRACE nova File "/usr/bin/nova-compute", line 46, in <module>
2012-11-21 18:48:20 TRACE nova server = service.Service.create(binary='nova-compute')
2012-11-21 18:48:20 TRACE nova File "/usr/lib/python2.7/dist-packages/nova/service.py", line 492, in create
2012-11-21 18:48:20 TRACE nova periodic_fuzzy_delay=periodic_fuzzy_delay)
2012-11-21 18:48:20 TRACE nova File "/usr/lib/python2.7/dist-packages/nova/service.py", line 387, in __init__
2012-11-21 18:48:20 TRACE nova self.manager = manager_class(host=self.host, *args, **kwargs)
2012-11-21 18:48:20 TRACE nova File "/usr/lib/python2.7/dist-packages/nova/compute/manager.py", line 222, in __init__
2012-11-21 18:48:20 TRACE nova importutils.import_object_ns('nova.virt', compute_driver),
2012-11-21 18:48:20 TRACE nova File "/usr/lib/python2.7/dist-packages/nova/openstack/common/importutils.py", line 53, in import_object_ns
2012-11-21 18:48:20 TRACE nova return import_class(import_str)(*args, **kwargs)
2012-11-21 18:48:20 TRACE nova File "/usr/lib/python2.7/dist-packages/nova/openstack/common/importutils.py", line 28, in import_class
2012-11-21 18:48:20 TRACE nova mod_str, _sep, class_str = import_str.rpartition('.')
2012-11-21 18:48:20 TRACE nova AttributeError: 'NoneType' object has no attribute 'rpartition'

Tracked down to this change that looks to be cherry-picked directly from master into stable/folsom: https://review.openstack.org/#/c/16432/

Here, the compute_driver flag was moved to the global flags to fix another issue, but its default value (default='nova.virt.connection.get_connection') is dropped with the move. Without it, installations that have been using connection_type for the last two releases to set compute flavor start with no manager set.

summary: - nova-compute (folsom) fails to start with has no compute_driver
+ nova-compute (folsom) fails to start, compute_driver is None
Thierry Carrez (ttx)
Changed in nova:
status: New → Invalid
Chuck Short (zulcss)
Changed in nova (Ubuntu):
importance: Undecided → High
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/folsom)

Reviewed: https://review.openstack.org/16711
Committed: http://github.com/openstack/nova/commit/7e8a1662577bc86e873f9f957e74076ac89eb80b
Submitter: Jenkins
Branch: stable/folsom

commit 7e8a1662577bc86e873f9f957e74076ac89eb80b
Author: Adam Gandelman <email address hidden>
Date: Wed Nov 21 16:13:29 2012 -0800

    Reinstate default FLAGS.compute_driver for folsom

    A previous cherry-picked commit moved the compute_driver flag from
    the compute manager to the global flags file, but did not take the
    flags default value along. This breaks existing Folsom installations
    that still use connection_type.

    Note, this is only proposed to stable/folsom to fix a regression. Not
    applicable to master as connection_type is gone in Grizzly.

    Fixes bug 1081836.

    Change-Id: I135d6adc215c40fb9f46f382dbe22fb38b413ff8

Revision history for this message
Mark McLoughlin (markmc) wrote :

Thanks for find this nasty issue

This is the commit which introduced the regression: https://review.openstack.org/16432

It's a backport of this: https://review.openstack.org/14991

However, the latter fix was only required to fix an issue with this fix on master: https://review.openstack.org/14068

This is now being backported too: https://review.openstack.org/#/c/16713/

Which means the original backport causing this regression will still be needed and we just need to fix it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/folsom)

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/16773

Revision history for this message
Mark McLoughlin (markmc) wrote :

Wow, some sort of weird overlap.

Revision history for this message
Thierry Carrez (ttx) wrote :

Is there a way we could have caught this at the gate ? Looks more like upgrade testing territory...

Changed in nova (Ubuntu):
status: Confirmed → Fix Released
Changed in nova (Ubuntu Quantal):
status: New → Confirmed
Revision history for this message
Clint Byrum (clint-fewbar) wrote : Please test proposed package

Hello Adam, or anyone else affected,

Accepted nova into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/nova/2012.2.1+stable-20121212-a99a802e-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in nova (Ubuntu Quantal):
status: Confirmed → Fix Committed
tags: added: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (8.3 KiB)

This bug was fixed in the package nova - 2012.2.1+stable-20121212-a99a802e-0ubuntu1

---------------
nova (2012.2.1+stable-20121212-a99a802e-0ubuntu1) quantal-proposed; urgency=low

  * Ubuntu updates:
    - debian/control: Ensure novaclient is upgraded with nova,
      require python-keystoneclient >= 1:2.9.0. (LP: #1073289)
    - d/p/avoid_setuptools_git_dependency.patch: Refresh.
  * Dropped patches, applied upstream:
    - debian/patches/CVE-2012-5625.patch: [a99a802]
  * Resynchronize with stable/folsom (b55014ca) (LP: #1085255):
    - [a99a802] create_lvm_image allocates dirty blocks (LP: #1070539)
    - [670b388] RPC exchange name defaults to 'openstack' (LP: #1083944)
    - [3ede373] disassociate_floating_ip with multi_host=True fails
      (LP: #1074437)
    - [22d7c3b] libvirt imagecache should handle shared image storage
      (LP: #1075018)
    - [e787786] Detached and deleted RBD volumes remain associated with insance
      (LP: #1083818)
    - [9265eb0] live_migration missing migrate_data parameter in Hyper-V driver
      (LP: #1066513)
    - [3d99848] use_single_default_gateway does not function correctly
      (LP: #1075859)
    - [65a2d0a] resize does not migrate DHCP host information (LP: #1065440)
    - [102c76b] Nova backup image fails (LP: #1065053)
    - [48a3521] Fix config-file overrides for nova-dhcpbridge
    - [69663ee] Cloudpipe in Folsom: no such option: cnt_vpn_clients
      (LP: #1069573)
    - [6e47cc8] DisassociateAddress can cause Internal Server Error
      (LP: #1080406)
    - [22c3d7b] API calls to dis-associate an auto-assigned floating IP should
      return proper warning (LP: #1061499)
    - [bd11d15] libvirt: if exception raised during volume_detach, volume state
      is inconsistent (LP: #1057756)
    - [dcb59c3] admin can't describe all images in ec2 api (LP: #1070138)
    - [78de622] Incorrect Exception raised during Create server when metadata
      over 255 characters (LP: #1004007)
    - [c313de4] Fixed IP isn't released before updating DHCP host file
      (LP: #1078718)
    - [f4ab42d] Enabling Return Reservation ID with XML create server request
      returns no body (LP: #1061124)
    - [3db2a38] 'BackupCreate' should accept rotation parameter greater than or
      equal to zero (LP: #1071168)
    - [f7e5dde] libvirt reboot sometimes fails to reattach volumes
      (LP: #1073720)
    - [ff776d4] libvirt: detaching volume may fail while terminating other
      instances on the same host concurrently (LP: #1060836)
    - [85a8bc2] Used instance uuid rather than id in remove-fixed-ip
    - [42a85c0] Fix error on invalid delete_on_termination value
    - [6a17579] xenapi migrations fail w/ swap (LP: #1064083)
    - [97649b8] attach-time field for volumes is not updated for detach volume
      (LP: #1056122)
    - [8f6a718] libvirt: rebuild is not using kernel and ramdisk associated with
      the new image (LP: #1060925)
    - [fbe835f] live-migration and volume host assignement (LP: #1066887)
    - [c2a9150] typo prevents volume_tmp_dir flag from working (LP: #1071536)
    - [93efa21] Instances deleted during spawn leak network allocations
      (LP: #1068716)
    - [ebabd02] After restartin...

Read more...

Changed in nova (Ubuntu Quantal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.