vmbuilder erases current directory with option '-o -d .'

Bug #1080744 reported by Riccardo Murri
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
VMBuilder
New
Undecided
Unassigned
vm-builder (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Adding option '-o -d $(pwd)' to the 'vmbuilder' command line results in the current directory and its contents being completely erased; after a while the scripts fails anyway because `getcwd()` reports error.

This is a dangerous thing to do: 'vmbuilder' should explicitly refuse check that the argument to '-d' is *not* the current directory and refuse to start otherwise.

Also, I think that it should be better explained what the argument to '-d' is expected to be, and what is the combined effect of '-o' and '-d'.

Revision history for this message
Riccardo Murri (rmurri) wrote :
Robie Basak (racb)
Changed in vm-builder (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Thanks, Riccardo, I'll push your fix to r. If you'd like to see it SRU'd, please either mark the releases to which you'd like it SRU'd, or list them in a comment.

Revision history for this message
Riccardo Murri (rmurri) wrote : Re: [Bug 1080744] Re: vmbuilder erases current directory with option '-o -d .'

Thanks Serge, but what does "SRU" mean?

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Quoting Riccardo Murri (<email address hidden>):
> Thanks Serge, but what does "SRU" mean?

"Stable Release Update". I will merge your patch into the upstream bzr
tree and into the raring package. To get the fix into precise or quantal
requires an SRU. See https://wiki.ubuntu.com/StableReleaseUpdates for
more information.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package vm-builder - 0.12.4+bzr482-0ubuntu1

---------------
vm-builder (0.12.4+bzr482-0ubuntu1) raring; urgency=low

  * Merge from ~rmurri/vmbuilder/bug-1080744 (LP: #1080744)
 -- Serge Hallyn <email address hidden> Fri, 23 Nov 2012 15:00:10 -0600

Changed in vm-builder (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Riccardo Murri (rmurri) wrote :

Thanks! I do not think there is a need for SRU.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.