Bogus UNIV_LIKELY/UNIV_UNLIKELY in fil_space_create by separate doublewrite patch
Bug #1078206 reported by
Laurynas Biveinis
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Percona Server moved to https://jira.percona.com/projects/PS | Status tracked in 5.7 | |||||
| 5.1 |
Won't Fix
|
Low
|
Unassigned | |||
| 5.5 |
Triaged
|
Low
|
Unassigned | |||
| 5.6 |
Invalid
|
Undecided
|
Unassigned | |||
| 5.7 |
Invalid
|
Undecided
|
Unassigned | |||
Bug Description
The separate doublewrite patch introduced the following:
if (UNIV_LIKELY(
&& UNIV_UNLIKELY(id < SRV_EXTRA_
&& UNIV_UNLIKELY(id > fil_system-
Which is bogus. UNIV_LIKELY / UNLIKELY work best at the top level of boolean expression. Pushed down they are not useful, because:
UNIV_LIKELY(...) && UNIV_UNLIKELY(...)
still needs both subexpressions evaluated for the "likely" case.
| tags: | added: xtradb |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #1 |
To post a comment you must log in.
Percona now uses JIRA for bug reports so this bug report is migrated to: https:/