Installation doesn't stop when clicking cancel

Bug #107686 reported by Molnár Gábor
18
Affects Status Importance Assigned to Milestone
ubiquity (Ubuntu)
Fix Released
High
Unassigned
Hardy
Fix Released
Undecided
Unassigned

Bug Description

The installer presents a progress window with a close button when it begins to partition and copy files. If the user presses this button, the window will disappear but the process will continue in the background. The fix is a one-liner to disable the close button entirely as it's more dangerous to let them cancel the install halfway through (leaving their system unbootable) than it is to force them to sit through the rest of it.

TEST CASE:
It should not be possible to close the main install progress window. There should be no close button on the window.

The proposed patch as included in the ubiquity 1.8.9 upload can be found here:
http://launchpadlibrarian.net/14910016/107686-disable-close.patch

Original report:
When installing kubuntu(daily-live, 20070417), i clicked cancel after the beginning of the installation process, the small window with the progress bar closed, but the installation continued in the background.

Revision history for this message
Roel Huybrechts (rulus) wrote :

Hi, thanks for your bug report! I changed the package to 'ubiquity', so the subscribers to this package get notified.

Revision history for this message
Colin Watson (cjwatson) wrote :

I thought I'd fixed this, but obviously not hard enough.

Changed in ubiquity:
importance: Undecided → High
status: Unconfirmed → Confirmed
Revision history for this message
Molnár Gábor (csirkus) wrote :

Details:
 I don't know if it is important, maybe it is.
 After clicking cancel, i pressed the 'Back' button to get back to partitioning (i wanted to change the partitioning configuration). Then i chose the manual partitioning, and then next. Another window appeared with a progress bar (there was no text in the window, but i think it should be 'reading partition informations' or something like this). This window left there, and the title of the window contained information about the progress of the installation, like 'copying files', 'configuring apt' etc... After the installation was done i had to 'kill' this, and the main installation window, they didn't disappear.

Evan (ev)
Changed in ubiquity:
status: Confirmed → Fix Committed
description: updated
Revision history for this message
Evan (ev) wrote :
description: updated
Changed in ubiquity:
milestone: none → ubuntu-8.04.1
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubiquity - 1.9.0

---------------
ubiquity (1.9.0) intrepid; urgency=low

  [ Colin Watson ]
  * Fix ownership of /home/oem/Desktop in OEM installations (LP: #209683).
  * Silence deprecation warning in zoommap.
  * Add ubiquity-dm implementation for matchbox-window-manager (thanks,
    Patrick Hétu; see LP #159363).
  * Make use of RAWMINSIZE, RAWCURSIZE, and RAWMAXSIZE variables from
    partman-partitioning 59ubuntu2 to set accurate bounds on the resize
    widget.

  [ Evan Dandrea ]
  * Usability fixes for the timezone widget:
    - Make the hover-to-zoom areas relative to the widget size.
    - Zoom in on the location of the cursor, not the edge relative to its
      position.
    - Add a delay for zooming out.
  * Handle the migration-assistant UI being fed non-UTF data gracefully.
  * Make capitalization of migration-assistant consistent (LP: #225555).
  * Remember hostname between runs of ubiquity (LP: #40590).
  * Disable the close button for progress windows (LP: #107686).
  * Reset stay_on_page when the back button is pressed (LP: #235374).

  [ Mario Limonciello ]
  * Enable --automatic and preseeding support on the Mythbuntu frontend.

 -- Evan Dandrea <email address hidden> Mon, 02 Jun 2008 14:26:30 -0400

Changed in ubiquity:
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

Accepted into -proposed, please test and give feedback here

Revision history for this message
Steve Beattie (sbeattie) wrote : Re: [Bug 107686] Installation doesn't stop when clicking cancel

I've reproduced the reported behavior of ubiquity on the released 8.04
live cd, that clicking the close button on the installation progress
dialog does not actually stop the installation process. I then rebooted
the live cd image, enabled proposed, updated the version of ubiquity to
that in proposed (1.8.11, though I see 1.8.12 is being pushed in), and
the option to close the installation dialog no longer exists.

Installation otherwise proceded normally, though the examination of
existing partitions seemed to take longer than I expected. This may have
been due to the hard disk image being corrupted by the prior partial
installation (I manually killed the background install after I had closed
the installation dialog).

  tag -verification-needed verification-done

--
Steve Beattie
<email address hidden>
http://NxNW.org/~steve/

Revision history for this message
Steve Langasek (vorlon) wrote :

ubiquity 1.8.12 has been copied to hardy-updates.

Changed in ubiquity:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.