pt-fk-error-logger crashes if there's no foreign key error
Bug #1075773 reported by
Daniel Nichter
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
High
|
Daniel Nichter |
Bug Description
If there's never been a fk error, then get_fk_error() tries to match /LATEST FOREIGN KEY ERROR/, finds and returns nothing, but then the main loop continues anyway as long as there's an insert sth. It should actually check the return values of get_fk_error(). Easy to reproduce: just spin up a new sandbox and run the tool and you'll get an error about $ts being undefined.
Related branches
lp:~percona-toolkit-dev/percona-toolkit/fix-pt-fel-bug-1075773
- Daniel Nichter: Approve
-
Diff: 98 lines (+41/-17)2 files modifiedbin/pt-fk-error-logger (+15/-12)
t/pt-fk-error-logger/basics.t (+26/-5)
Changed in percona-toolkit: | |
status: | Triaged → Fix Committed |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Percona now uses JIRA for bug reports so this bug report is migrated to: https:/ /jira.percona. com/browse/ PT-339