Hedgewars 0.9.18 FTBFS on 13.04

Bug #1073730 reported by Derek
38
This bug affects 6 people
Affects Status Importance Assigned to Milestone
hedgewars (Debian)
Fix Released
Unknown
hedgewars (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Upstream release of 0.9.18
Source tarball is available at:
http://download.gna.org/hedgewars/hedgewars-src-0.9.18.tar.bz2
and
http://hedgewars.org/download/hedgewars-src-0.9.18.tar.bz2.torrent

Or of course in mercurial with tag 0.9.18

As with prior releases, users on 0.9.17 will be unable to engage in network play with those on 0.9.18.
For example:
https://bugs.launchpad.net/debian/+source/hedgewars/+bug/852603

(which also includes patches that were added for backporting)
See:
http://code.google.com/p/hedgewars/wiki/BuildingOnLinux

For the expanded dependency list and new optional dependencies (PNG screenshots, Video Recording)

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

I personally think this bug should be fowarded to debian too
---
Ubuntu Bug Squad volunteer triager
http://wiki.ubuntu.com/BugSquad

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in hedgewars (Ubuntu):
status: New → Confirmed
Logan Rosen (logan)
tags: added: upgrade-software-version
Robert Roth (evfool)
Changed in hedgewars (Ubuntu):
importance: Undecided → Wishlist
Changed in hedgewars (Debian):
status: Unknown → New
Revision history for this message
Derek (bugs-m8y) wrote :

Sooo, this seems to happen every release.
Found a bug that caused occasional desyncs in server games.

Fixed on the 0.9.18 branch in mercurial.

New src tarball should be up shortly. Will update.
https://code.google.com/p/hedgewars/source/detail?r=be11c26a3a0be8a2e062d5bf6a746e9a08eac472&name=0.9.18

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

The url for the updated tarball will be this one?

http://download.gna.org/hedgewars/hedgewars-src-0.9.18.tar.bz2
---
Ubuntu Bug Squad volunteer triager
http://wiki.ubuntu.com/BugSquad

Revision history for this message
Derek (bugs-m8y) wrote :

AFAIK unc0rr doesn't intend to bump the release number, yes.

Revision history for this message
Derek (bugs-m8y) wrote :

Ah. He was concerned you guys would pull the wrong one sooo.
http://download.gna.org/hedgewars/hedgewars-src-0.9.18-1.tar.bz2
New URL with patch applied.

Revision history for this message
Derek (bugs-m8y) wrote :

*sigh*
http://download.gna.org/hedgewars/hedgewars-src-0.9.18-2.tar.bz2

Users always find stuff we missed :(

Revision history for this message
Derek (bugs-m8y) wrote :

So far, nothing else has needed emergency fixing. Well, nothing critical. Some cosmetic stuff, and, if Ubuntu used libpng1.5 as arch/gentoo do, would need to replace some images that loaded in libpng1.2 and stopped working in libpng1.5 ( http://code.google.com/p/hedgewars/issues/detail?id=463 )

But, that can probably wait. The src tarball above is not likely to change anymore.

Revision history for this message
Guest One (g.one) wrote :

Is possible a backport update to this version for Ubuntu 12.04 LTS?
Thanks!

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

Both Ubuntu [1] and Debian [2][3] use libpng 1.2 so I don't think we will trigger this bug.

I contacted the debian mantainer, if he answer me I'll package the new version myself (I have already locally merged the new hedgewars source)

For ubuntu 12.04 LTS I personally think there will be a backport, but I don't know how much painful will be (I'll try to package it after debian releases the new version)

[1] https://launchpad.net/ubuntu/+source/libpng
[2] https://launchpad.net/debian/+source/libpng
[3] http://packages.qa.debian.org/libp/libpng.html
---
Ubuntu Bug Squad volunteer triager
http://wiki.ubuntu.com/BugSquad

Revision history for this message
Derek (bugs-m8y) wrote :

Ugh. I erroneously blamed libpng when in fact the problem was somehow, for no reason I can fathom, blank files got into the original source tarball.
i.e. - source tarball does not match mercurial.

This is of course very very bad, would screw you guys up too, and a new source tarball should be created :(

Revision history for this message
Derek (bugs-m8y) wrote :

http://download.gna.org/hedgewars/hedgewars-src-0.9.18-3.tar.bz2 is up

Looks like for some inexplicable reason, 5 images were filled with zeros on the -1 src tarball creation.
I'd just applied a diff and repacked for -2 so preserved the problem there.

-3 was rerun against latest 0.9.18

The arch and gentoo and suse guys are testing it now in their repackaging they are in the progress of doing. Will let you guys know what the guinea pigs^W^W^Wthey report.

Revision history for this message
Derek (bugs-m8y) wrote :

14:06 < hasufell> nemo: confirmed, -3 works

so. at least gentoo feels this does the trick...

Revision history for this message
Derek (bugs-m8y) wrote :

openSUSE confirms it works, and playdeb has picked up the fixed images.

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

Hedgewars [1] is available for precise, quantal and raring in my ppa [2].

I'll ask for an NMU in debian, so the ubuntu bug will be fixed automatically.

[1] hedgewars - 0.9.18
[2] https://code.launchpad.net/~costamagnagianfranco/+archive/locutusofborg-ppa

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

BTW I used the -3 version of the source tarball

Revision history for this message
Derek (bugs-m8y) wrote :

Heh, add a bit of time for testing, by the time it rolls out officially for ubuntu we'll be ready for the next release ;)

Shame playdeb is giving up the ghost, since w/o them, only one or two of the past eight or nine releases had a timely pickup for ubuntu, in any version :-/

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

Unfortunately I have no privileges to speed up this process...

Anyway I'm pretty sure the update will hit raring ringtail and after I'll ask for a backport to quantal and precise too.

The ringtail deadline is 14 february and the package is ready just now.

I think upstream should give developers a little bit more time before pushing out an update that they know will fix online games.

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

I asked of a NMU in debian, and the bug is fixed.
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=691986

now ubuntu should just sync from debian experimental

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Locutus, I went ahead and synced this for you. It builds on all relevant architectures on Debian. Unfortunately it doesn't build on raring today but neither does the current hedgewars. I think the build problem may just be because of an ongoing haskell transition.

Changed in hedgewars (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

Many thanks Jeremy.

I faced this problem when I was building hedgewars in my ppa, first I thought it was my fault in some external dependencies (I added some in order to fix a FTBFS in the new release), but in debian is everything ok, so this isn't my fault, but an haskell one.
Anyway I backported hedgewars to precise, quantal and raring with success (you can see build logs in my ppa), so could you please backport hedgewars for them too?
Should I file a separate bug?

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Go ahead and file a separate bug using requestbackport from ubuntu-dev-tools.
See https://wiki.ubuntu.com/UbuntuBackports for more information.

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

yeah I know how too do it, I was just trying to speed up the whole process.

Anyway I noticed every build in raring failed, not only the arm one, is this a problem in 7.6 haskell release? I built them with only the 7.4 one..

Revision history for this message
Logan Rosen (logan) wrote :

The following pages may help with the build failure (I'm going to test stuff on the package later once the branch has been imported):

http://www.hedgewars.org/node/4164 - a person encountered the same build failure with Haskell 7.6, deleted the offending line, and then it built/worked properly

https://github.com/jlouis/combinatorrent/pull/40/files - the src/Digest.hs change is relevant here (although this is different software, they were experiencing the same build failure) - it checks the version of bytestring first, and if it is one after the version where "instance NFData B.ByteString" was declared, it won't declare it in Digest.hs.

I'd probably go with the latter change if it works because then the package could be backported without issues, potentially.

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Only the Backports team can actually approve backports so the other process is the official way to let them know.

If you want to post a .debdiff to fix the build failure, we can sponsor that for you into raring (just subscribe ubuntu-sponsors). I'm sure the Backports team would be happier if the new version built on the current Ubuntu development version.

Changed in hedgewars (Ubuntu):
status: Fix Committed → Triaged
Changed in hedgewars (Debian):
status: New → Fix Released
Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

Debdiff

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

Hi Jeremy, what do you think about this debdiff? I didn't create an ubuntu1 extension, my opinion is to ask for upload in debian too.

And the patch SHOULD be dropped in backports, since the haskell release is not the latest one, I really hope haskell team will fix this issue upstream

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "hedgewars_0.9.18-0.2.debdiff" of this bug report has been identified as being a patch in the form of a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Backports are ideally supposed to work without any changes. Based on previous comments in this bug, it sounds like this patch is probably not what you want. To make this easier for backports you would either need to make packaging changes which would only apply this patch on raring and later, or submit a different patch that handles both ghc-7.6 as well as earlier ghc. To me, this is an upstream issue and any patch should be submitted there first, since they presumably want to support ghc-7.6. I suggest talking with upstream, then getting this into Debian experimental and then requesting a sync to Ubuntu so that we don't have an Ubuntu delta.

I am unsubscribing ubuntu-sponsors for now. When you've decided how to proceed and there is something to sponsor, please feel free to resubscribe. Thanks!

summary: - Hedgewars 0.9.18 released
+ Hedgewars 0.9.18 FTBFS on 13.04
Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

what about building it without ghc-7.6?
AFAIKS it is only in proposed, so we can build without proposed and in the next release provide a patch (from upstream)

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

Ok I added and uploaded a patch on debian and bumped the NMU release to 0.2.
ASAP a debian developer will upload it you will be able to sync it directly from debian experimental.

this is the commit

http://anonscm.debian.org/gitweb/?p=collab-maint/hedgewars.git;a=commitdiff;h=ff4683fc46f0f4568c1bde5159c2710426ccdc49

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

Hedgewars 0.9.18-0.2 has been accepted into experimental.
Please sync it

thanks

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

@Jamie Strandboge I agree with you, for this reason I asked for another upload in debian side.

This package comes with a good patch from upstream and (I'm pretty sure) should build in both haskell 7.4 and 7.6, so please sync this one and I'll later ask for a backport.
Thanks

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Ok, I synced the new version but it still didn't build on armhf or powerpc. It builds on i386 and amd64 this time though!

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

I don't understand which kind of problem could be this one, seems to be a problem in gcc not in hedgewar, it complains only in ubuntu and NOT in debian (built with gcc-4.6)

So for me is ok to backport to precise and quantal, and maybe to report to gcc's staff this problem.

Revision history for this message
Michael Terry (mterry) wrote :

Unsubscribing ubuntu-sponsors, since there isn't anything for them to do here. (There is no patch to fix the FTBFS for them to review.)

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

Hi, upstream send me a patch for this issue, could anybody give it a try? I cannot try it because ppa armhf has other problems in virtualization and fails before this point

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

This is why I cannot build on armhf
https://bugs.launchpad.net/qemu/+bug/1042388

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :
Revision history for this message
Jeremy Bícha (jbicha) wrote :

I'm unsubscribing the sponsors team for now since until the haskell transition gets further along, this package is unbuildable on raring. You can see the list of haskell packages that haven't built yet at http://qa.ubuntuwire.org/ftbfs/

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

Sorry Jeremy but I don't understand the problem in this FTBFS, there is no delta from debian, what is the cause?
Furthermore I still don't understand why the official builders doesn't have this problem, while the ppas have it.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package hedgewars - 0.9.18-0.2ubuntu1

---------------
hedgewars (0.9.18-0.2ubuntu1) raring; urgency=low

  * Build-depend on ghc and libghc-* rather than the transitional ghc6 and
    libghc6-*.
 -- Colin Watson <email address hidden> Wed, 10 Apr 2013 12:43:22 +0100

Changed in hedgewars (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

Hi Colin, could you please apply this patch too?
[1] https://launchpadlibrarian.net/136140517/fix-armhf-ftbfs.patch

Upstream claims it will really fix the armhf build

Revision history for this message
Derek (bugs-m8y) wrote :

So I just spent an hour going through possible problems w/ user running 13.04 who was failing to launch the engine.

Finally figured out the package for 13.04 was built against freeglut3 (video recording) but did not include that as a package dependency.

That is, game will not function on any Ubuntu 13.04 system where the user does not have freeglut3 already installed.

Revision history for this message
Derek (bugs-m8y) wrote :

WRT comment #44. n/m
14:19 < debfx> it's already fixed but hasn't propagated to -updates yet
14:19 < debfx> https://launchpad.net/ubuntu/+source/hedgewars/0.9.18-0.2ubuntu1.1

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.