Ubuntu
munin package

munin-node does not honour pid_file configuration setting

Bug #107335 reported by Remi Broemeling
2
Affects Status Importance Assigned to Milestone
munin (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: munin-node

The source of the program /usr/sbin/munin-node does not honour the pid_file setting in the configuration file /etc/munin/munin-node.conf. No matter what the pid_file setting is within the configuration file, "/var/run/munin/munin-node.pid" is used as the PID file location by Net::Server.

I believe this is because of the code around line 269:

MyPackage->run(conf_file => $conffile, pid_file => "/var/run/munin/munin-node.pid");

... from the Net::Server documentation, pid_file will always take priority over the configuration file passed in. The relevant section of the Net::Server documentation is the 'Arguments' section ( http://search.cpan.org/dist/Net-Server/lib/Net/Server.pod#ARGUMENTS ).

Tags: patch

Related branches

lp:ubuntu/karmic/munin
Revision history for this message
Remi Broemeling (remi-nexopia) wrote :

I believe that this patch addresses the issue by moving the static pid_file assignment of "/var/run/munin/munin-node.pid" to a lower priority than the configuration file (by returning it from the default_values method, rather than passing it as a parameter to the ->run() call).

However, I believe that default_values is only useable from Net::Server version 0.96 and onwards.

Revision history for this message
Remi Broemeling (remi-nexopia) wrote :

Further information: applies to Ubuntu Edgy, munin-node package 1.2.4-1ubuntu1. Not sure if the problem exists in package versions later than that; but I don't see the issue reported or dealt with in the changelogs/bug reports visible on Launchpad.

Revision history for this message
Chuck Short (zulcss) wrote :

If possible can you provide a way of reproducing this bug?

Thanks
chuck

Changed in munin:
status: New → Incomplete
Revision history for this message
Remi Broemeling (remi-nexopia) wrote :

I am not sure what is unclear. Set pid_file to a random location (/tmp/munin-node.pid) in the munin-node.conf file, and then start munin-node.

The pid_file will be located at /var/run/munin/munin-node.pid , not /tmp/munin-node.pid.

The setting in munin-node.conf is ignored -- over-ridden by the parameter to Net::Server->run().

Revision history for this message
Remi Broemeling (remi-nexopia) wrote :

This bug has been verified to still exist as of package munin-node version 1.2.5-1.

Changed in munin:
status: Incomplete → New
Revision history for this message
Chuck Short (zulcss) wrote :

This should be fixed now.

Changed in munin:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.