Device counter can no longer be changed through WebUI

So locally, with trunk, changing the counter through admin works (and the counter is changed in the db). In fact due to the way the admin works, the value shown in the UI *comes* from the db (I believe) - so if the new value is shown then it seems unlikely that it *hasn't* been written to the db.

One possibility is a race condition? If the user is actively trying to log in whilst you are changing their account through the admin then simultaneous writes could happen (although that seems unlikely too).

Could you try and repro this on a test account - perhaps on staging? (I don't have admin access.)

Another possibility (more likley) is that there was some error with the form submission - so that the change was not saved. The new value would still be shown in the form but not persisted. Is it possible there was some error warning that you didn't notice?

I have confirmed that this doesn't work in staging either and I can't see any errors being reported on the web page. I have also tested, in staging, updating "Device name" and swicthing "Twofactor required", none of these updates actually stick which I've confirmed by querying the database.

I've also noted that after clicking save I seem to remember I used to be navigated away from the account I was editing, this is not happening anymore. Instead the page seems to reload but I stay on the same page. Also, I do not see my update listed on Model Admin -> Recent Actions

I was just able to delete an old 2fa device, in production, successfully. So it looks like some update types do still work

pindoga has pointed out that the problem is that device type is now a mandatory field when the form is submitted,
 however, most devices don't have the device type filled in so if the device counter is updated, for example, we need to also add generic/yubi/paper/google into the device type

The problem seems to be the device_type column which is required: enter a value of "generic", "google", "yubi" or "paper" and it should work. We will work on making this field render as a dropdown combo box for convenience.