XtraBackup handles separate doublewrite buffer file incorrectly
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona XtraBackup moved to https://jira.percona.com/projects/PXB |
Fix Released
|
High
|
Sergei Glushchenko | ||
| 2.0 |
Fix Released
|
High
|
Sergei Glushchenko | ||
| 2.1 |
Fix Released
|
High
|
Sergei Glushchenko | ||
Bug Description
During backup xtrabackup copies doublewrite buffer file from the path specified in my.cnf to the root backup directory. Then during prepare doublewrite buffer file is not specified in backup-my.cnf, and not used. When copy back is done old doublewrite buffer file copied to root data directory, which could cause failures on server startup.
Following are incorrect:
1. Path to doublewrite buffer file is not specified in backup-my.cnf
2. Prepare should use doublewrite buffer file from root of backup dir
3. Copy back should not copy doublewrite buffer file as it is not needed after prepare is done.
In the case of run with our test framework we have even worst behavior. Instead of looking at backup-my.cnf prepare look at original my.cnf (--defaults-file is specified) and modify original doublewrite buffer file.
Related branches
- Alexey Kopytov (community): Approve
- Laurynas Biveinis: Pending requested
-
Diff: 200 lines (+144/-2)3 files modifiedinnobackupex (+14/-1)
src/xtrabackup.c (+10/-1)
test/t/ib_doublewrite.sh (+120/-0)
- Laurynas Biveinis (community): Needs Fixing
-
Diff: 7928 lines (+3748/-2732) (has conflicts)36 files modifiedVERSION (+1/-1)
doc/source/conf.py (+3/-3)
doc/source/innobackupex/how_innobackupex_works.rst (+0/-4)
doc/source/innobackupex/innobackupex_option_reference.rst (+2/-6)
doc/source/innobackupex/innobackupex_script.rst (+0/-1)
doc/source/innobackupex/remote_backups_ibk.rst.THIS (+1/-5)
doc/xtrabackup.1 (+0/-15)
innobackupex (+54/-207)
src/Makefile (+14/-5)
src/common.h (+27/-7)
src/datasink.c (+113/-0)
src/datasink.h (+46/-8)
src/ds_compress.c (+31/-70)
src/ds_compress.h (+2/-5)
src/ds_local.c (+0/-3)
src/ds_local.h (+2/-2)
src/ds_stream.c (+5/-2)
src/ds_stream.h (+2/-2)
src/ds_tmpfile.c (+243/-0)
src/ds_tmpfile.h (+28/-0)
src/fil_cur.c (+270/-0)
src/fil_cur.h (+96/-0)
src/innodb_int.c (+983/-0)
src/innodb_int.h (+695/-0)
src/quicklz/quicklz.h (+1/-0)
src/write_filt.c (+321/-0)
src/write_filt.h (+65/-0)
src/xbstream.c (+15/-19)
src/xtrabackup.c (+461/-2365)
src/xtrabackup.h (+50/-0)
test/disabled/compact.sh (+35/-0)
test/disabled/compact_compressed.sh (+53/-0)
test/inc/common.sh (+19/-0)
test/run.sh (+1/-0)
test/t/bug1066843.sh (+107/-0)
test/t/bug766033.sh (+2/-2)
- Alexey Kopytov (community): Approve
- Laurynas Biveinis: Pending requested
-
Diff: 283 lines (+148/-26)3 files modifiedinnobackupex (+14/-1)
src/xtrabackup.c (+14/-25)
test/t/ib_doublewrite.sh (+120/-0)
| Changed in percona-xtrabackup: | |
| status: | New → Confirmed |
| assignee: | nobody → Sergei Glushchenko (sergei.glushchenko) |
| importance: | Undecided → High |
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #1 |
Percona now uses JIRA for bug reports so this bug report is migrated to: https:/