duplicate entry added to named.conf.local on each package reconfigure

Bug #1066929 reported by Zygmunt Krynicki
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Undecided
Unassigned
1.2
Fix Released
Critical
Julian Edwards
maas (Ubuntu)
Fix Released
Undecided
Gavin Panella
Precise
Fix Released
Undecided
Unassigned

Bug Description

Running dpkg-reconfigure maas-dns breaks the current dns config

Observation seems to indicate that each reconfigure appends the following line to /etc/bind/named.conf.local

include "/etc/bind/maas/named.conf.maas";

This causes bind to choke and output confusing messages about multiple definitions of the master zone

ProblemType: Bug
DistroRelease: Ubuntu 12.10
Package: maas-dns 0.1+bzr1264+dfsg-0ubuntu1
ProcVersionSignature: Ubuntu 3.5.0-17.28-generic 3.5.5
Uname: Linux 3.5.0-17-generic i686
ApportVersion: 2.6.1-0ubuntu3
Architecture: i386
Date: Mon Oct 15 17:04:52 2012
InstallationMedia: Ubuntu-Server 12.10 "Quantal Quetzal" - Release i386 (20121014)
PackageArchitecture: all
ProcEnviron:
 LANGUAGE=en_US:en
 TERM=xterm-256color
 PATH=(custom, no user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: maas
UpgradeStatus: No upgrade log present (probably fresh install)

== TEST CASE ==
1. Install MAAS with DNS server.
2. dpkg-reconfigure maas-dns
3. make sure line is not duplicationed in /etc/bind/maas/named.conf.maas

Tested in the lenovo lab. Runnning "dpkg-reconfigure maas-dns" does not append the same include line over and over.

Related branches

Revision history for this message
Zygmunt Krynicki (zyga) wrote :
Revision history for this message
Raphaël Badin (rvb) wrote :

I see two ways to fix this:
- we can fix this in the packaging and avoid adding the entry in /etc/bind/named.conf.local if it's already there
or
- we can fix the 'get_named_conf' command so that it won't include the snippet if it's already there. Maybe we could use write_custom_config_section (src/provisioningserver/utils.py) but I wonder if we can manage the upgrade properly.

Gavin Panella (allenap)
Changed in maas (Ubuntu):
assignee: nobody → Gavin Panella (allenap)
status: New → In Progress
Gavin Panella (allenap)
Changed in maas (Ubuntu):
status: In Progress → Fix Committed
tags: added: sru-12.10
Raphaël Badin (rvb)
Changed in maas (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Dave Walker (davewalker) wrote : Please test proposed package

Hello Zygmunt, or anyone else affected,

Accepted into quantal-proposed. The package will build now and be available in a few hours in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Changed in maas (Ubuntu):
status: Fix Released → Fix Committed
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package maas - 0.1+bzr1269+dfsg-0ubuntu1

---------------
maas (0.1+bzr1269+dfsg-0ubuntu1) quantal-proposed; urgency=low

  * New upstream bugfix release
    - Fixes commissioning failing to set memory attribute. (LP: #1064638)
    - Fixes node listing by adding pagination (LP: #1064672)
    - Changes default bind rndc key which breaks initscripts (LP: #1066938)
    - Fixes invalid DNS config once node is enlisted (LP: #1066958)
    - Reference documentation link to correct URL (LP: #1067261)

  [ Andres Rodriguez ]
  * debian/rules: Change upstream branch.

  [ Gavin Panella ]
  * debian/maas-dns.postinst: Remove MAAS-related include lines from named's
    config before adding a new one (LP: #1066929)

  [ Raphael Badin ]
  * debian/extras/maas-region-celeryd: Remove whitespace that affects DNS
    rabbitmq queue. (LP: #1067929)
 -- Andres Rodriguez <email address hidden> Tue, 16 Oct 2012 10:31:37 -0400

Changed in maas (Ubuntu):
status: Fix Committed → Fix Released
tags: added: verification-done
removed: verification-needed
description: updated
Revision history for this message
Dave Walker (davewalker) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Dave Walker (davewalker)
Changed in maas (Ubuntu Precise):
status: New → Fix Released
Changed in maas:
status: New → Fix Released
no longer affects: maas/1.2
no longer affects: maas
Changed in maas:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.