No exclude option to skip tests in run_tests.sh

Bug #1065758 reported by Gerardo Porras
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Gerardo Porras
Folsom
Fix Released
Low
Gerardo Porras
Grizzly
Fix Released
Low
Gerardo Porras
glance (Ubuntu)
Fix Released
Undecided
Unassigned
Quantal
Fix Released
Undecided
Unassigned

Bug Description

Please add the noseopts to the run_tests.sh so we can exclude tests, same as keystone does

addin the following line to the process_option function

    -*) noseopts="$noseopts $1";;

And

NOSETESTS="nosetests $noseopts $noseargs"

Revision history for this message
Gerardo Porras (gerardo8a) wrote :

diff --git a/run_tests.sh b/run_tests.sh
index 6812a8f..d7759a8 100755
--- a/run_tests.sh
+++ b/run_tests.sh
@@ -26,6 +26,7 @@ function process_option {
     -f|--force) let force=1;;
     --unittests-only) noseargs="$noseargs --exclude-dir=glance/tests/functional";;
     -c|--coverage) noseargs="$noseargs --with-coverage --cover-package=glance";;
+ -*) noseopts="$noseopts $1";;
     *) noseargs="$noseargs $1"
   esac
 }
@@ -67,7 +68,7 @@ function run_pep8 {
 }

-NOSETESTS="nosetests $noseargs"
+NOSETESTS="nosetests $noseopts $noseargs"

 if [ $never_venv -eq 0 ]
 then

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/14514

Changed in glance:
assignee: nobody → Gerardo Porras (gerardo8a)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/14514
Committed: http://github.com/openstack/glance/commit/b075e90c8df094929601d73d05b446fbaff6fa69
Submitter: Jenkins
Branch: master

commit b075e90c8df094929601d73d05b446fbaff6fa69
Author: Gerardo Porras <email address hidden>
Date: Wed Oct 17 16:00:48 2012 -0700

    Add noseopts and replace noseargs where needed to run_test.sh

    Add of noseopts to the run_tests script so users can be
    able to run tests adding extra options to be passed to
    nosetests.
    This option is currently in keystone but not in glance.
    Fixes bug 1065758

    Change-Id: I7c78749adb90b126da5bd9580da6bfd7c9e1bf54

Changed in glance:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (stable/folsom)

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/14657

Brian Waldon (bcwaldon)
Changed in glance:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (stable/folsom)

Reviewed: https://review.openstack.org/14657
Committed: http://github.com/openstack/glance/commit/8321ca6ff4d2ab15bece70d7ff84f2e3dd3f6896
Submitter: Jenkins
Branch: stable/folsom

commit 8321ca6ff4d2ab15bece70d7ff84f2e3dd3f6896
Author: Gerardo Porras <email address hidden>
Date: Wed Oct 17 16:00:48 2012 -0700

    Add noseopts and replace noseargs where needed to run_test.sh

    Add of noseopts to the run_tests script so users can be
    able to run tests adding extra options to be passed to
    nosetests.
    This option is currently in keystone but not in glance.
    Fixes bug 1065758

    Change-Id: I7c78749adb90b126da5bd9580da6bfd7c9e1bf54

tags: added: in-stable-folsom
Thierry Carrez (ttx)
Changed in glance:
milestone: none → grizzly-1
status: Fix Committed → Fix Released
Changed in glance (Ubuntu):
status: New → Fix Released
Changed in glance (Ubuntu Quantal):
status: New → Confirmed
Revision history for this message
Clint Byrum (clint-fewbar) wrote : Please test proposed package

Hello Gerardo, or anyone else affected,

Accepted glance into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/glance/2012.2.1-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in glance (Ubuntu Quantal):
status: Confirmed → Fix Committed
tags: added: verification-needed
Mark McLoughlin (markmc)
tags: removed: in-stable-folsom
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package glance - 2012.2.1-0ubuntu1

---------------
glance (2012.2.1-0ubuntu1) quantal-proposed; urgency=low

  * Dropped patches, applied upstream:
    - debian/patches/CVE-2012-4573.patch
    - debian/patches/CVE-2012-4573b.patch
  * Resynchronize with stable/folsom (199783ce) (LP: #1085255):
    - [49408e9] Glance image-delete HTTPInternalServerError HTTP 500
      (LP: #1075580)
    - [91aaa48] Image fails to upload to swift: TypeError: object of type
      'CooperativeReader' has no len( (LP: #1057322)
    - [a296a5b] Return 403 when admin deletes a deleted image (LP: #1060944)
    - [3e58a6a] Disallow updating deleted images. (LP: #1060930)
    - [26c8085] admins can see deleted images in v2 api (LP: #1071446)
    - [8321ca6] No exclude option to skip tests in run_tests.sh (LP: #1065758)
    - [c3bea11] Badly named stable/folsom Glance tarballs (LP: #1059634)
    - [fc0ee76] Non-admin users can cause public glance images to be deleted
      from the backend storage repository in the v2 api (LP: #1076506)
    - [90bcdc5] Non-admin users can cause public glance images to be deleted
      from the backend storage repository (LP: #1065187)
    - [7841cc9] FakeAuth not always admin
    - [ddad275] Jenkins jobs fail because of incompatibility between sqlalchemy-
      migrate and the newest sqlalchemy-0.8.0b1 (LP: #1073569)
    - [1d5c651] nosetest options cause no such option errors (LP: #1056420)
    - [ac223e2] Set defaultbranch in .gitreview to stable/folsom
 -- Adam Gandelman <email address hidden> Tue, 04 Dec 2012 09:19:35 -0800

Changed in glance (Ubuntu Quantal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.