Dash - Correct visual issues with the focused state of buttons in the Dash preview
Bug #1064969 reported by
John Lea
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ayatana Design |
Fix Released
|
High
|
John Lea | ||
| Unity |
Fix Released
|
High
|
Unassigned | ||
| unity (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Bug Description
See attached image Dash_focused_
-------
Desired solution:
- Update the Dash Preview buttons to make the button fill slightly more transparent.
- Contact Rosie if exact values or visual assets are required.
Related branches
lp:~nick-dedekind/unity/lp1064969.preview-focus-opacity
- Brandon Schaefer (community): Approve
- jenkins: Pending (continuous-integration) requested
-
Diff: 47 lines (+4/-4)3 files modifieddash/previews/ActionButton.cpp (+1/-1)
unity-shared/DashStyle.cpp (+2/-2)
unity-shared/DashStyle.h (+1/-1)
Revision history for this message
| John Lea (johnlea) wrote | #1 |
| Changed in ayatana-design: | |
| status: | New → Triaged |
| Changed in unity: | |
| status: | New → Triaged |
| Changed in unity (Ubuntu): | |
| status: | New → Triaged |
| Changed in ayatana-design: | |
| status: | Triaged → Fix Committed |
| Changed in unity: | |
| milestone: | none → backlog |
| importance: | Undecided → High |
| Changed in unity (Ubuntu): | |
| importance: | Undecided → High |
| Changed in ayatana-design: | |
| importance: | High → Critical |
Revision history for this message
| Nick Dedekind (nick-dedekind) wrote | #2 |
Revision history for this message
| John Lea (johnlea) wrote | #3 |
| Changed in ayatana-design: | |
| importance: | Critical → High |
| description: | updated |
| Changed in unity: | |
| status: | Triaged → Fix Committed |
| Changed in unity (Ubuntu): | |
| status: | Triaged → Fix Released |
| Changed in unity: | |
| status: | Fix Committed → Fix Released |
| Changed in ayatana-design: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
In terms of dash consistency, the design shows the button in 'active' state, not the 'focused' state, meaning that the button is currently pressed.
If you have a look at the dash filters, and move the mouse over the buttons, the focus will shift, showing the same design as in the current previews. Only if you click a "checkable" button, then does the design change to that of the screenshot of the preview design.
The preview actions are not "checkable" (ie they cannot be persistently active). If you click and hold the left mouse button on a preview action, then you will see the button design with a thick border.
If you still want the button to match your given designs, I will change it.