another sporadic state/presence failure

Still occuring as of rev 827

----------------------------------------------------------------------
FAIL: presence_test.go:253: PresenceSuite.TestWatchPeriod

[LOG] 21.82379 JUJU state/presence: Faking presence to time slot 0
[LOG] 21.82385 JUJU state/presence: Not faking presence time. Real time slot in use.
[LOG] 21.84842 JUJU:DEBUG state/presence: got request: presence.reqWatch{key:"a", ch:(chan<- presence.Change)(0xc2007d4840)}
[LOG] 21.84868 JUJU:DEBUG state/presence: synchronizing watcher knowledge with database...
[LOG] 21.85689 JUJU:DEBUG state/presence: starting pinger for "a" with seq=1
[LOG] 21.85690 JUJU:DEBUG state/presence: pinging "a" with seq=1
[LOG] 21.85783 JUJU:DEBUG state/presence: stopping pinger for "a" with seq=1
[LOG] 22.84881 JUJU:DEBUG state/presence: synchronizing watcher knowledge with database...
presence_test.go:272:
    assertChange(c, ch, presence.Change{"a", true})
presence_test.go:63:
    c.Fatalf("watch reported nothing, want %v", want)
... Error: watch reported nothing, want {a true}

OOPS: 10 passed, 1 FAILED
--- FAIL: TestPackage (9.39 seconds)

I have seen this in r951: http://paste.ubuntu.com/5576020/

And once more today, this time r952.

----------------------------------------------------------------------
FAIL: presence_test.go:253: PresenceSuite.TestWatchPeriod

[LOG] 52.80110 JUJU state/presence: Faking presence to time slot 0
[LOG] 52.80116 JUJU state/presence: Not faking presence time. Real time slot in use.
[LOG] 52.83828 JUJU:DEBUG state/presence: got request: presence.reqWatch{key:"a", ch:(chan<- presence.Change)(0xf840680be0)}
[LOG] 52.83845 JUJU:DEBUG state/presence: synchronizing watcher knowledge with database...
[LOG] 52.84374 JUJU:DEBUG state/presence: starting pinger for "a" with seq=1
[LOG] 52.84376 JUJU:DEBUG state/presence: pinging "a" with seq=1
[LOG] 52.84513 JUJU:DEBUG state/presence: stopping pinger for "a" with seq=1
[LOG] 53.83901 JUJU:DEBUG state/presence: synchronizing watcher knowledge with database...
presence_test.go:272:
    assertChange(c, ch, presence.Change{"a", true})
presence_test.go:63:
    c.Fatalf("watch reported nothing, want %v", want)
... Error: watch reported nothing, want {a true}

OOPS: 10 passed, 1 FAILED
--- FAIL: TestPackage (10.10 seconds)
FAIL
FAIL launchpad.net/juju-core/state/presence 10.338s

And again (r965):

----------------------------------------------------------------------
FAIL: presence_test.go:253: PresenceSuite.TestWatchPeriod

[LOG] 27.82981 JUJU state/presence: Faking presence to time slot 0
[LOG] 27.82986 JUJU state/presence: Not faking presence time. Real time slot in use.
[LOG] 27.86029 JUJU:DEBUG state/presence: got request: presence.reqWatch{key:"a", ch:(chan<- presence.Change)(0xf84069c910)}
[LOG] 27.86069 JUJU:DEBUG state/presence: synchronizing watcher knowledge with database...
[LOG] 27.86634 JUJU:DEBUG state/presence: starting pinger for "a" with seq=1
[LOG] 27.86636 JUJU:DEBUG state/presence: pinging "a" with seq=1
[LOG] 27.86728 JUJU:DEBUG state/presence: stopping pinger for "a" with seq=1
[LOG] 28.86080 JUJU:DEBUG state/presence: synchronizing watcher knowledge with database...
presence_test.go:272:
    assertChange(c, ch, presence.Change{"a", true})
presence_test.go:63:
    c.Fatalf("watch reported nothing, want %v", want)
... Error: watch reported nothing, want {a true}

OOPS: 10 passed, 1 FAILED
--- FAIL: TestPackage (10.16 seconds)
FAIL
FAIL launchpad.net/juju-core/state/presence 10.438s

I don't think Launchpad is able to fix bugs just by pasting the same error message over and over again.

It'd be a great feature, though.

Yeah, no need to keep pasting the error if it's not changing (and if there's a different error, it's probably a different bug; we can always mark dupes when we figure that out). However, I do appreciate the continued strumming of the this-is-a-problem chord -- perhaps just add a note when you see it in a newer rev than the latest recorded?

Gustavo, if you're bored on a plane sometime, that sounds like an awesome feature. +1 ;-p.