privacy banner and information type coupled
Bug #1061643 reported by
Richard Harding
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Richard Harding | ||
Bug Description
In fixing a bug the privacy banner and information type modules were coupled up. The original issue was a function moved off the JS namespace when it shouldn't have been. This updates to remove the extra coupling that was added.
Related branches
lp:~rharding/launchpad/fix_banner_cleanup
- j.c.sackett (community): Approve
-
Diff: 171 lines (+28/-50)5 files modifiedlib/lp/app/javascript/banners/banner.js (+7/-2)
lib/lp/app/javascript/banners/privacy.js (+8/-8)
lib/lp/app/javascript/banners/tests/test_privacy.js (+7/-39)
lib/lp/app/javascript/information_type.js (+2/-0)
lib/lp/app/javascript/tests/test_information_type.js (+4/-1)
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r16113 <http://