needless shell=True in a subprocess.Popen call

Bug #1060192 reported by David
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
software-properties (Ubuntu)
Fix Released
Low
Robert Roth

Bug Description

Whilst there is no issue with the following use of subprocess.Popen with shell=True today there is no reason to use it with shell=True in this instance.

In softwareproperties/MirrorTest.py on line 29 (through to line 34) under the PingWorker the following code is found:

                   host = mirror.hostname

                    self.parent.report_action("Pinging %s..." % host)
                    commando = subprocess.Popen("ping -q -c 2 -W 1 -i 0.5 %s" % host,
                                                shell=True, stdout=subprocess.PIPE,
                                                stderr=subprocess.STDOUT).stdout

The code should be changed to something like the following:

                    commando = subprocess.Popen(["ping", "-q", "-c 2", "-W 1", "-i 0.5", host]
                                                , stdout=subprocess.PIPE,
                                                stderr=subprocess.STDOUT).stdout

Related branches

Robert Roth (evfool)
Changed in software-properties (Ubuntu):
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → Robert Roth (evfool)
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-properties - 0.92.14.1

---------------
software-properties (0.92.14.1) raring; urgency=low

  * Build-depend on python-setuptools.
 -- Matthias Klose <email address hidden> Fri, 15 Feb 2013 20:01:57 +0100

Changed in software-properties (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.