javascript error on pages that show the privacy banner
Bug #1057248 reported by
Ian Booth
This bug affects 6 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Ian Booth | ||
Bug Description
Goto a proprietary bug page and get this javascript error in the console:
TypeError: info_type is undefined
Y.on(info_
The affected code lives in lp/app/
The above js file also contains another error, a call to an unexported function:
banner_text = info_type.
This bit of code is also untested as far as I can tell.
Related branches
lp:~wallyworld/launchpad/privacy-javascript-errors-1057248
- Curtis Hovey (community): Approve (code)
-
Diff: 219 lines (+87/-15)3 files modifiedlib/lp/app/javascript/banners/privacy.js (+9/-7)
lib/lp/app/javascript/banners/tests/test_privacy.js (+65/-1)
lib/lp/app/javascript/information_type.js (+13/-7)
| summary: |
- javascript error on bugtask page + javascript error on pages that show the privacy banner |
| tags: | added: qa-ok |
| Changed in launchpad: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
There's also a bunch of other typos to fix:
thow('A custom privacy banner must have a text attribute');
Plus some uninitialised variables.