[FFE] Use music lens details page for music store results

Is this entirely necessary at this point? Shouldn't we be fixing what we've already got instead?

Iain, what we've already got is that half of the results in the shopping lens (the ones from u1ms) have no preview at all.

@Iain, this was actually one of the main UI bugs to fix for this release as without it, right-clicking on a U1 Music Store result would give you http://cloudfront.omgubuntu.co.uk/wp-content/uploads/2012/09/unity-shopping-preview.jpg. The UI shown now is the same as the music lens has already been showing and doesn't introduce any new translatable strings etc, just makes sure we actually show the data.

I hope that is okay for inclusion.

It sounds like the current behavior is broken and this is just fixing it.

Can you send us an "after" screenshot too?

After Beta 2 is far, far too late to be landing something that was "one of the main UI bugs to fix for this release". You need to plan ahead.

This is non-critical (although I understand desirable). I think it's too late for non-critical. We should focus on landing the critical changes like the online search privacy change and the shopping switch to https. Nack from me.

I agree with Jeremy here, this looks like a bug to me and would likely be interpreted as such by most users. +1 from me.

Looking through the diff, it looks like you're duplicating code from the music lens which doesn't seem ideal, is there a plan to share the code between the two?

Looks like both Scott and I commented at the same time ;)

To try and find some middle ground here, I'd be happy if we simply turn off previews completely for the shopping lens.
That'd make it look fine to our users and the new feature can safely land in R.

@Stephane: yep, for R we're hoping to share the logic instead of duplicating it.

@Scott: 'this release' = this week's release of unity-lens-shopping, not of Quantal. My point was that this isn't a flourish, it's a real bug that effects UX.

Pavel will be adding 'after' screenshots shortly, thanks.

Courtesy of Pavel: http://ubuntuone.com/2oU6sCGzUzqU7PIZULJ6GW (same thing as in music lens)

Every U/I change affects UX, so that's not much of selection criteria. At some
point U/I cleanup has to stop and we're well past when that is supposed to be.
That said, I'm not marking the bug wontfix. skaet said she will review after
beta 2 is out.

At this point, Stephane's approach of disabling the preview seems like the best path to a reasonable user experience.

That the first version didn't land solid, indicates we probably have more bugs than this, and disabling this for now, and getting it working solid early in R, seems like the path for the best customer impression.

Kate, when you say "didn't land solid" what do you mean?

To be clear, previews are a key element of product search, and removing them would seriously detract from the usefulness of the feature.

Can you please explain the reasoning a little more, as to why we need to cripple the feature?

If you want time to fix up stuff after it lands, land it before feature freeze, not just weeks before release.

We appreciate how late we've landed this whole feature, and I apologize once again for the disruption this is causing to the release. We have apologized for that from the start (even in e.g. Olli's email), but allow me to assure you that the apology is quite sincere, and that we know how this kind of disruption and late-landing changes are typically high risk and can impact the quality of the release, and that you are quite concerned about that.

On the flip side we'd like you to understand that we have also compromised a lot of features and designed functionality to accommodate the ubuntu release process, and that this is one instance where we don't think it's reasonable to compromise. The branch associated with this tag works well, is well-tested (because it is the same code present in the music lens), and is a drastic improvement over what's in the archive right now. Do you understand that your proposed solution is instead a big regression?

What can we do to help overcome your concerns and get this through without the inevitable escalation?

 That this is common code with another late landing feature removes some risk, but it would help if you could please provide a much more detailed account of the testing that has been done on the branch, so we can get some confidence the fix is not going to cause further regressions:
- How many folks have tested this?
- What test cases were executed? What happens when network connection not present? what happens on arm? etc. Please provide a much more detailed account of the testing that has been done.

I think on this one the fix is better than the revert. The revert will end up in an empty preview view with only a title. Not a stellar new experience for ubuntu.

In addition to that, the PS integration team is currently testing succesfully the feature under different circumstances and we have a company contracted by PS to get the tests of next unity release including that one. I feel the risk is low for a higer benefit compared to the revert itself.

I tested this using "ppa:unity-lens/ppa" and it works well.

Open dash
Search for artist (chose Blondie which I know I have local and will be in store)
Right click on album in dash, preview appears
Click on track to start playing
Click on Download option to trigger launching online store

Also tested with network disconnected searching for tracks I know I have, and tracks I know I don't have. Screenshots attached.

I can only add to what Dider & Alan said, that this feature has been first implemented in music lens and present there since around 22-08-2012 with no bugs reported with regard to u1ms previews & playback. Also, several manual tests for it are present in music-lens repository.

For reference, I made a screenshot of empty preview (if previews were disabled completely for shopping lens results) - http://ubuntuone.com/6eUF3XpY6AVdO2otK8wPRh

Thanks for the screen shots Alan and Pawel. That helps. yes.

Can someone please test that this is sane on arm hardware and there are no surprises there?

If anybody has an arm build of the ppa, please let me know; otherwise I'll be building it starting tomorrow.

@John, "ppa:unity-lens/ppa" has the ARM build.

Bah! I gave the wrong PPA name, sorry.

ppa:unity-team/ppa

After much mucking around, it turns out none of my ARM boards will run unity in Q, not even in "slideshow" mode. Alan is helping me find somebody who can test.

John, Alan,
    Paul Larson was trying to get a system working yesterday, and will be trying to get one working today. He's agreed to post any results he finds out here in this bug.

From #ubuntu-release channel
<plars> popey: ok, I can confirm that preview works too, sorry for the delay
<popey> plars, no need to apologise, I really appreciate you taking the time to test it, thanks!
Based on this, ok to upload.

This bug was fixed in the package unity-lens-shopping - 6.8.0-0ubuntu1

---------------
unity-lens-shopping (6.8.0-0ubuntu1) quantal-proposed; urgency=low

  [ Łukasz 'sil2100' Zemczak ]
  * New upstream release.
    - Use music lens details page for music store results (LP: #1055684)
    - No easy way to disable online-fetched results in lenses (LP: #1054746)
    - Display category emblems on results (LP: #1056901)
    - Descriptions are missing all html tags (LP: #1058197)

  [ Didier Roche ]
  * debian/control:
    - bump libunity build-dep
 -- Didier Roche <email address hidden> Thu, 04 Oct 2012 16:46:32 +0200