& gets replaced with & on clicking save button

Bug #1051932 reported by Stefan Hammer
24
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Tomdroid
Fix Released
Medium
Michal Cerman
Beta
Fix Released
Medium
Michal Cerman

Bug Description

Steps to reproduce:

*) make new note
*) write &
*) click save -> & gets replaced with &
*) click save again -> & gets replaced with &

-> no need to replace & !

Tags: parsing edit

Related branches

description: updated
Changed in tomdroid:
milestone: 0.7.2 → 0.7.3
Revision history for this message
Stefan Hammer (j-4-deactivatedaccount) wrote :

HI Michal,

Thanks for you efforts to fix this problem!
Just one thing went a little bit wrong. The fix is not committed to the master branch yet. It is lying in your private branch. As you can't merge it to the master yourself, you must click the button "Propose for merging" on the summary page of your branch (https://code.launchpad.net/~micer/tomdroid/tomdroid)
Then please fill out all the necessary fields, and submit the form. Afterwards, a Tomdroid Maintainer will review your code and will change the status of the bug to Fix Committed (then it is really committed!).

Otherwise, well done, you successfully participated in an open source project!
(I haven't tested the patch yet - but I am quite sure you did already!)

Thanks a lot,
Stefan :-)

Revision history for this message
Michal Cerman (micer) wrote : Re: [Bug 1051932] Re: & gets replaced with & amp; on clicking save button

Hi Stefan!

thanks a lot for explaining me how to commit the patch here. I thought the
commit is automatically "proposed for merging" and since I was allowed by
system to change the bug status I did so. :-) As you assumed I've already
tested the patch and it works fine.

Regards,
Michal

On Mon, Mar 4, 2013 at 11:43 AM, Stefan Hammer
<email address hidden>wrote:

> HI Michal,
>
> Thanks for you efforts to fix this problem!
> Just one thing went a little bit wrong. The fix is not committed to the
> master branch yet. It is lying in your private branch. As you can't merge
> it to the master yourself, you must click the button "Propose for merging"
> on the summary page of your branch (
> https://code.launchpad.net/~micer/tomdroid/tomdroid)
> Then please fill out all the necessary fields, and submit the form.
> Afterwards, a Tomdroid Maintainer will review your code and will change the
> status of the bug to Fix Committed (then it is really committed!).
>
> Otherwise, well done, you successfully participated in an open source
> project!
> (I haven't tested the patch yet - but I am quite sure you did already!)
>
> Thanks a lot,
> Stefan :-)
>
> ** Changed in: tomdroid/beta
> Status: Fix Committed => Triaged
>
> ** Branch linked: lp:~micer/tomdroid/tomdroid
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1051932
>
> Title:
> &amp; gets replaced with &amp;amp; on clicking save button
>
> Status in Tomdroid - Tomboy note-taking on Android:
> Triaged
> Status in Tomdroid beta series:
> Triaged
>
> Bug description:
> Steps to reproduce:
>
> *) make new note
> *) write &
> *) click save -> & gets replaced with &amp;
> *) click save again -> &amp; gets replaced with &amp;amp;
>
> -> no need to replace &amp; !
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/tomdroid/+bug/1051932/+subscriptions
>

Revision history for this message
Stefan Hammer (j-4-deactivatedaccount) wrote :

Fix merged! I added a finish(), to exit the editing mode. This is done by all the other andorid apps too - klicking save and discard should both close the editing mode.

Changed in tomdroid:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.