Use .linked style class for ModeButton widget
Bug #1051779 reported by
Victor Martinez
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Granite |
Fix Released
|
Low
|
Victor Martinez | ||
| elementary Stylesheet |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Instead of using a hardcoded stylesheet for the mode button, we should simply use the ".linked" style class. This has several advantages:
1) Granite would no longer depend on Unico
2) Less code (the hardcoded stylesheet would be removed)
3) Improved compatibility with other themes, like Adwaita. Unico and Clearlooks don't play well together. Using the linked class makes the mode button look nice even under other themes.
Related branches
lp:~danrabbit/egtk/linked-buttons
- Danielle Foré: Approve
-
Diff: 75 lines (+60/-5)1 file modifiedgtk-3.0/gtk-widgets.css (+60/-5)
lp:~victored/granite/linked-mode-button
- Rico Tzschichholz: Approve
- Victor Martinez (community): Abstain
-
Diff: 266 lines (+80/-98)1 file modifiedlib/Widgets/ModeButton.vala (+80/-98)
Revision history for this message
| Danielle Foré (danrabbit) wrote | #1 |
| Changed in egtk: | |
| status: | New → In Progress |
| Changed in granite: | |
| status: | New → Confirmed |
| Changed in granite: | |
| status: | Confirmed → In Progress |
| importance: | Undecided → Low |
| assignee: | nobody → Victor Eduardo (victored) |
| milestone: | none → luna-beta1 |
| Changed in egtk: | |
| status: | In Progress → Fix Committed |
| milestone: | none → 3.2 |
| Changed in granite: | |
| status: | In Progress → Fix Committed |
| Changed in egtk: | |
| status: | Fix Committed → Fix Released |
| Changed in granite: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hey Victor, if this is something you're interested in doing for this release of granite, can you mark the milestone as so and I'll bump up the priority of getting the .linked style into egtk :)