[gDEBugger] glXBindFramebufferEXT called 4 times per frame with blit buffers branch
Bug #1051287 reported by
Sam Spilsbury
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Compiz |
Invalid
|
Low
|
Sam Spilsbury | ||
Bug Description
Using the branch to enable glBlitFramebuffer, we bind the read framebuffer to the framebuffer and then to the backbuffer each frame. This is probably not necessary - we can get away with doing it once. This makes up 3.5% of openGL calls
Related branches
lp:~compiz-team/compiz/compiz.fix_1040478
- MC Return: Pending requested
- Daniel van Vugt: Pending requested
- Sam Spilsbury: Pending requested
- jenkins: Pending (continuous-integration) requested
- PS Jenkins bot: Pending (continuous-integration) requested
-
Diff: 2332 lines (+1389/-307) (has conflicts)16 files modifieddebian/patches/100_workaround_virtualbox_hang.patch (+53/-6)
plugins/opengl/CMakeLists.txt (+6/-0)
plugins/opengl/include/opengl/framebufferobject.h (+182/-41)
plugins/opengl/include/opengl/opengl-api.h (+42/-0)
plugins/opengl/include/opengl/opengl.h (+82/-22)
plugins/opengl/src/fbdirectdraw/CMakeLists.txt (+32/-0)
plugins/opengl/src/fbdirectdraw/include/framebuffer-direct-draw.h (+111/-0)
plugins/opengl/src/fbdirectdraw/src/framebuffer-direct-draw.cpp (+177/-0)
plugins/opengl/src/fbdirectdraw/tests/CMakeLists.txt (+24/-0)
plugins/opengl/src/fbdirectdraw/tests/test-opengl-framebuffer-direct-draw.cpp (+237/-0)
plugins/opengl/src/framebufferobject.cpp (+112/-104)
plugins/opengl/src/paint.cpp (+10/-80)
plugins/opengl/src/privates.h (+49/-7)
plugins/opengl/src/screen.cpp (+251/-34)
plugins/water/src/water.cpp (+17/-9)
plugins/water/src/water.h (+4/-4)
- Daniel van Vugt: Needs Resubmitting
- MC Return: Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Sam Spilsbury: Pending requested
- jenkins: Pending (continuous-integration) requested
-
Diff: 2312 lines (+1361/-326)16 files modifieddebian/patches/100_workaround_virtualbox_hang.patch (+25/-25)
plugins/opengl/CMakeLists.txt (+6/-0)
plugins/opengl/include/opengl/framebufferobject.h (+182/-41)
plugins/opengl/include/opengl/opengl-api.h (+42/-0)
plugins/opengl/include/opengl/opengl.h (+82/-22)
plugins/opengl/src/fbdirectdraw/CMakeLists.txt (+32/-0)
plugins/opengl/src/fbdirectdraw/include/framebuffer-direct-draw.h (+111/-0)
plugins/opengl/src/fbdirectdraw/src/framebuffer-direct-draw.cpp (+177/-0)
plugins/opengl/src/fbdirectdraw/tests/CMakeLists.txt (+24/-0)
plugins/opengl/src/fbdirectdraw/tests/test-opengl-framebuffer-direct-draw.cpp (+237/-0)
plugins/opengl/src/framebufferobject.cpp (+112/-104)
plugins/opengl/src/paint.cpp (+10/-80)
plugins/opengl/src/privates.h (+49/-7)
plugins/opengl/src/screen.cpp (+251/-34)
plugins/water/src/water.cpp (+17/-9)
plugins/water/src/water.h (+4/-4)
lp:~compiz-team/compiz/compiz.fix_1040478.1
- PS Jenkins bot (community): Approve (continuous-integration)
- MC Return: Pending requested
- Sam Spilsbury: Pending requested
- Daniel van Vugt: Pending requested
- jenkins: Pending (continuous-integration) requested
-
Diff: 2316 lines (+1368/-324)17 files modified.bzrignore (+1/-0)
debian/patches/100_workaround_virtualbox_hang.patch (+31/-23)
plugins/opengl/CMakeLists.txt (+6/-0)
plugins/opengl/include/opengl/framebufferobject.h (+182/-41)
plugins/opengl/include/opengl/opengl-api.h (+42/-0)
plugins/opengl/include/opengl/opengl.h (+82/-22)
plugins/opengl/src/fbdirectdraw/CMakeLists.txt (+32/-0)
plugins/opengl/src/fbdirectdraw/include/framebuffer-direct-draw.h (+111/-0)
plugins/opengl/src/fbdirectdraw/src/framebuffer-direct-draw.cpp (+177/-0)
plugins/opengl/src/fbdirectdraw/tests/CMakeLists.txt (+24/-0)
plugins/opengl/src/fbdirectdraw/tests/test-opengl-framebuffer-direct-draw.cpp (+237/-0)
plugins/opengl/src/framebufferobject.cpp (+112/-104)
plugins/opengl/src/paint.cpp (+10/-80)
plugins/opengl/src/privates.h (+49/-7)
plugins/opengl/src/screen.cpp (+251/-34)
plugins/water/src/water.cpp (+17/-9)
plugins/water/src/water.h (+4/-4)
| description: | updated |
| tags: | added: gdebugger performance |
| Changed in compiz: | |
| milestone: | none → 0.9.8.4 |
| Changed in compiz: | |
| milestone: | 0.9.8.4 → 0.9.9.0 |
| Changed in compiz: | |
| assignee: | nobody → Sam Spilsbury (smspillaz) |
| importance: | Undecided → Low |
| status: | New → In Progress |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #1 |
| Changed in compiz: | |
| milestone: | 0.9.9.0 → none |
| status: | In Progress → Invalid |
| Changed in compiz: | |
| milestone: | none → 0.9.10.0 |
| milestone: | 0.9.10.0 → none |
To post a comment you must log in.
It may be a valid bug for the "blit buffers branch". But not valid for the compiz project (lp:compiz branch).