Geis

Geisv1 gesture class IDs are wrong

Bug #1047596 reported by Chase Douglas
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Geis
Status tracked in Trunk
2.2.9
Fix Released
High
Chase Douglas
Geis 2.2.9.2
Trunk
Fix Released
High
Chase Douglas
geis (Ubuntu)
Fix Released
Medium
Francis Ginther
Precise
Fix Released
High
Chase Douglas

Bug Description

[Impact]
The Geisv1 gesture IDs were changed when the old grail architecture was removed, since the IDs were based on grail v2 constants. Unfortunately, the gesture IDs are part of the GEIS v1 ABI. The change caused all geisv1 clients to fail to work.

[Test Case]
Log into the Unity desktop and attempt any Unity gesture, such as three fingers to move a window around. If it works, then this bug is fixed.

[Regression Potential]
Small. The fix will actually help the code and the public headers stay in sync going forward. There is very little chance for a regression if the issue is fixed.

See original description

Related branches

lp:geis
lp:~chasedouglas/geis/fix-geisv1-class-ids
Stephen M. Webb (community): Approve
Chase Douglas (community): Approve
Diff: 31 lines (+5/-5)
1 file modified
libgeis/backend/grail/geis_grail_backend.c (+5/-5)
lp:geis/2.2.9
lp:geis/precise
lp:ubuntu/precise-proposed/geis
lp:geis/ubuntu
lp:ubuntu/quantal/geis
Chase Douglas (chasedouglas)
Changed in geis (Ubuntu):
importance: Undecided → Medium
Changed in geis (Ubuntu Precise):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Chase Douglas (chasedouglas)
Chase Douglas (chasedouglas)
description: updated
Changed in geis (Ubuntu):
assignee: nobody → Francis Ginther (fginther)
status: New → In Progress
Chase Douglas (chasedouglas)
Changed in geis (Ubuntu Precise):
status: In Progress → Fix Committed
Revision history for this message
Adam Conrad (adconrad) wrote : Please test proposed package

Hello Chase, or anyone else affected,

Accepted geis into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/geis/2.2.9.2-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package geis - 2.2.12-0ubuntu2

---------------
geis (2.2.12-0ubuntu2) quantal; urgency=low

  * Fix Geisv1 gesture class IDs (LP: #1047596)
    - added 001-fix-geisv1-class-ids.patch
 -- Francis Ginther <email address hidden> Fri, 07 Sep 2012 16:28:39 -0500

Changed in geis (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Gestures in unity (which is geisv1 client) are working with libgeis 2.2.9.2-0ubuntu1 from precise-proposed installed.

Therefore marking as verified.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package geis - 2.2.9.2-0ubuntu1

---------------
geis (2.2.9.2-0ubuntu1) precise-proposed; urgency=low

  * New upstream release. Only change is the following bug fix:
    - Fixes regression that caused GEISv1 clients, such as Unity, to not work
      (LP: #1047596)

geis (2.2.9.1-0ubuntu1) precise-proposed; urgency=low

  * Update debian/watch file for new project name
  * New upstream release.
    - removes XCB back end
    - removes overlapping events when a gesture is accepted (lp: #1001365)
    - fix for excessive timeout on backend init failure (lp: #997630)
    - detect added devices properly (LP: #1009270)
    - fix crash when accepting a gesture (LP: #1015775)
    - fix result value of geis_subscription_deactivate() (LP: #1021448)
    - upstream project renamed to just 'geis'
  * Update packaging for project rename (LP: #1037621)
    - Added Conflicts and Replaces clauses for libgeis-dev, libgeis-doc,
      python-geis and geis-tools
  * Remove patches that have been integrated into upstream
    - remove lp813819-typedef-geis-subscription-flags.patch
    - remove lp985986-fix-touch-delta-calculation.patch
    - remove lp986215-calculate-pinch-delta-as-ratio.patch
    - remove lp987539-add-device-axis-attributes.patch
    - remove lp997630-avoid-starting-dbus-session-on-remote-connection.patch
    - remove fix-touch-coordinate-space.patch (patch for lp984069)
 -- Chase Douglas <email address hidden> Fri, 07 Sep 2012 14:11:40 -0700

Changed in geis (Ubuntu Precise):
status: Fix Committed → Fix Released
Revision history for this message
Adam Conrad (adconrad) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.