RFS: kde-gtk-config/2.1-1ubuntu1

In new upstream release only translations files were updated and one tiny patch
from debian package was accepted. (See debdiff output)

Hi Tehnick

Thanks for taking the time to request this sync.

The version currently in Ubuntu carries some Ubuntu specific changes which are not represented in the version that you have requested to be synced from Debian.

This package needs merging rather than syncing in order to preserve these changes.

Un-subscribing ubuntu-sponsors for the time being.

If you would like to prepare the merge feel free and re-subscribe ubuntu-sponsors when you have something for review.

Thanks!

Hi Jonathan,

Could you explain why did you decide to disable this functionality [1]?

Best regards,
Boris

[1] https://launchpadlibrarian.net/112326671/kde-gtk-config_3%3A2.0-3_3%3A2.0-3ubuntu1.diff.gz

I do not agree with these changes. But I prepared updated package [1] and you can sponsor it.
  https://github.com/tehnick/kde-gtk-config-debian/tree/ubuntu
  https://github.com/downloads/tehnick/kde-gtk-config-debian/kde-gtk-config_2.1.orig.tar.bz2
  https://github.com/downloads/tehnick/kde-gtk-config-debian/kde-gtk-config_2.1-1ubuntu1.debian.tar.bz2
  https://github.com/downloads/tehnick/kde-gtk-config-debian/kde-gtk-config_2.1-1ubuntu1.dsc

Nevertheless I still need good explanation...

Great! dget works here:
dget -x https://github.com/downloads/tehnick/kde-gtk-config-debian/kde-gtk-config_2.1-1ubuntu1.dsc

This needs a merge instead of a sync, or a confirmation from Jonathan that the Ubuntu changes are obsolete. Unsubscribing sponsors as there is nothing to sponsor here right now.

Package kde-gtk-config_2.1-1ubuntu1 from links above includes the same Ubuntu-specific patch but formatted in good manner. And all changes are present in Git repo of the package.

Two weeks passed without reply from Jonathan. And release will be soon. Could anyone check and upload updated package? Current package in Ubuntu archive has RC bug, which was fixed in Debian.

dget -x
https://github.com/downloads/tehnick/kde-gtk-config-debian/kde-gtk-config_2.1-1ubuntu1.dsc

The dependency on gtk 2 and 3 was removed to prevent it pulling in those libraries onto the Kubuntu CD. It removes the preview feature but means we can ship it by default.
I'll take a look at this after beta 2

I can split Gtk+ binaries into separate package which will be added in recommendations of primary package. Also I can prepare simple patch for checking if these binaries exist.

In this case you may use unmodified package from Debian. Do you agree with such changes?

Of course I am speaking about future uploads, but not about current one.

There is new bug report confirming the need to update:
https://bugs.launchpad.net/ubuntu/+source/kde-gtk-config/+bug/1058464

Hi,

According to release schedule [1] the final freeze will be tomorrow.
Could you upload updated package while it is possible?

If you have not looked on the RC bug yet, I can describe it here in few words.

Without patch [2] module kde-gtk-config scans ./ directory if option
gtk-icon-theme-name or option gtk-fallback-icon-theme is empty or invalid.
For example, if file ~/.gtkrc-2.0-kde4 does no exist (at first launch).

In this case when user launches SystemSettings, its window will be freezed and
completely unusable until program will not finish recursive scanning of ${HOME}
directory. If this directory has lots of subdirectories such scan takes really
long time.

So I believe that package should be updated before release or deleted from
Ubuntu Quantal.

Best regards,
Boris

[1] https://wiki.ubuntu.com/QuantalQuetzal/ReleaseSchedule
[2] https://github.com/tehnick/kde-gtk-config-debian/blob/ubuntu/debian/patches/fix-loading-icons

This bug was fixed in the package kde-gtk-config - 3:2.1-1ubuntu1

---------------
kde-gtk-config (3:2.1-1ubuntu1) quantal; urgency=low

  * Merge with Debian for bugfix release LP: #1047387
    remaining changes:
   - Remove build dependency on libgtk2.0-dev and libgtk-3-dev.
   - Add patch debian/patches/kubuntu_01_no_gtk.diff
  * Fixes ability to scan for gtk settings LP: #1058464

kde-gtk-config (3:2.1-1) unstable; urgency=low

  * Update to stable release 2.1.
  * Deleted file debian/patches/fix-build-on-kfreebsd-and-hurd-i386:
    accepted in upstream.
  * Added file debian/patches/fix-loading-icons:
    without this patch KDE-GTK-Config module scans ./ directory if option
    gtk-icon-theme-name or option gtk-fallback-icon-theme is empty or invalid,
    now first element from the list of found icon themes is used.
    (Closes: #678714)
 -- Boris Pek <email address hidden> Fri, 07 Sep 2012 22:01:43 +0300

Uploaded, sorry for the delay and thanks for continuing to poke me. Yes having the gtk binaries separate and detected at runtime would be a nice workaround.

Someone forgot to subscribe ~kubuntu-bugs to the package when adding it to the seed, hence the unrepsonsiveness :P