do not fall back on PIRQ tables on systems where SMBIOS 2.6 is not implemented

Bug #1046480 reported by Jared Dominguez
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
biosdevname (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

With the default PROGRAM= line in biosdevname.rules.in, for systems with no SMBIOS 2.6 implemented, biosdevname might not find the type 41 tables and might fall back on PIRQ tables. PIRQ tables might be buggy and cause incorrect names.

The PROGRAM= line is modified in RHEL's and SLES' rules file to have the --smbios 2.6 and –nopirq checks:
PROGRAM="/sbin/biosdevname --smbios 2.6 --nopirq --policy physical -i %k", NAME="%c", OPTIONS+="string_escape=replace"

The upstream rules file does not contain the above check and looks like this:
PROGRAM="/sbin/biosdevname --policy physical -i %k", NAME="%c", OPTIONS+="string_escape=replace"

The attached quilt patch fixes this.

Tags: patch
Revision history for this message
Jared Dominguez (jared-dominguez) wrote :
Revision history for this message
Jared Dominguez (jared-dominguez) wrote :

I forgot to mention. This patch is for biosdevname 0.4.1. I did not check for previous biosdevname versions.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "do not fall back on PIRQ tables on systems where SMBIOS 2.6 is not implemented to ensure that the correct biosdevname names are used" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Kent Baxley (kentb)
Changed in biosdevname (Ubuntu):
status: New → Confirmed
Revision history for this message
Colin Watson (cjwatson) wrote :

Thanks!

Changed in biosdevname (Ubuntu):
importance: Undecided → Medium
status: Confirmed → Triaged
status: Triaged → Fix Committed
Revision history for this message
Jared Dominguez (jared-dominguez) wrote :

Thank you, Colin!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package biosdevname - 0.4.1-0ubuntu3

---------------
biosdevname (0.4.1-0ubuntu3) quantal; urgency=low

  [ Daniel Jared Dominguez ]
  * Do not fall back on PIRQ tables on systems where SMBIOS 2.6 is not
    implemented (LP: #1046480).
 -- Colin Watson <email address hidden> Thu, 06 Sep 2012 09:41:51 +0100

Changed in biosdevname (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.