Swapped short description and name for extras.u.c apps

Bug #1045691 reported by David Planella
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Apps Directory
Fix Released
Low
Michael Nelson

Bug Description

This is a follow-up from bug 1010655, as one of the issues pointed out there is still not fixed.

In short, it seems that the web catalog swaps the tagline (short description) and app name for applications coming from extras. Examples:

- https://apps.ubuntu.com/cat/applications/qreator
- https://apps.ubuntu.com/cat/applications/leds/

QA Steps:
 1) Request import_sca_apps and import_app_install_data to be run (or use /tasks/ interface to run them)
 2) Verify the above 2 urls, qreator should have a name "Qreator" and tagline "Create your own QR codes".

Tags: arb

Related branches

Revision history for this message
Michael Nelson (michael.nelson) wrote :

The current description for qreator on the sca api [1] is:
"Create your own QR codes\nQreator enables you to easily create your own QR codes to encode different types of information in an efficient, compact and cool way."

One possibility is that, since the second duplicate of qreator was deleted yesterday (see bug 1015604), there may not have been an import_sca_application run (which would set this app with the imported_from_sca flag, and not allow the info from apt to overwrite).

That said, the packages file [2] also has the correct description:
"""
Description: Create your own QR codes
 Qreator enables you to easily create your own QR codes to encode
 different types of information in an efficient, compact and cool way.
"""
and our code is making the following assumption for imports of app-install data:

{{{
            # USC uses the first line of the summary as the
            # application name and the rest as the comment..
            summary_lines = candidate.summary.split('\n')
            app_name = summary_lines[0]
            app_comment = '\n'.join(summary_lines[1:])
            if not app_comment:
                 app_comment = package.name
}}}

which, based on the above, does not look correct... (or the lucid version of the apt package that we're using on the server to extract the data is not doing what we expect).

[1] http://software-center.ubuntu.com/api/2.0/applications/en/ubuntu/precise/i386/
[2] http://extras.ubuntu.com/ubuntu/dists/precise/main/binary-amd64/Packages.gz

Revision history for this message
Michael Nelson (michael.nelson) wrote :

I've requested an import_sca_apps, but it's still pending after an hour [1].

Note: if the import does fix qreator (as we expect), it doesn't mean this bug is fixed, just that the sca import is doing the correct thing.

Other apps in extras for which sca doesn't include meta-data, will still have the app name and tagline swapped.

[1] https://apps.ubuntu.com/cat/task_status/be0f7892-38d5-41a8-b2e0-6d5325cf0fbb/

Revision history for this message
Michael Nelson (michael.nelson) wrote :

So for the case of an extras package for which there isn't any sca meta data, the (above) code that we have is indeed doing the same thing that USC does.

You can check this by comparing:

 * https://apps.ubuntu.com/cat/applications/ppasc/

with the corresponding page in USC (just search for ppasc).

Both use the tagline in place of the (non-existent) app-name, and place the package name as the tagline. This is because the package details don't contain a multi-line summary:

https://pastebin.canonical.com/73612/

I don't understand how a package could have a multi-line summary, when the summary itself seems to be taken from the first line of the description.

David Planella (dpm)
tags: added: arb
Dave Morley (davmor2)
Changed in ubuntu-webcatalog:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Michael Nelson (michael.nelson) wrote :

In the end, this was really easy to reproduce locally - sorry we didn't check there first. We'd ensure that app-install-data imports didn't overwrite any sca-imported data (via a form), but had not added the same check for data imported from the apt-cache. The linked branch fixes that.

Steps to repro and QA locally: https://pastebin.canonical.com/79569/

description: updated
Changed in ubuntu-webcatalog:
assignee: nobody → Michael Nelson (michael.nelson)
status: Confirmed → Fix Committed
Changed in ubuntu-webcatalog:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.