mark metadata encryption key and sql_connection as secret=True

Bug #1044462 reported by Tom Hancock
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Tom Hancock

Bug Description

cfg items like swift_store_key etc are declared as secret=True and so their values are not recorded when configuration options
are printed out. metadata_encryption_key and sql_connection are also sensitive enough to warrant having the secret=True
annotation.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12270

Changed in glance:
assignee: nobody → Tom Hancock (tom-hancock)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/12270
Committed: http://github.com/openstack/glance/commit/c4f781632069a0554f1595f65dacfc85081dff96
Submitter: Jenkins
Branch: master

commit c4f781632069a0554f1595f65dacfc85081dff96
Author: Tom Hancock <email address hidden>
Date: Fri Aug 31 16:10:45 2012 +0000

    Fix LP bug #1044462 cfg items need secret=True

    Redact sensitive log information such as
    sql_connection
    metadata_encryption_key
    admin_password
    admin_user
    admin_tenant
    when cfg item summaries are printed in logs

    Change-Id: I74cfeae4b8bdbd405fbc4baca763a62f4470b154

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
milestone: none → folsom-rc1
status: Fix Committed → Fix Released
Brian Waldon (bcwaldon)
Changed in glance:
importance: Undecided → Low
Thierry Carrez (ttx)
Changed in glance:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.