Zorba

Assertion failed: (result.first != result.second)

Bug #1044245 reported by William Candillon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zorba
Fix Released
High
Paul J. Lucas

Bug Description

The following query:
declare namespace foo = "http://www.example.com";

declare context item := <foo:foo><foo:bar /></foo:foo>;

{ foo : bar }

Returns:
Assertion failed: (result.first != result.second), function lookup, file /Users/wcandillon/28msec/zorba/sandbox/src/diagnostics/dict.cpp, line 80.
Abort trap: 6

Related branches

lp:~zorba-coders/zorba/bug-1044260
Matthias Brantner: Approve
Markos Zaharioudakis: Approve
Paul J. Lucas: Approve
Diff: 1826 lines (+769/-163)
31 files modified
include/zorba/internal/diagnostic.h (+6/-5)
include/zorba/pregenerated/diagnostic_list.h (+2/-0)
modules/org/jsoniq/www/pregenerated/errors.xq (+8/-0)
src/compiler/translator/translator.cpp (+5/-5)
src/context/static_context.cpp (+1/-1)
src/diagnostics/CMakeLists.txt (+16/-5)
src/diagnostics/diagnostic.h (+31/-5)
src/diagnostics/diagnostic_en.xml (+102/-33)
src/diagnostics/dict.h (+3/-1)
src/diagnostics/dict_zed_keys_h.xq (+55/-0)
src/diagnostics/pregenerated/diagnostic_list.cpp (+3/-0)
src/diagnostics/pregenerated/dict_en.cpp (+45/-37)
src/diagnostics/pregenerated/dict_zed_keys.h (+338/-0)
src/runtime/core/apply_updates.cpp (+35/-19)
src/runtime/core/fncall_iterator.cpp (+1/-1)
src/runtime/core/sequencetypes.cpp (+7/-8)
src/runtime/function_item/dynamic_fncall_iterator.cpp (+3/-3)
src/runtime/json/jsoniq_functions_impl.cpp (+2/-2)
src/runtime/numerics/numerics_impl.cpp (+1/-1)
src/store/naive/node_items.cpp (+2/-1)
src/store/naive/pul_primitives.cpp (+59/-26)
src/store/naive/store.cpp (+1/-1)
src/util/error_util.cpp (+2/-2)
src/util/fs_util.h (+31/-0)
test/rbkt/ExpQueryResults/zorba/index/auctions2u.xml.res (+1/-1)
test/rbkt/ExpQueryResults/zorba/index/undo1.xml.res (+1/-1)
test/rbkt/ExpQueryResults/zorba/jsoniq/obj_constr_06.xml.res (+1/-1)
test/rbkt/ExpQueryResults/zorba/jsoniq/obj_constr_10.xml.res (+1/-1)
test/rbkt/ExpQueryResults/zorba/jsoniq/serializer-JNSE0022.xml.res (+1/-1)
test/rbkt/Queries/zorba/index/auctions2u.xq (+1/-1)
test/rbkt/Queries/zorba/index/undo1.xq (+4/-1)
Revision history for this message
William Candillon (wcandillon) wrote :

Assigned to you for dispatching.

Changed in zorba:
assignee: nobody → Chris Hillery (ceejatec)
Revision history for this message
Chris Hillery (ceejatec) wrote :

This is happening because an entry is missing from diagnostics_en.xml, at least that is my understanding. It is happening a lot with JSONiq features.

The assertion is probably useful, but it doesn't give enough information. We need it to explicitly say "I am crapping out because you used the key "~FooBarBaz" in an error but there is no localized value for that key in diagnostics_en.xml", possibly even with a pointer to the correct file to update and where the missing data should be placed.

Changed in zorba:
assignee: Chris Hillery (ceejatec) → Paul J. Lucas (paul-lucas)
importance: Undecided → High
Revision history for this message
Paul J. Lucas (paul-lucas) wrote :

FYI: I didn't put that assert() there -- Markos did. It comes down to this question: do you want a customer's application to crash with an error message because somebody forgot to put in a dictionary string (and a test for it) or would you rather it simply print the key (as my original code before Markos' change did)?

Paul J. Lucas (paul-lucas)
Changed in zorba:
status: New → In Progress
Paul J. Lucas (paul-lucas)
Changed in zorba:
status: In Progress → Fix Committed
Paul J. Lucas (paul-lucas)
Changed in zorba:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.