Automated tests during build fail regularly (though not always)

Bug #1043956 reported by Mathieu Trudel-Lapierre
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
The Sync Menu
Fix Released
High
Charles Kerr
indicator-sync (Ubuntu)
Fix Released
High
Mathieu Trudel-Lapierre

Bug Description

The tests tend to fail a lot in sbuild when run locally; without dbus-test-runner, they will simply not work usually (failing to bring up a dbus bus), and with dbus-test-runner; they tend to time out at various stages, but most reproducibly in starting the SyncApp service:

task-0: PASS: test-ascii-quotes
task-0: Running main() from gtest_main.cc
task-0: [==========] Running 2 tests from 1 test case.
task-0: [----------] Global test environment set-up.
task-0: [----------] 2 tests from ClientTest
task-0: [ RUN ] ClientTest.TestCanStartService
Activating service name='com.canonical.indicator.sync'
Successfully activated service 'com.canonical.indicator.sync'
task-0: [ OK ] ClientTest.TestCanStartService (112 ms)
task-0: [ RUN ] ClientTest.AppCanStartService

(process:32276): libindicator-CRITICAL **: try_and_get_name_lost_cb: assertion `connection != NULL' failed
Activating service name='com.canonical.indicator.sync'
Successfully activated service 'com.canonical.indicator.sync'

(process:32286): GLib-CRITICAL **: g_key_file_load_from_file: assertion `file != NULL' failed

(process:32286): GLib-GIO-CRITICAL **: g_app_info_get_icon: assertion `G_IS_APP_INFO (appinfo)' failed

(process:32286): GLib-GIO-CRITICAL **: g_icon_to_string: assertion `icon != NULL' failed

(process:32286): GLib-GIO-CRITICAL **: g_dbus_proxy_new: assertion `g_variant_is_object_path (object_path)' failed
task-0: test-client.cpp:120: Failure
task-0: Value of: err == NULL
task-0: Actual: false
task-0: Expected: true
task-0: [ FAILED ] ClientTest.AppCanStartService (37 ms)
task-0: [----------] 2 tests from ClientTest (149 ms total)
task-0:
task-0: [----------] Global test environment tear-down
task-0: [==========] 2 tests from 1 test case ran. (149 ms total)
task-0: [ PASSED ] 1 test.
task-0: [ FAILED ] 1 test, listed below:
task-0: [ FAILED ] ClientTest.AppCanStartService
task-0:
task-0: 1 FAILED TEST
task-0: FAIL: test-client
task-0: ===================
task-0: 1 of 4 tests failed
make[4]: task-0: ===================
*** [check-TESTS] Error 1
make[3]: *** [check-am] Error 2
task-0: make[4]: Leaving directory `/«PKGBUILDDIR»/test'
task-0: make[3]: Leaving directory `/«PKGBUILDDIR»/test'
make[2]: *** [check-recursive] Error 1
task-0: make[2]: Leaving directory `/«PKGBUILDDIR»'
dh_auto_test: make -j1 check returned exit code 2
make[1]: *** [override_dh_auto_test] Error 255
make[1]: Leaving directory `/«PKGBUILDDIR»'
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

See also: http://paste.ubuntu.com/1172093/

For now; I'll disable the automated tests since things appear to be working properly when the examples are being run manually: see http://bazaar.launchpad.net/~indicator-applet-developers/indicator-sync/trunk/view/head:/examples/README

Iain Lane (laney)
Changed in indicator-sync (Ubuntu):
milestone: none → ubuntu-12.10-beta-2
Changed in indicator-sync (Ubuntu):
assignee: nobody → Charles Kerr (charlesk)
Iain Lane (laney)
Changed in indicator-sync (Ubuntu):
status: New → Triaged
importance: Undecided → High
Charles Kerr (charlesk)
Changed in indicator-sync:
assignee: nobody → Charles Kerr (charlesk)
status: New → In Progress
importance: Undecided → High
Revision history for this message
Charles Kerr (charlesk) wrote :

I believe this is being caused by some difference in the test system and my development system, as the tests are passing here.

Yesterday Allan and I set up a CI process for running i-sync merge requests through Jenkins to help track this down. That way I can run debugging changes through Jenkins' test setup.

Revision history for this message
Charles Kerr (charlesk) wrote :
Changed in indicator-sync:
status: In Progress → Fix Committed
Charles Kerr (charlesk)
Changed in indicator-sync:
milestone: none → 12.10.2
Charles Kerr (charlesk)
Changed in indicator-sync:
status: Fix Committed → Fix Released
Changed in indicator-sync (Ubuntu):
assignee: Charles Kerr (charlesk) → Mathieu Trudel-Lapierre (mathieu-tl)
status: Triaged → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-sync - 12.10.2-0ubuntu1

---------------
indicator-sync (12.10.2-0ubuntu1) quantal; urgency=low

  * New upstream bugfix release.
    - Fix unit tests.
    - Increase test coverage.
  * debian/rules: re-enable tests which got fixed with this release.
    (LP: #1043956)
  * debian/patches/upstream-watchers-client-test.patch: dropped, included
    upstream.
 -- Mathieu Trudel-Lapierre <email address hidden> Wed, 12 Sep 2012 15:38:42 -0400

Changed in indicator-sync (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.