Ubuntu Apps Directory

duplicate key webcatalog_nonce_nonce_key

Bug #1040523 reported by Michael Nelson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Apps Directory
Fix Released
Medium
Michael Nelson

Bug Description

We're currently seeing over 4k oopses recorded for uwc each day, 3.9k of which are duplicate key for webcatalog_nonce_nonce_key [1][2]

[1] Stats https://pastebin.canonical.com/72872/
[2] Traceback https://pastebin.canonical.com/72873/

Related branches

lp:~michael.nelson/ubuntu-webcatalog/1040523-oops-creating-nonce
Anthony Lenton (community): Approve
Diff: 305 lines (+248/-4)
5 files modified
src/webcatalog/migrations/0028_nonce_unique_together.py (+174/-0)
src/webcatalog/models/oauthtoken.py (+2/-1)
src/webcatalog/tests/__init__.py (+1/-0)
src/webcatalog/tests/factory.py (+6/-3)
src/webcatalog/tests/test_models_oauth.py (+65/-0)
Revision history for this message
Michael Nelson (michael.nelson) wrote :

Based on the DataStore.lookup_nonce() method, and it's call-site in oauth.OAuthServer._check_nonce(), it looks as though lookup_nonce() is responsible should "Verify that the nonce is uniqueish.". I assume that means unique for the consumer/token keys, yet the database constraint is a simple unique constraint on webcatalog.Nonce.nonce.

I'll prepare branch that relaxes this to unique for consumer/token - if that's not correct, let me know.

ISD Branch Mangler (isd-branches-mangler)
Changed in ubuntu-webcatalog:
status: Confirmed → Fix Committed
Michael Nelson (michael.nelson)
Changed in ubuntu-webcatalog:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.