Pollutes main window JS scope
Bug #1037706 reported by
Chris Coulson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Online Accounts: Browser Extensions |
Fix Released
|
High
|
Alberto Mardegan | ||
| webaccounts-browser-extension (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Bug Description
The Firefox addon adds these symbols to the main window JS scope:
cookieManager
collectCookies
observerService
These aren't very unique names and its surprising that they don't already collide with something inside Firefox. But, it's quite likely they will collide with another addon, causing strange bugs. Ideally, addons shouldn't add any symbols to the global scope (and this one really doesn't need to), but if they do, they should be properly namespaced
Related branches
lp:~chrisccoulson/webaccounts-browser-extension/lp1037706
- Alberto Mardegan (community): Approve
-
Diff: 70 lines (+33/-22)1 file modifiedfirefox-extension/content/browser.js (+33/-22)
| Changed in webaccounts-browser-extension (Ubuntu): | |
| importance: | Undecided → High |
| status: | New → Triaged |
| Changed in online-accounts-browser-extension: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| assignee: | nobody → Alberto Mardegan (mardy) |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in webaccounts-browser-extension (Ubuntu): | |
| status: | Triaged → Fix Released |
| Changed in online-accounts-browser-extension: | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
This bug was fixed in the package webaccounts-
---------------
webaccounts-
* New upstream release.
- Don't add any symbols to the main window global scope (LP: #1037706)
- Don't leak the browser chrome window (LP: #1037707)
- Don't import XPCOMUtils.jsm, it's not used anywhere
- Get the cookiemanager from Services.jsm
- Updated names and descriptions to be consistent between firefox and
chromium extensions (LP: #1025462)
-- Ken VanDine <email address hidden> Fri, 17 Aug 2012 16:40:48 -0400