[SRU] Fix lsb-core for 12.10 and 13.04

As logmein-hamachi isn't provided by an Ubuntu package I don't believe we can do anything about this as it looks like install_initd is crashing trying to parse the /etc/init.d/logmein-hamachi file.

Status changed to 'Confirmed' because the bug affects multiple users.

same issue affecting eset nod32 installation

The problem is, well, /usr/lib/lsb/initdutils.py is a Python 2 script.

Can we make that file use `except .. as ..` syntax? (That would be compatible with both Python 2 & 3)

Actually all the files under /usr/lib/lsb are in Python2...
"#! /usr/bin/python3" is just wrong.

@mitya57
The synatx difference is far beyond the difference of "except" I guess. You may run 2to3 to see the changeset required.

BTW, "assert True" non-sense at the beginning of initdutils.py will be rejected by Python 3.

I guess this is what was fixed in saucy:

lsb (4.1+Debian10) unstable; urgency=low

  [ Steve Langasek ]
  * Fix the remaining problems of initdutils.py python3 compatibility
    (Closes: #673586)
  * Revert unnecessary use of /bin/echo -n (Closes: #708337)

  [ Didier Raboud ]
  * Compress source with xz

 -- Didier Raboud <email address hidden> Wed, 15 May 2013 11:06:44 +0200

So we'd just need backports of the appropriate changes to initdutils.py.

No, Colin. Debian's fix is irrelevant here.

If it is about this diff:
http://anonscm.debian.org/gitweb/?p=collab-maint/lsb.git;a=commitdiff;h=f4ed7f08600d633c3daba9f494997f1c35555aed;hp=b459407133b43ce0bcb2231eff1408fe9f0b41b7

What it does is that it makes initdutils.py , still a Python 2 script, compatible with Python 3 (hopefully).

But in, Ubuntu saucy, Python 2 script install_initd, lsbinstall and remove_initd had their shebang (#!) changed to "/usr/bin/python3" by something in debian/rules, so it is still broken.

Hardly irrelevant. Those scripts also have 2to3 run over them, so that's OK.

There is a remaining incompatibility in initdutils.py, for which I've just uploaded a fix. After that, /usr/lib/lsb/install_initd seems to work fine in a saucy chroot.

lsb (4.1+Debian11ubuntu3) saucy; urgency=low

  * Use open() rather than file() in initdutils.py, for Python 3
    compatibility (see LP #1035136).
  * Test fileob and strob against None in RFC822Parser.__init__ rather than
    testing their truth value, to avoid a misleading error in the case of a
    file with no LSB headers.

 -- Colin Watson <email address hidden> Mon, 01 Jul 2013 12:36:13 +0100

Subscribed ubuntu-sru, please test and give feedback

lsb (4.1+Debian11ubuntu3) saucy; urgency=low

  * Use open() rather than file() in initdutils.py, for Python 3
    compatibility (see LP #1035136).
  * Test fileob and strob against None in RFC822Parser.__init__ rather than
    testing their truth value, to avoid a misleading error in the case of a
    file with no LSB headers.

 -- Colin Watson <email address hidden> Mon, 01 Jul 2013 12:36:13 +0100

Ping?

Uploaded, thank you

Packages are waiting in the unapproved queue for review by Ubuntu SRU team. Unsubscribing ubuntu-sponsors team.

FYI - they are waiting in the SRU queue as there is an unverified SRU of lsb in -proposed already.

Hello Chris, or anyone else affected,

Accepted lsb into raring-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/lsb/4.0-0ubuntu27.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Chris, or anyone else affected,

Accepted lsb into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/lsb/4.0-0ubuntu26.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello

I don't think this issue was completely fixed. I see this error when I run install_initd with lsb version 4.0-0ubuntu27.2

Traceback (most recent call last):
  File "/usr/lib/lsb/install_initd", line 102, in <module>
    initdutils.save_depends(depends)
  File "/usr/lib/lsb/initdutils.py", line 138, in save_depends
    fh = file(DEPENDS, 'w')
NameError: global name 'file' is not defined

There still exists some references to 'file' in initdutils.py

$ grep -n file\( initdutils.py
54:def scan_initfile(initfile):
99: fh = file(FACILITIES, 'w')
125: independs = RFC822Parser(fileob=file(DEPENDS))
138: fh = file(DEPENDS, 'w')
171: print(scan_initfile('init-fragment'))

Thanks.

Thanks Petteri S, that is correct and I've marked the bug as verification-failed.

I'll upload new fixes for Raring and Quantal.

Hello Chris, or anyone else affected,

Accepted lsb into raring-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/lsb/4.0-0ubuntu27.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Hello Chris, or anyone else affected,

Accepted lsb into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/lsb/4.0-0ubuntu26.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Thanks everybody, this latest update has fixed any issues we were experiencing with the lsb install_initd and remove_initd scripts.

@Petteri - were you testing this on Raring again?

Yes this is Ubuntu 13.04. For more details I've attached the output from "ubuntu-bug lsb-core".

This bug was fixed in the package lsb - 4.0-0ubuntu27.3

---------------
lsb (4.0-0ubuntu27.3) raring-proposed; urgency=low

  * initdutils.py: Fully fix issues with Python 3. (LP: #1035136)
 -- Brian Murray <email address hidden> Thu, 22 Aug 2013 15:10:16 -0700

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

quantal has seen the end of its life and is no longer receiving any updates. Marking the quantal task for this ticket as "Won't Fix".