GTG

Mouseover String Incorrect

Bug #1033268 reported by Meg Ford
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GTG
Fix Released
Low
Sushant Raikar

Bug Description

Steps to reproduce:
1. Select task in taskview
2. Click "Mark as done" icon
3. Mouseover "Mark as done" icon

expected result: mouseover text should have changed from "Mark the selected task as done" to "Mark the selected task as not done" (for example).

actual result: mouseover text remains unchanged.

Tags: love
Izidor Matušov (izidor)
Changed in gtg:
status: New → Confirmed
milestone: none → 0.3
importance: Undecided → Low
tags: added: love
Revision history for this message
Abhiram (abhiram-ampabathina) wrote :

I would like to try this one. Can you guys give me a kick start?

Best,
Abhiram

Revision history for this message
Izidor Matušov (izidor) wrote :

Abhiram> The relevant code is in GTG/gtk/browser/browser.py in method on_taskdone_cursor_changed
The problem is that the tooltip is not updated. It should be very easy to fix it.

Changed in gtg:
assignee: nobody → Abhiram (abhiram-ampabathina)
Revision history for this message
Abhiram (abhiram-ampabathina) wrote :

Izidor> yes. I see that. I understand it. I am working on that.

Changed in gtg:
status: Confirmed → In Progress
Revision history for this message
Abhiram (abhiram-ampabathina) wrote :

Hello guys,
                 Have a look at the linked branch. This might have solved the problem.

Best

Revision history for this message
Abhiram (abhiram-ampabathina) wrote :

Hello,
              I have made the tooltip of dismissed button as "mark the seleted task as not done". I thought that is what all the bug about, to change the dismissed button tooltip. If anything other mention it here. I will incorporate them too.

Best,
Abhiram

Revision history for this message
Meg Ford (meg387) wrote :

Hi,
your patch basically fixes the bug, but I think you could improve it slightly. I'm attaching screenshots with the incorrect string, your corrected string, and also a place where the "mark selected task as done" string appears where imo it shouldn't. can you remove the string when there is no task selected? I don't think it makes sense to show it then.

Revision history for this message
Meg Ford (meg387) wrote :

Corrected string

Revision history for this message
Meg Ford (meg387) wrote :

This shows the same string appearing when imo it shouldn't.

Revision history for this message
Abhiram (abhiram-ampabathina) wrote :

Hello Meg,
           Apologies for late relpy(attended a 48 hr yahoo hackathon). I understand your screebshot. It is the same in my branch too. I will soon find a way to get this done. By the by , i have just asked you to understand the patch that i have provided , so that, i know that the bug is fixed well. I did not ask you to review it.

Best,
Abhiram

Revision history for this message
Meg Ford (meg387) wrote :

Hi Abhiram,

That's fine, Izidor explained that he asked you to clarify what I was asking for. I haven't used gtg's dev branch in a while, so I was concerned that it would take me a long time to get it set up, but it was fine. Hope you had a good hackathon.

Meg

Izidor Matušov (izidor)
Changed in gtg:
milestone: 0.3 → 0.4
Revision history for this message
Abhiram (abhiram-ampabathina) wrote :

Hi Meg,
             I have made changes to implement that alsoneedsfixing.png . Check out my code for that. It works for me fine.

bzr branch lp:~abhiram-ampabathina/gtg/gtg2 .

Branch it out and have a look at it when you are free.

Best,
Abhiram

Revision history for this message
Izidor Matušov (izidor) wrote :

While I was reviewing Abhiram's patch, I asked myself: Do the tooltips be so complicated and formally written? "Mark this task as not done", etc. Wouldn't it be better to use more causal style, e.g. "You've completed the selected task.", "You don't want to work on this task", "You are going to work on this task".

Meg> What is your opition?

Revision history for this message
Meg Ford (meg387) wrote :

Yeah, I completely agree that it sounds too formal. In gnome the style focuses on the action rather than on directly addressing the user, so rather than saying *you are doing x to this task* you would say *mark as done*. The idea here is that the button just needs to communicate it's function -- the user already knows that s/he is performing the task (not anyone else), and the context should communicate what object the user is acting on (the task). I know gtg has it's own style, so maybe this is off-topic, but I thought it was worth mentioning :)

Revision history for this message
Abhiram (abhiram-ampabathina) wrote :

Hello guys,
            So, should i go on and make changes. Make them from formal to informal. Something like, "You've completed the selected task" and so on. What do u guys say?

Best,
Abhiram

Changed in gtg:
milestone: 0.4 → 0.3.1
Revision history for this message
Nimit Shah (nimit-svnit) wrote :

Hi all,
   my 2 cents on the discussion of words to be used:
   "Mark as Done" sounds formal but I would actually prefer that over "You've completed the task". "You've completed the task" makes me feel like a child. (Sorry for the crude comparison!) Astrid has informal strings and I sometimes hate it when it says "C'mon you can do this" or "I'm so proud of you"
   IMO, the current "Mark as Done" is a formal but better string.

Changed in gtg:
milestone: 0.3.1 → 0.4
Nimit Shah (nimit-svnit)
Changed in gtg:
status: In Progress → Confirmed
assignee: Abhiram (abhiram-ampabathina) → nobody
Revision history for this message
Parin Porecha (parinporecha) wrote :

Nimit > any ideas/suggestions what should we do regarding this ?

Revision history for this message
Nimit Shah (nimit-svnit) wrote :

Hi Parin,
I feel we should stick to "Mark as Done" and "Mark as not done"

Revision history for this message
Anna (annaphilips) wrote :

Can I have a go at this?

Anna (annaphilips)
Changed in gtg:
assignee: nobody → Anna (an.na)
Anna (annaphilips)
Changed in gtg:
assignee: Anna (an.na) → nobody
Revision history for this message
Parin Porecha (parinporecha) wrote :

Hi Anna,

there are critical and high priority bugs you can work on if you want to contribute to GTG.
This is targeted for 0.4 release, so it's not that important right now.

Please have a look at -
https://bugs.launchpad.net/gtg/+bug/1277402
https://bugs.launchpad.net/gtg/+bug/1277184

Try to reproduce them on your computer, and if you're able to, then you can work on patching them :-)

Changed in gtg:
assignee: nobody → Sushant Raikar (sushantthecoder)
Changed in gtg:
assignee: Sushant Raikar (sushantthecoder) → nobody
Changed in gtg:
assignee: nobody → Sushant Raikar (sushantthecoder)
Nimit Shah (nimit-svnit)
Changed in gtg:
status: Confirmed → In Progress
Revision history for this message
Nimit Shah (nimit-svnit) wrote :

Fixed in revision 1355

Changed in gtg:
status: In Progress → Fix Committed
milestone: 0.4 → 0.3.2
Jeff Fortin Tam (kiddo)
Changed in gtg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.