Checkbox

Test purpose area is too small to support two lines of description

Bug #1032255 reported by Sylvain Pineau on 2012-08-02

This bug affects 2 people

	Status	Importance	Assigned to	Milestone
Checkbox	Fix Released	Medium	Sylvain Pineau	Checkbox 0.14.x "Before Q release"
checkbox (Ubuntu)	Fix Released	Undecided	Unassigned
Precise	Fix Released	Undecided	Unassigned

Bug Description

[Impact]
The bottom line of the purpose Qlabel is cropped. For tests with longer "purpose" fields, this makes them difficult or impossible to read.

The fix works by changing the Y size to 31 and bringing it to front.

[Test case]
- Start checkbox-qt from a terminal.
- Right-click on the list of tests, then select "Deselect all".
- Select only the media card tess.
- Click on "Start testing"
- Notice the first test's purpose (which appears below the "Media cards test" and reads "This test will check that the systems media card reader can detect the insertion of a Multimedia Card (MMC) media" is truncated.

[Regression potential]
The fix is just a minor tweak to the .ui file, increasing the label height by 10 pixels. There's enough room in the Checkbox window so no further control relocations are necessary. The bug may reappear if a PURPOSE has 3 lines, but so far we don't have anything that long. Thus the regression potential is very low.

See original description

Tags:

Related branches

lp:~sylvain-pineau/checkbox/bug1032255

Merged into lp:checkbox at revision 1644

Daniel Manrique (community): Approve on 2012-09-05

lp:~roadmr/ubuntu/quantal/checkbox/0.14.7

Merged into lp:ubuntu/quantal/checkbox at revision 52

Ubuntu branches: Pending requested 2012-09-26

Diff: 114866 lines (+22292/-18992)

125 files modified

checkbox_qt/qt_interface.py (+7/-2)
debian/changelog (+51/-0)
debian/po/ast.po (+2/-2)
debian/po/cs.po (+2/-2)
debian/po/de.po (+2/-2)
debian/po/en_AU.po (+2/-2)
debian/po/en_GB.po (+2/-2)
debian/po/es.po (+2/-2)
debian/po/fr.po (+2/-2)
debian/po/he.po (+2/-2)
debian/po/hu.po (+2/-2)
debian/po/id.po (+2/-2)
debian/po/it.po (+2/-2)
debian/po/ja.po (+2/-2)
debian/po/nl.po (+2/-2)
debian/po/oc.po (+2/-2)
debian/po/pl.po (+2/-2)
debian/po/pt_BR.po (+2/-2)
debian/po/ro.po (+2/-2)
debian/po/ru.po (+2/-2)
debian/po/tr.po (+2/-2)
debian/po/uk.po (+2/-2)
debian/po/zh_CN.po (+2/-2)
debian/po/zh_TW.po (+2/-2)
jobs/audio.txt.in (+6/-6)
jobs/networking.txt.in (+4/-1)
jobs/suspend.txt.in (+5/-4)
patches/0.14.2 (+2/-1)
po/ace.po (+199/-198)
po/af.po (+199/-198)
po/am.po (+199/-198)
po/ar.po (+219/-203)
po/ast.po (+199/-198)
po/az.po (+199/-198)
po/be.po (+199/-198)
po/bg.po (+199/-198)
po/bn.po (+199/-198)
po/bo.po (+199/-198)
po/br.po (+199/-198)
po/bs.po (+199/-198)
po/ca.po (+199/-198)
po/ca@valencia.po (+199/-198)
po/ckb.po (+199/-198)
po/cs.po (+199/-198)
po/cy.po (+199/-198)
po/da.po (+199/-198)
po/de.po (+179/-178)
po/dv.po (+199/-198)
po/el.po (+199/-198)
po/en_AU.po (+415/-414)
po/en_CA.po (+199/-198)
po/en_GB.po (+891/-504)
po/eo.po (+202/-201)
po/es.po (+462/-216)
po/et.po (+199/-198)
po/eu.po (+199/-198)
po/fa.po (+199/-198)
po/fi.po (+202/-201)
po/fr.po (+1576/-489)
po/ga.po (+199/-198)
po/gd.po (+199/-198)
po/gl.po (+261/-208)
po/he.po (+199/-198)
po/hi.po (+199/-198)
po/hr.po (+199/-198)
po/hu.po (+199/-198)
po/hy.po (+199/-198)
po/id.po (+199/-198)
po/is.po (+199/-198)
po/it.po (+199/-198)
po/ja.po (+199/-198)
po/jbo.po (+199/-198)
po/ka.po (+199/-198)
po/kk.po (+199/-198)
po/km.po (+199/-198)
po/kn.po (+199/-198)
po/ko.po (+199/-198)
po/ku.po (+199/-198)
po/ky.po (+199/-198)
po/lt.po (+199/-198)
po/lv.po (+199/-198)
po/mk.po (+199/-198)
po/ml.po (+199/-198)
po/mr.po (+199/-198)
po/ms.po (+666/-251)
po/my.po (+199/-198)
po/nb.po (+199/-198)
po/nds.po (+199/-198)
po/ne.po (+199/-198)
po/nl.po (+199/-198)
po/nn.po (+199/-198)
po/oc.po (+204/-199)
po/pl.po (+199/-198)
po/ps.po (+199/-198)
po/pt.po (+266/-257)
po/pt_BR.po (+626/-236)
po/ro.po (+199/-198)
po/ru.po (+629/-222)
po/sd.po (+199/-198)
po/shn.po (+199/-198)
po/si.po (+199/-198)
po/sk.po (+199/-198)
po/sl.po (+288/-225)
po/sq.po (+217/-198)
po/sr.po (+199/-198)
po/sv.po (+199/-198)
po/ta.po (+199/-198)
po/te.po (+199/-198)
po/th.po (+199/-198)
po/tr.po (+204/-203)
po/ug.po (+199/-198)
po/uk.po (+218/-217)
po/ur.po (+199/-198)
po/uz.po (+199/-198)
po/vi.po (+199/-198)
po/zh_CN.po (+199/-198)
po/zh_HK.po (+199/-198)
po/zh_TW.po (+199/-198)
qt/frontend/qtfront.ui (+2/-2)
scripts/audio_settings (+12/-2)
scripts/color_depth_info (+1/-1)
scripts/frequency_governors_test (+5/-2)
scripts/graphics_driver (+4/-4)
scripts/graphics_modes_info (+1/-1)
scripts/network_device_info (+95/-44)

lp:ubuntu/precise-proposed/checkbox

Revision history for this message

Sylvain Pineau (sylvain-pineau) wrote on 2012-08-02:

checkbox.png Edit (55.3 KiB, image/png)

Revision history for this message

Ara Pulido (ara) wrote on 2012-09-03:

Visually this gives a very bad look to Checkbox. I would like to see this fixed for Quantal.

tags:	added: bitesize
Changed in checkbox:
importance:	Undecided → Medium
milestone:	none → 0.14.x
status:	New → Confirmed

Sylvain Pineau (sylvain-pineau) on 2012-09-04

Changed in checkbox:
assignee:	nobody → Sylvain Pineau (sylvain-pineau)

Sylvain Pineau (sylvain-pineau) on 2012-09-04

Changed in checkbox:
status:	Confirmed → In Progress

Sylvain Pineau (sylvain-pineau) on 2012-09-05

Changed in checkbox:
status:	In Progress → Fix Committed

Daniel Manrique (roadmr) on 2012-09-27

description:

updated

Brendan Donegan (brendan-donegan) on 2012-11-01

Changed in checkbox:
status:	Fix Committed → Fix Released

Revision history for this message

Clint Byrum (clint-fewbar) wrote on 2012-11-07: Please test proposed package

Hello Sylvain, or anyone else affected,

Accepted checkbox into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/checkbox/0.13.8 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in checkbox (Ubuntu Precise):
status:	New → Fix Committed
tags:	added: verification-needed

Daniel Manrique (roadmr) on 2012-11-13

Changed in checkbox (Ubuntu):
status:	New → Fix Released

Revision history for this message

Daniel Manrique (roadmr) wrote on 2012-11-19:

This was an easy one to confirm. I ran checkbox 0.13.7, took a screenshot, then upgraded to 0.13.8 and took another screenshot. The difference is clearly visible, I'm attaching my two screenshots for reference. I'll mark as verification-done.

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Daniel Manrique (roadmr) wrote on 2012-11-19:

old (bad) behavior. Edit (57.4 KiB, image/png)

Revision history for this message

Daniel Manrique (roadmr) wrote on 2012-11-19:

new (good, fixed) behavior. Edit (61.4 KiB, image/png)

Revision history for this message

Steve Langasek (vorlon) wrote on 2013-01-18:

Hello Sylvain, or anyone else affected,

Accepted checkbox into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/checkbox/0.13.9 in a few hours, and then in the -proposed repository.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags:	removed: verification-done
tags:	added: verification-needed

Revision history for this message

Daniel Manrique (roadmr) wrote on 2013-01-23:

checkbox-0.13.9.png Edit (58.8 KiB, image/png)

Here's the screenshot I took to verify checkbox 0.13.9, the same as for checkbox 0.13.8.

Marking verification done.

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Adam Conrad (adconrad) wrote on 2013-01-24: Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-01-24:

#10

This bug was fixed in the package checkbox - 0.13.9

---------------
checkbox (0.13.9) precise-proposed; urgency=low

* Updated fix for bug #1026614 which was missing some code.
* Removed bad fix for bug 990133.

checkbox (0.13.8) precise-proposed; urgency=low

* New upstream release (LP: #1061198)

  [Marc Tardif]
  * checkbox/dispatcher.py: Updated license to GPLv3 to be consistent with
    rest of Checkbox files (LP: #1049881)

  [Sylvain Pineau]
  * qt/frontend/qtfront.ui: Fixed the test purpose widget size to allow two
    lines of description (LP: #1032255)
  * scripts/camera_test, jobs/camera.txt.in: Added a 10s timeout to the camera
    still test (LP: #990133)

  [Daniel Manrique]
  * jobs/audio.txt.in: replaced gconfaudiosink by autoaudiosink (LP: #978895)
  * Instruct Chromium browser to accept file:// URLs so it can correctly
    open the checkbox submission.xml report (LP: #1026614)
  * scripts/network_check: InvalidURL exception is caught and handled more
    cleanly (LP: #751701)
  * Set the correct user (root) for fwts-wakealarm test (LP: #1004102)
  * Set correct user (root) for usb/storage-preinserted, so it works correctly
    on servers (LP: #1004131)

  [Nathan Williams]
  * scripts/network_check: Fixed exception handling in the absence of zenity
    (LP: #988260)
-- Daniel Manrique <email address hidden> Tue, 20 Nov 2012 16:31:02 -0500