Ubuntu
unity package

Launcher - Space created on launcher when icon is moved close to trash

Bug #1028927 reported by Nice Testhouse on 2012-07-25

This bug affects 2 people

	Status	Importance	Assigned to	Milestone
Ayatana Design	Fix Released	High	John Lea
Unity	Fix Released	Medium	Marco Trevisan (Treviño)	Unity 6.6
unity (Ubuntu)	Fix Released	High	Marco Trevisan (Treviño)

Bug Description

Release ubuntu Quantal 12.10 (Radeon) with ppa:SIL2100

As the icon is dragged away from the launcher, the space is closed up and replaced by a grey line which is expected behaviour.

Issue: When the icon is moved close to trash , a space gets created on launcher sometimes above switcher icon and sometimes a space is created at the original location on launcher from where the icon is being dragged out. See screenshot.

------------------------
Desired solution:

- Dragging a Launcher icon close to the Trash should *not* result in a gap opening up in the Launcher. See screenshot "IncorrectEmptySpace2012-07-25 14:32:09.png" which clearly shows this bug.

See original description

Tags:

Related branches

lp:~3v1n0/unity/launcher-draggable-icons

Merged into lp:unity at revision 2713

Andrea Azzarone (community): Approve on 2012-09-18

Brandon Schaefer (community): Approve on 2012-09-18

Diff: 7548 lines (+3855/-1096)

72 files modified

UnityCore/DesktopUtilities.cpp (+29/-9)
UnityCore/DesktopUtilities.h (+1/-0)
UnityCore/GLibDBusProxy.cpp (+0/-4)
com.canonical.Unity.gschema.xml (+3/-3)
launcher/AbstractLauncherIcon.h (+16/-2)
launcher/BFBLauncherIcon.cpp (+1/-0)
launcher/BamfLauncherIcon.cpp (+31/-48)
launcher/BamfLauncherIcon.h (+0/-1)
launcher/CMakeLists.txt (+1/-0)
launcher/DesktopLauncherIcon.cpp (+19/-6)
launcher/DesktopLauncherIcon.h (+4/-12)
launcher/DeviceLauncherSection.cpp (+14/-7)
launcher/DeviceLauncherSection.h (+3/-5)
launcher/DndData.cpp (+5/-5)
launcher/DndData.h (+1/-1)
launcher/ExpoLauncherIcon.cpp (+64/-0)
launcher/ExpoLauncherIcon.h (+45/-0)
launcher/FavoriteStore.cpp (+93/-4)
launcher/FavoriteStore.h (+21/-8)
launcher/FavoriteStoreGSettings.cpp (+67/-68)
launcher/FavoriteStoreGSettings.h (+7/-4)
launcher/FavoriteStorePrivate.cpp (+14/-0)
launcher/FavoriteStorePrivate.h (+3/-1)
launcher/HudLauncherIcon.cpp (+2/-1)
launcher/Launcher.cpp (+82/-108)
launcher/Launcher.h (+5/-8)
launcher/LauncherController.cpp (+526/-341)
launcher/LauncherController.h (+1/-3)
launcher/LauncherControllerPrivate.h (+28/-41)
launcher/LauncherIcon.cpp (+31/-4)
launcher/LauncherIcon.h (+5/-9)
launcher/LauncherModel.cpp (+34/-32)
launcher/MockLauncherIcon.h (+11/-15)
launcher/SoftwareCenterLauncherIcon.cpp (+27/-38)
launcher/SoftwareCenterLauncherIcon.h (+1/-1)
launcher/SpacerLauncherIcon.cpp (+1/-1)
launcher/SpacerLauncherIcon.h (+0/-4)
launcher/StandaloneLauncher.cpp (+1/-1)
launcher/TrashLauncherIcon.cpp (+1/-0)
launcher/VolumeLauncherIcon.cpp (+34/-4)
launcher/VolumeLauncherIcon.h (+3/-0)
manual-tests/Launcher.txt (+15/-0)
panel/PanelMenuView.h (+0/-1)
plugins/unityshell/src/unityshell.cpp (+5/-7)
plugins/unityshell/unityshell.xml.in (+0/-6)
tests/CMakeLists.txt (+19/-11)
tests/gmockvolume.c (+3/-2)
tests/test_bamf_launcher_icon.cpp (+70/-2)
tests/test_bfb_launcher_icon.cpp (+11/-8)
tests/test_desktop_launcher_icon.cpp (+80/-0)
tests/test_desktop_utilities.cpp (+52/-22)
tests/test_device_launcher_section.cpp (+19/-54)
tests/test_expo_launcher_icon.cpp (+58/-0)
tests/test_favorite_store.cpp (+111/-0)
tests/test_favorite_store_gsettings.cpp (+52/-29)
tests/test_hud_launcher_icon.cpp (+53/-0)
tests/test_launcher.cpp (+226/-15)
tests/test_launcher_controller.cpp (+1246/-44)
tests/test_launcher_icon.cpp (+113/-0)
tests/test_launcher_model.cpp (+182/-40)
tests/test_main.cpp (+1/-0)
tests/test_main_xless.cpp (+1/-1)
tests/test_mock_devices.h (+93/-0)
tests/test_software_center_launcher_icon.cpp (+74/-0)
tests/test_trash_launcher_icon.cpp (+39/-0)
tests/test_volume_launcher_icon.cpp (+67/-46)
unity-shared/PluginAdapter.h (+2/-0)
unity-shared/PluginAdapterCompiz.cpp (+5/-0)
unity-shared/PluginAdapterStandalone.cpp (+15/-7)
unity-shared/WindowManager.cpp (+5/-0)
unity-shared/WindowManager.h (+1/-0)
unity-standalone/StandaloneUnity.cpp (+2/-2)

lp:~3v1n0/unity/launcher-draggable-icons-6.0

Merged into lp:unity/6.0 at revision 2692

Andrea Azzarone (community): Approve on 2012-09-18

Brandon Schaefer (community): Approve on 2012-09-18

Diff: 7558 lines (+3857/-1097)

72 files modified

UnityCore/DesktopUtilities.cpp (+29/-9)
UnityCore/DesktopUtilities.h (+1/-0)
UnityCore/GLibDBusProxy.cpp (+0/-4)
com.canonical.Unity.gschema.xml (+3/-3)
launcher/AbstractLauncherIcon.h (+16/-2)
launcher/BFBLauncherIcon.cpp (+1/-0)
launcher/BamfLauncherIcon.cpp (+31/-48)
launcher/BamfLauncherIcon.h (+0/-1)
launcher/CMakeLists.txt (+1/-0)
launcher/DesktopLauncherIcon.cpp (+19/-6)
launcher/DesktopLauncherIcon.h (+4/-12)
launcher/DeviceLauncherSection.cpp (+14/-7)
launcher/DeviceLauncherSection.h (+3/-5)
launcher/DndData.cpp (+5/-5)
launcher/DndData.h (+1/-1)
launcher/ExpoLauncherIcon.cpp (+64/-0)
launcher/ExpoLauncherIcon.h (+45/-0)
launcher/FavoriteStore.cpp (+93/-4)
launcher/FavoriteStore.h (+21/-8)
launcher/FavoriteStoreGSettings.cpp (+67/-68)
launcher/FavoriteStoreGSettings.h (+7/-4)
launcher/FavoriteStorePrivate.cpp (+14/-0)
launcher/FavoriteStorePrivate.h (+3/-1)
launcher/HudLauncherIcon.cpp (+2/-1)
launcher/Launcher.cpp (+83/-108)
launcher/Launcher.h (+5/-8)
launcher/LauncherController.cpp (+526/-341)
launcher/LauncherController.h (+1/-3)
launcher/LauncherControllerPrivate.h (+28/-41)
launcher/LauncherIcon.cpp (+31/-4)
launcher/LauncherIcon.h (+5/-9)
launcher/LauncherModel.cpp (+34/-32)
launcher/MockLauncherIcon.h (+11/-15)
launcher/SoftwareCenterLauncherIcon.cpp (+27/-38)
launcher/SoftwareCenterLauncherIcon.h (+1/-1)
launcher/SpacerLauncherIcon.cpp (+1/-1)
launcher/SpacerLauncherIcon.h (+0/-4)
launcher/StandaloneLauncher.cpp (+1/-1)
launcher/TrashLauncherIcon.cpp (+1/-0)
launcher/VolumeLauncherIcon.cpp (+34/-4)
launcher/VolumeLauncherIcon.h (+3/-0)
manual-tests/Launcher.txt (+15/-0)
panel/PanelMenuView.h (+0/-1)
plugins/unityshell/src/unityshell.cpp (+5/-7)
plugins/unityshell/unityshell.xml.in (+0/-6)
tests/CMakeLists.txt (+19/-11)
tests/gmockvolume.c (+4/-3)
tests/test_bamf_launcher_icon.cpp (+70/-2)
tests/test_bfb_launcher_icon.cpp (+11/-8)
tests/test_desktop_launcher_icon.cpp (+80/-0)
tests/test_desktop_utilities.cpp (+52/-22)
tests/test_device_launcher_section.cpp (+19/-54)
tests/test_expo_launcher_icon.cpp (+58/-0)
tests/test_favorite_store.cpp (+111/-0)
tests/test_favorite_store_gsettings.cpp (+52/-29)
tests/test_hud_launcher_icon.cpp (+53/-0)
tests/test_launcher.cpp (+226/-15)
tests/test_launcher_controller.cpp (+1246/-44)
tests/test_launcher_icon.cpp (+113/-0)
tests/test_launcher_model.cpp (+182/-40)
tests/test_main.cpp (+1/-0)
tests/test_main_xless.cpp (+1/-1)
tests/test_mock_devices.h (+93/-0)
tests/test_software_center_launcher_icon.cpp (+74/-0)
tests/test_trash_launcher_icon.cpp (+39/-0)
tests/test_volume_launcher_icon.cpp (+67/-46)
unity-shared/PluginAdapter.h (+2/-0)
unity-shared/PluginAdapterCompiz.cpp (+5/-0)
unity-shared/PluginAdapterStandalone.cpp (+15/-7)
unity-shared/WindowManager.cpp (+5/-0)
unity-shared/WindowManager.h (+1/-0)
unity-standalone/StandaloneUnity.cpp (+2/-2)

lp:~timo-jyrinki/ubuntu/quantal/unity/ubuntu.660

lp:ubuntu/quantal/unity

Revision history for this message

Nice Testhouse (testhouse) wrote on 2012-07-25:

IncorrectEmptySpace2012-07-25 14:32:09.png Edit (919.3 KiB, image/png)

Revision history for this message

Nice Testhouse (testhouse) wrote on 2012-07-25:

Release ubuntu Quantal 12.10 (Intel) with ppa:SIL2100 nicefi

Same issue observed.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-08-01:

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in unity (Ubuntu):
status:	New → Confirmed

Revision history for this message

Bilal Akhtar (bilalakhtar) wrote on 2012-08-02:

This is normal, and expected. Since the icon is above the launcher, it displays empty space instead of a horizontal line.

However, the designers might want to change that since it's somewhat misleading in this case.

tags:	added: needs-design nicefi quantal removed: quantal-nicefi
Changed in unity:
status:	New → Incomplete
Changed in unity (Ubuntu):
status:	Confirmed → Incomplete
status:	Incomplete → Won't Fix
status:	Won't Fix → Incomplete

Revision history for this message

Nice Testhouse (testhouse) wrote on 2012-08-03:

Issue is that when the icon is moved close to trash , a space gets created on launcher sometimes above switcher icon and sometimes a space is created at the original location of the application on launcher from where the icon is being dragged out from. See screenshot.
There should not be any new space created on the launcher for the icon unless the icon is dragged back close to a spot on launcher?

John Lea (johnlea) on 2012-08-07

summary:	- Space created on launcher when icon is moved close to trash (Radeon) + Launcher - Space created on launcher when icon is moved close to trash + (Radeon)
Changed in ayatana-design:
assignee:	nobody → John Lea (johnlea)
importance:	Undecided → High
Changed in unity:
importance:	Undecided → High
Changed in unity (Ubuntu):
importance:	Undecided → High
Changed in ayatana-design:
status:	New → Triaged
Changed in unity:
status:	Incomplete → Triaged
description:	updated
Changed in unity (Ubuntu):
status:	Incomplete → Triaged
tags:	added: udp removed: needs-design
Changed in unity:
milestone:	none → backlog

Omer Akram (om26er) on 2012-08-07

summary:

Launcher - Space created on launcher when icon is moved close to trash
- (Radeon)

John Lea (johnlea) on 2012-08-08

Changed in ayatana-design:
status:	Triaged → Fix Committed

Marco Trevisan (Treviño) (3v1n0) on 2012-09-03

Changed in unity:
importance:	High → Medium
assignee:	nobody → Marco Trevisan (Treviño) (3v1n0)
milestone:	backlog → 6.4
Changed in unity (Ubuntu):
status:	Triaged → In Progress
Changed in unity:
status:	Triaged → In Progress
Changed in unity (Ubuntu):
assignee:	nobody → Marco Trevisan (Treviño) (3v1n0)

Daniel van Vugt (vanvugt) on 2012-09-03

Changed in unity:
milestone:	6.4 → 6.6

Revision history for this message

Nice Testhouse (testhouse) wrote on 2012-09-06:

Week 36 - Same issue observed on ubuntu 12.04 precise with ppa:unity-team/sru

A space for the icon being dragged is created on launcher mostly above workspace switcher icon when icon is moved close to trash icon.

Revision history for this message

Nice Testhouse (testhouse) wrote on 2012-09-12:

Week 37 - Same observed on ubuntu 12.10 Quantal with ppa:unity-team/staging

Revision history for this message

Nice Testhouse (testhouse) wrote on 2012-09-17:

Week 38 - Same observed on ubuntu 12.10 Quantal with ppa:unity-team/staging

Marco Trevisan (Treviño) (3v1n0) on 2012-09-19

Changed in unity:
status:	In Progress → Fix Committed

Omer Akram (om26er) on 2012-09-20

no longer affects:

unity/7.0

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-09-21:

Download full text (9.2 KiB)

This bug was fixed in the package unity - 6.6.0-0ubuntu1

---------------
unity (6.6.0-0ubuntu1) quantal-proposed; urgency=low

This bug was fixed in the package unity - 6.6.0-0ubuntu1

---------------
unity (6.6.0-0ubuntu1) quantal-proposed; urgency=low

* New upstream release.
    - Fixes non-escaped character sequences in dash previews (LP: #1039020)
    - Updated background layer for preview cover-art and details panels
      to be 10% low-light
    - Expand a PlacesGroup if it is the only category that contains results
      (LP: #950710)
    - Update unity autopilot tests to match autopilot API
    - Updated the convert files to fix some typos in the key names
    - Add gmodule dependency
    - Activate proper result if the categories aren't displayed in-order
      (LP: #1040101)
    - Refactor device launcher icons (LP: #713423)
    - LauncherController: make the controller enable the launcher struts,
      based on hide-mode option (LP: #1044005)
    - Launcher: make always possible to drag an icon to the bottom or top
      of its sub list (LP: #1043968)
    - Don't desat bfb/hud icon in DNDReset (LP: #1043963)
    - Progressively adjust the speed of the minimize animation. First
      time it is used is slower, then speeds up the more it is used.
      (LP: #1017510)
    - Implement new ordering of categories for home lens. (LP: #1043915)
    - UnityWindow now implements ScaleWindowInterface (LP: #876017)
    - Launcher: restore an icon position after that the dragging has been
      cancelled (LP: #955561)
    - LauncherDragWindow: cancel drag on window mapped/unmapped
      (LP: #1044723)
    - Now there is a check of an override color in RefreshColor (which is
      called when a PropertyNotify event happens). Also added a check in
      FullySaturateColor to a void division by zero. (LP: #975350)
    - Queue redraw after cover-art texture is updated from a url/file source.
      (LP: #1043947)
    - Fixed ability to delete glib::Source wrapper during its callback
      (LP: #1044823)
    - Close preview when dash is hidden. (LP: #1045298)
    - LauncherModel: rewrite the Reordering functions to keep the icon
      priority deltas (LP: #761155)
    - Make sure we can pass extra hints when activating preview actions.
      (LP: #1046352)
    - UnityWindow: scale window code improved (LP: #1033935)
    - The mouse will now cause the HUD buttons to change selection
      (LP: #1042692)
    - "Alt+Space" shortcut to reveal the window menu is not hardcoded, but a
       Compiz key option. " (Hold)" should also be translated. Made all
       Compiz plug-in names and all Compiz plug-in option names in
       unityshell.cpp static constants.
    - remove unity --reset, it's not anymore really needed now that we are
      in stable days of unity and we moved to gsettings
    - Removed the variables 'oldPrev' and 'oldNext' which got assigned the
      value NULL, but then were never used
    - Fixed the size of the previews to 770x380 pixels. (LP: #1045243)
    - UnityWindow: use smart pointers, use static close_icon (with dynamic
      state) and PanelStyle context (LP: #1033935) (LP: #1045127)
      (LP: #1046124) (LP: #1046126)
    - Remove everything in the #ifndef USE_MODERN_COMPIZ_GL ifdefs and remove
      the ifdefs alltogether. unity now requires compiz 0.9.8.0.
    - Re-add code to draw panel background texture when the dash is open and
      there is a maximized window (LP: #1044460)
    - EdgeBarrierController: Temporary disable the edge barriers also when
      autohide is set (LP: #1020058)
    - a11y: Port unity3d and panel service accessibility init to atk-bridge
      (LP: #1023542) (LP: #1046582)
    - Dash and Hud get drawn correctly no matter which monitor the mouse is in
      (LP: #1002260)
    - Fix minor problem with the Hud/Dash being drawn while closing on a
      different monitor.
    - Extended track play/pause mouse discovery for entire track row.
      (LP: #1043997)
    - Implemented DBus interface for DashController and made HideDash()
      method available via DBus. This is needed by music-preview-player
      codec installation functionality for hiding the dash when codec
      installation starts. (LP: #1043825)
    - Adds the extra_text property to preview Action (LP: #1049008)
    - Fixed a layout flicker when first opening previews (LP: #1038944)
      (LP: #1043277)
    - Update sizing of elements to match designs, update assets (LP: #1049096)
    - Fix crash in unity::dash::CoverflowResultView::Impl::Impl()
      (LP: #1047420)
    - UnityShell: remove scale_highlighted_window_ variable, using scale's
      getSelectedWindow instead (LP: #1046795)
    - Fixed dash dismissal when changing focus to a window on monitor external
      to that of the dash. (LP: #923657) Improved panel update speed when
      opening dash. (LP: #1044086)
    - Added two new special icons for missing album cover; to be used by
      music lens. They don't really fit into unity-asset-pool as they don't
      have regular sizes. (LP: #1049217)
    - Register file delete events in zeitgeist when file is dropped onto Trash
      launcher icon. Added zeitgeist dependency. (LP: #870150)
    - Restore the panel shadow, which has been missing since Unity 6.4.
      (LP: #1045705)
    - Added SocialPreview. (LP: #1049127)
    - Disable the flow renderer (LP: #1049593)
    - Added two new special icons for missing album cover; to be used by
      music lens (LP: #1049217)
    - Updated dash result highlight focus to 106x106 pixels with 20% white
      opacity. Increased dash result file image size to 96x96. (LP: #1049128)
    - Avoid construction of row wrappers. (LP: #1050342)
    - Added extra-text to preview actions (for price tags) (LP: #1049593)
    - Change the IconLoader methods to allow specifying both
      maximum width and height. Updated rendering of the icon
      ribbons. (LP: #1049593)
    - Preview navigation buttons opacity changes on mouse-over.
      (LP: #1049593)
    - Adds a new background gradient to the dash and panel, as well as
      removes some separator lines (LP: #1049593)
    - Fixed a warning emitted by unreferencing an object owned by a smart
      pointer in HudController.cpp. Caused by adopting a new nux::BaseWindow.
    - Removed dash preview background shadow. (LP: #1049593)
    - Raise shortcut overlay on show (LP: #985883)
    - Reduce internal-padding inside filter buttons (LP: #856277)
    - Added left and right click exit to cover art for all previews
      (LP: #1045230) (LP: #1045752) (LP: #1049593)
    - Show the alt-tab on the monitor with the mouse (LP: #1044293)
    - Fix several failing autopilot tests
    - Fix the standalone launcher crash on exit
    - Fix uninitialized and invalid reads as reported by valgrind
    - Enabled focus navigation for dash preview buttons
      (LP: #1045416) (LP: #1049593)
    - Fixed scrolling in music preview
    - Send the current XLib timestamp to applications when we're opening
      them to not confuse them and cause issues like what we have seen
      with Firefox (LP: #1050687)
    - Implemented the loading of the category icon for the application
      category (required for the apps lens) (LP: #1049593)
    - Refactor unity::Settings to use nux::RWPropert (LP: #1044681)
    - LauncherController, FavoriteStore, Launcher, Icons: always use sort
      priority based on favorites to get positioned on launcher
      (LP: #761155) (LP: #858540) (LP: #868423) (LP: #1028927)
      (LP: #1042845) (LP: #1045146)
    - UnityWindow: implements sigc::trackable to fix crash (LP: #1052683)
    - Dash/Hud no longer steal mouse events outside their content area.
      Better draw handling of hud animation (LP: #1049593)
    - add a deprecated --reset option as it seems otherwise to match
      to --reset-icons
    - Slows the animation down when installing applications in the Dash
      Preview and the Software Center (LP: #1045746)
    - Updates the API to match nux trunk and nux/3.0
    - Introduced dash to preview transitions, relying on nux (LP: #1049593)
    - Don't call GraphicsContext::DeactivateFramebuffer which will
      immediately restore the backbuffer. Instead call WindowCompositor::
      RestoreMainFramebuffer to bind either the backbuffer or reference
      framebuffer for reading as that is the one we're drawing to as is the
      most-up-to-date
    - SocialPreview: Don't expand preview_info_hints, it was pushing down
      the comments when there wasn't enough comments to fill the space
    - Show workspace switcher icon always
    - Fix rendering of Dash in maximised mode with redirected textures
      by using the same code-patches as the restored Dash mode for the
      overlay. (LP: #1053092)
    - Fix more unit tests
    - Fix ERROR ... unity.thumbnailgenerator ThumbnailGenerator.cpp:429
      More than one thumbnail generator created.
    - Implement "focus on hover" behavior for preview action buttons
      (LP: #1053014)
    - Clicking on Dash border should not close the dash
    - Remove two manual-tests, that are now obsolete
    - Adds changes to the LauncherController to better handle favourites
      and the expo icon
    - [UIFE][FFE] Install Amazon and Ubuntu One Music Store webapp items
      in the launcher by default (LP: #1046840)
  * debian/control:
    - build-dep on libzeitgeist-dev and libunity-dev
    - bump because of ABI breakage build-dep on compiz and nux
    - now recommends unity-lens-shopping (LP: #1053470)
 -- Didier Roche <didrocks@ubuntu.com>   Thu, 20 Sep 2012 16:56:38 +0200

Changed in unity (Ubuntu):
status:	In Progress → Fix Released

Daniel van Vugt (vanvugt) on 2012-09-21

Changed in unity:
status:	Fix Committed → Fix Released

Christian Giordano (nuthinking) on 2012-10-02

Changed in ayatana-design:
status:	Fix Committed → Fix Released
tags:	added: reviewedbydesignq removed: udp

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Bug attachments

IncorrectEmptySpace2012-07-25 14:32:09.png Edit

Add attachment

Remote bug watches

Bug watches keep track of this bug in other bug trackers.

Ubuntuunity package

Launcher - Space created on launcher when icon is moved close to trash

Bug Description

Related branches

Other bug subscribers

Bug attachments

Remote bug watches

Ubuntu
unity package