memory_compare script crashes if a system has empty RAM slots
Bug #1023220 reported by
Brendan Donegan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Checkbox |
Fix Released
|
High
|
Brendan Donegan | ||
Bug Description
If the current form of the memory_compare script runs on a system that has empty RAM slots, the following exception occurs:
Traceback (most recent call last): File "/usr/share/
This is because the Size field will read: No Module Installed
The solution is to catch exceptions when converting the size to an int
Related branches
lp:~brendan-donegan/checkbox/bug1023220_memory_compare_value_error
- Marc Tardif (community): Approve
- Brendan Donegan (community): Needs Resubmitting
-
Diff: 43 lines (+9/-6) (has conflicts)2 files modifieddebian/changelog (+5/-0)
scripts/memory_compare (+4/-6)
lp:~roadmr/ubuntu/quantal/checkbox/0.14.2
- Luke Yelavich (community): Approve
- Ubuntu branches: Pending requested
-
Diff: 121705 lines (+24643/-21683)183 files modifiedcheckbox/job.py (+18/-4)
checkbox/lib/dmi.py (+16/-0)
checkbox/lib/resolver.py (+6/-4)
checkbox/lib/tests/resolver.py (+3/-1)
checkbox/parsers/dmidecode.py (+4/-1)
checkbox/parsers/efi.py (+52/-0)
checkbox/parsers/submission.py (+29/-12)
checkbox/parsers/tests/efi.py (+63/-0)
checkbox/tests/job.py (+37/-0)
checkbox/tests/message_files.py (+57/-0)
data/websites/html5_video.html (+14/-0)
data/whitelists/default.whitelist (+2/-0)
data/whitelists/smoke.whitelist (+1/-0)
data/whitelists/sniff.whitelist (+1/-0)
debian/changelog (+114/-0)
debian/checkbox-qt.install (+1/-1)
debian/checkbox.config (+0/-2)
debian/checkbox.install (+1/-1)
debian/checkbox.links (+1/-0)
debian/checkbox.templates (+0/-12)
debian/control (+9/-5)
debian/po/ast.po (+19/-50)
debian/po/cs.po (+19/-48)
debian/po/de.po (+19/-54)
debian/po/en_AU.po (+19/-52)
debian/po/en_GB.po (+19/-52)
debian/po/es.po (+21/-54)
debian/po/fr.po (+19/-48)
debian/po/he.po (+19/-48)
debian/po/hu.po (+19/-50)
debian/po/it.po (+19/-52)
debian/po/ja.po (+19/-53)
debian/po/nl.po (+19/-54)
debian/po/oc.po (+19/-48)
debian/po/pl.po (+19/-48)
debian/po/pt_BR.po (+19/-53)
debian/po/ro.po (+19/-48)
debian/po/ru.po (+19/-48)
debian/po/templates.pot (+16/-44)
debian/po/tr.po (+19/-48)
debian/po/uk.po (+19/-48)
debian/po/zh_CN.po (+19/-48)
debian/po/zh_TW.po (+19/-50)
debian/pycompat (+0/-1)
debian/rules (+10/-1)
debian/watch (+0/-3)
install/postinst (+1/-1)
jobs/cpu.txt.in (+8/-2)
jobs/disk.txt.in (+5/-5)
jobs/firewire.txt.in (+6/-0)
jobs/info.txt.in (+9/-8)
jobs/install.txt.in (+4/-2)
jobs/mediacard.txt.in (+48/-0)
jobs/miscellanea.txt.in (+3/-2)
jobs/networking.txt.in (+1/-1)
jobs/power-management.txt.in (+11/-2)
jobs/resource.txt.in (+5/-0)
jobs/usb.txt.in (+22/-10)
jobs/wireless.txt.in (+1/-1)
patches/0.14.2 (+17/-0)
patches/0.4 (+3/-3)
patches/0.5 (+3/-3)
patches/0.8 (+3/-3)
patches/0.9 (+3/-3)
plugins/message_info.py (+0/-2)
po/POTFILES.in (+2/-0)
po/ace.po (+238/-208)
po/af.po (+238/-208)
po/am.po (+238/-208)
po/ar.po (+241/-211)
po/ast.po (+248/-209)
po/az.po (+238/-208)
po/be.po (+238/-208)
po/bg.po (+238/-208)
po/bn.po (+247/-208)
po/bo.po (+238/-208)
po/br.po (+238/-208)
po/bs.po (+247/-208)
po/ca.po (+238/-208)
po/ca@valencia.po (+238/-208)
po/checkbox.pot (+236/-206)
po/ckb.po (+238/-208)
po/cs.po (+246/-207)
po/cy.po (+238/-208)
po/da.po (+238/-208)
po/de.po (+224/-200)
po/dv.po (+238/-208)
po/el.po (+250/-211)
po/en_AU.po (+585/-546)
po/en_CA.po (+238/-208)
po/en_GB.po (+555/-516)
po/eo.po (+238/-208)
po/es.po (+225/-197)
po/et.po (+238/-208)
po/eu.po (+238/-208)
po/fa.po (+238/-208)
po/fi.po (+241/-208)
po/fr.po (+238/-205)
po/ga.po (+238/-208)
po/gd.po (+238/-208)
po/gl.po (+238/-208)
po/he.po (+238/-208)
po/hi.po (+238/-208)
po/hr.po (+238/-208)
po/hu.po (+248/-209)
po/hy.po (+238/-208)
po/id.po (+238/-208)
po/is.po (+238/-208)
po/it.po (+250/-211)
po/ja.po (+241/-208)
po/jbo.po (+238/-208)
po/ka.po (+238/-208)
po/kk.po (+238/-208)
po/km.po (+249/-210)
po/kn.po (+238/-208)
po/ko.po (+238/-208)
po/ku.po (+238/-208)
po/ky.po (+238/-208)
po/lt.po (+238/-208)
po/lv.po (+238/-208)
po/mk.po (+238/-208)
po/ml.po (+238/-208)
po/mr.po (+238/-208)
po/ms.po (+247/-208)
po/my.po (+238/-208)
po/nb.po (+238/-208)
po/nds.po (+238/-208)
po/ne.po (+238/-208)
po/nl.po (+249/-210)
po/nn.po (+238/-208)
po/oc.po (+241/-205)
po/pl.po (+238/-208)
po/ps.po (+238/-208)
po/pt.po (+238/-208)
po/pt_BR.po (+224/-196)
po/ro.po (+249/-210)
po/ru.po (+247/-208)
po/sd.po (+238/-208)
po/shn.po (+238/-208)
po/si.po (+238/-208)
po/sk.po (+238/-208)
po/sl.po (+249/-210)
po/sq.po (+240/-208)
po/sr.po (+238/-208)
po/sv.po (+238/-208)
po/ta.po (+238/-208)
po/te.po (+238/-208)
po/th.po (+238/-208)
po/tr.po (+246/-207)
po/ug.po (+249/-210)
po/uk.po (+343/-277)
po/ur.po (+238/-208)
po/uz.po (+238/-208)
po/vi.po (+238/-208)
po/zh_CN.po (+246/-207)
po/zh_HK.po (+238/-208)
po/zh_TW.po (+238/-208)
qt/checkbox-qt.desktop.in (+1/-1)
qt/com.canonical.QtCheckbox.service (+1/-1)
scripts/cpu_offlining (+13/-15)
scripts/cpu_scaling_test (+0/-630)
scripts/cpu_topology (+18/-10)
scripts/create_connection (+23/-17)
scripts/disk_read_performance_test (+28/-6)
scripts/disk_smart (+20/-5)
scripts/disk_stats_test (+4/-7)
scripts/dmi_resource (+4/-4)
scripts/efi_resource (+54/-0)
scripts/frequency_governors_test (+645/-0)
scripts/fwts_test (+5/-4)
scripts/gpu_test (+9/-23)
scripts/ipmi_test (+9/-2)
scripts/memory_compare (+75/-27)
scripts/memory_test (+38/-21)
scripts/network_bandwidth_test (+16/-11)
scripts/network_device_info (+1/-1)
scripts/network_ntp_test (+24/-20)
scripts/optical_detect (+1/-1)
scripts/optical_read_test (+18/-8)
scripts/process_wait (+3/-2)
scripts/removable_storage_test (+63/-50)
setup.cfg (+1/-0)
setup.py (+1/-1)
| Changed in checkbox: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| assignee: | nobody → Brendan Donegan (brendan-donegan) |
| Changed in checkbox: | |
| status: | In Progress → Fix Committed |
| Changed in checkbox: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
