BAMF

Type mismatch in libbamf bamf_control_register_application_for_pid() and dbus interface

Bug #1021143 reported by Ying-Chun Liu on 2012-07-05

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
BAMF	Fix Released	Medium	Ying-Chun Liu	BAMF 0.2.122
Unity	Fix Released	Undecided	Unassigned	Unity 6.2
bamf (Ubuntu)	Fix Released	Undecided	Unassigned
Quantal	Fix Released	Undecided	Unassigned
unity (Ubuntu)	Fix Released	Undecided	Unassigned

Bug Description

Hi,

I get the following warning when using bamf_control_register_application_for_pid()

** (test2:11575): WARNING **: Failed to register application: メッセージの型 '(su)' は期待した型 '(si)' に一致しません

It is because in lib/libbamf/bamf-control.c:
...
  if (!dbus_g_proxy_call (priv->proxy,
                          "RegisterApplicationForPid",
                          &error,
                          G_TYPE_STRING, application,
                          G_TYPE_UINT, pid,
                          G_TYPE_INVALID,
                          G_TYPE_INVALID))
...

However, in src/org.ayatana.bamf.xml:
    <method name="RegisterApplicationForPid">
      <arg name="application" type="s" direction="in"/>
      <arg name="pid" type="i" direction="in"/>
    </method>

I made a patch to correct the problem.
Please merge it.

Thanks,
Paul

Tags:

Related branches

lp:~paulliu/bamf/fix-dbus-types-error

Merged into lp:bamf/0.4 at revision 473

Marco Trevisan (Treviño): Approve on 2012-07-05

lp:~sil2100/bamf/ubuntu_6.2 (Merged)

Revision history for this message

Ying-Chun Liu (paulliu) wrote on 2012-07-05:

Patch to fix the problem Edit (511 bytes, text/plain)

Michal Hruby (mhr3) on 2012-08-10

Changed in bamf:
assignee:	nobody → Ying-Chun Liu (paulliu)
importance:	Undecided → Medium
status:	New → Fix Committed
milestone:	none → 0.2.122

Łukasz Zemczak (sil2100) on 2012-08-10

Changed in unity:
milestone:	none → 6.2
status:	New → Incomplete
status:	Incomplete → Fix Committed

Didier Roche-Tolomelli (didrocks) on 2012-08-10

Changed in bamf:
status:	Fix Committed → Fix Released
Changed in unity:
status:	Fix Committed → Fix Released

Revision history for this message

Ubuntu Foundations Team Bug Bot (crichton) wrote on 2012-08-10:

The attachment "Patch to fix the problem" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags:

added: patch

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-08-13:

This bug was fixed in the package bamf - 0.2.122-0ubuntu1

---------------
bamf (0.2.122-0ubuntu1) quantal-proposed; urgency=low

  * New upstream release.
    - Type mismatch in libbamf bamf_control_register_application_for_pid()
      and dbus interface (LP: #1021143)
    - running applications without an icon use a blank icon (LP: #886778)
-- Lukasz 'sil2100' Zemczak <email address hidden> Fri, 10 Aug 2012 12:18:02 +0200