Wrong 'Download CSV Summary' link

Bug #1020555 reported by Jeffrey Lensen
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Gabriel Hurley
Essex
Fix Released
Undecided
Unassigned
horizon (Ubuntu)
Fix Released
Undecided
Unassigned
Precise
Fix Released
Undecided
Unassigned

Bug Description

The 'Download CSV Summary' button always seems to download a CSV file of the last month. This seems to be because of the link that gets generated:
 <domainname>/syspanel/?date_month=2012-05-01&date_year=2012-06-01&format=csv

Which should be:
 <domainname>/syspanel/?month=5&year=2012&format=csv

Related branches

CVE References

Revision history for this message
Gabriel Hurley (gabriel-hurley) wrote :

Good catch!

Changed in horizon:
assignee: nobody → Gabriel Hurley (gabriel-hurley)
importance: Undecided → High
milestone: none → folsom-3
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/11360

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/11360
Committed: http://github.com/openstack/horizon/commit/dbfef253e5b56d7b701731537d469b27257fcb62
Submitter: Jenkins
Branch: master

commit dbfef253e5b56d7b701731537d469b27257fcb62
Author: Gabriel Hurley <email address hidden>
Date: Tue Aug 14 11:28:31 2012 -0700

    Corrects the CSV download link for overview pages.

    Fixes bug 1020555.

    Change-Id: I22dd5b14cd8db5dc7a0956c46aaf6c44dfcbd6b1

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/essex)

Fix proposed to branch: stable/essex
Review: https://review.openstack.org/11708

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/essex)

Reviewed: https://review.openstack.org/11708
Committed: http://github.com/openstack/horizon/commit/f862d9eb9fe3b2fff897bd9180a761262cdc9105
Submitter: Jenkins
Branch: stable/essex

commit f862d9eb9fe3b2fff897bd9180a761262cdc9105
Author: Gabriel Hurley <email address hidden>
Date: Tue Aug 14 11:28:31 2012 -0700

    Corrects the CSV download link for overview pages.

    Fixes bug 1020555.

    Change-Id: I22dd5b14cd8db5dc7a0956c46aaf6c44dfcbd6b1

tags: added: in-stable-essex
Thierry Carrez (ttx)
Changed in horizon:
milestone: folsom-3 → 2012.2
Changed in horizon (Ubuntu):
status: New → Fix Released
Changed in horizon (Ubuntu Precise):
status: New → Confirmed
Revision history for this message
Steve Langasek (vorlon) wrote :

The horizon SRU is a provisional micro-release exception, but this bug is linked from the SRU changelog and would require direct verification. Please either complete the bug description with a test case for this bug, or re-upload without a reference in the changelog.

Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Jeffrey, or anyone else affected,

Accepted horizon into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/horizon/2012.1.3+stable-20130423-5ce39422-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in horizon (Ubuntu Precise):
status: Confirmed → Fix Committed
tags: added: verification-needed
Revision history for this message
Yolanda Robla (yolanda.robla) wrote : Verification report.

Please find the attached test log from the Ubuntu Server Team's CI infrastructure. As part of the verification process for this bug, Horizon has been deployed and configured across multiple nodes using precise-proposed as an installation source. After successful bring-up and configuration of the cluster, a number of exercises and smoke tests have be invoked to ensure the updated package did not introduce any regressions. A number of test iterations were carried out to catch any possible transient errors.

Please Note the list of installed packages at the top and bottom of the report.

For records of upstream test coverage of this update, please see the Jenkins links in the comments of the relevant upstream code-review(s):

Trunk review: https://review.openstack.org/11360
Stable review: https://review.openstack.org/11708

As per the provisional Micro Release Exception granted to this package by the Technical Board, we hope this contributes toward verification of this update.

Revision history for this message
Yolanda Robla (yolanda.robla) wrote :

Test coverage log.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Scott Kitterman (kitterman) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package horizon - 2012.1.3+stable-20130423-5ce39422-0ubuntu1

---------------
horizon (2012.1.3+stable-20130423-5ce39422-0ubuntu1) precise-proposed; urgency=low

  * Resynchronize with stable/essex (LP: #1089488)
    - [7e651d7] stable/essex horizon installs unusable version of glance
      (LP: #1057125)
    - [35eada8] open redirect / phishing attack via "next" parameter
      (LP: #1039077)
    - [8889311] TypeError when trying to delete an unnamed volume via dashboard
      (LP: #1031291)
    - [f862d9e] Wrong 'Download CSV Summary' link (LP: #1020555)
    - [9b22d68] When adding ICMP rule, the type/code is being validated as
      from/to ports (LP: #997669)
    - [52bbba1] Added --only-selenium option in run_tests.sh
  * Dropped patches, superseeded by new snapshot:
    - debian/patches/CVE-2012-3540.patch [35eada8]
 -- Yolanda <email address hidden> Wed, 24 Apr 2013 15:46:28 +0200

Changed in horizon (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.