Users cannot use keyboard to navigate the choicesource picker
Bug #1019064 reported by
Curtis Hovey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Curtis Hovey | ||
Bug Description
We discovered that we cannot use the keyboard to tab or use arrow keys to move between the links in the choicesource pickers added the to +filebug. There is nothing special about the pickers...keyboard navigation was broken on every form a select menu was replaced with.
Related branches
lp:~sinzui/launchpad/overlay-tab
- Richard Harding (community): Approve
-
Diff: 256 lines (+163/-10)4 files modifiedlib/lp/app/javascript/choiceedit/choiceedit.js (+1/-6)
lib/lp/app/javascript/overlay/assets/skins/sam/pretty-overlay-skin.css (+2/-0)
lib/lp/app/javascript/overlay/overlay.js (+56/-3)
lib/lp/app/javascript/overlay/tests/test_overlay.js (+104/-1)
| tags: |
added: specifications removed: blueprints |
| Changed in launchpad: | |
| assignee: | nobody → Curtis Hovey (sinzui) |
Revision history for this message
| Curtis Hovey (sinzui) wrote | #1 |
| tags: | added: wcag |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| tags: | added: information-type |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
The root cause of the issue is a naive handler that steals focus and gives it to the close button.
var bb = this.get(
});
The handler is bound when the widget is positioned. I think it is trying to ensure users cannot scroll away form it, but we know that once the overlay looses focus, it is dismissed. The handler is just not needed.