documentation refers to OS and OSRelease, bug reports use DistroRelease

Bug #1018387 reported by Joshua Taylor
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
apport (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

The documentation (doc/data-format.tex) describes the OS and OSRelease fields:

    \item [OS:] (optional) Name of the operating system. On LSB compliant
    systems, this can be determined with \verb!lsb_release -si!.

    \item [OSRelease:] (optional) Release version of the operating system. On
    LSB compliant systems, this can be determined with \verb!lsb_release -sr!.

But these are not included in bug reports. Instead, the DistroRelease field is included, and its value is constructed from the output of lsb_release -sir in report.py:

    def add_os_info(self):
        '''Add operating system information.

        This adds:
        - DistroRelease: lsb_release -sir output
        - Architecture: system architecture in distro specific notation
        - Uname: uname -srm output
        - NonfreeKernelModules: loaded kernel modules which are not free (if
            there are none, this field will not be present)
        '''
        p = subprocess.Popen(['lsb_release', '-sir'], stdout=subprocess.PIPE,
            stderr=subprocess.PIPE, close_fds=True)
        self['DistroRelease'] = p.communicate()[0].decode().strip().replace('\n', ' ')

        u = os.uname()
        self['Uname'] = '%s %s %s' % (u[0], u[2], u[4])
        self['Architecture'] = packaging.get_system_architecture()

The documentation should be updated to reflect the use of DistroRelease instead of OS and OSRelease.

Changed in apport (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Martin Pitt (pitti) wrote :

Fixed in trunk r2677.

Changed in apport (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 2.12-0ubuntu2

---------------
apport (2.12-0ubuntu2) saucy; urgency=low

  * Merge from trunk:
    - sandboxutils.py, make_sandbox(): Install packages from Package: and
      Dependencies: fields also if we have a ProcMaps: field and there are any
      third-party packages. This fixes retracing crashes that use PPAs (as they
      don't have Contents.gz).
    - Robustify "progress bar visible" GTK and KDE UI checks for the faster
      collection due to dropping lsb_release.
 -- Martin Pitt <email address hidden> Fri, 02 Aug 2013 16:03:43 +0200

Changed in apport (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.