Improve support for rpm packaging
Bug #1018128 reported by
Yavor Nikolov
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| pbzip2 |
Fix Committed
|
Medium
|
Yavor Nikolov | ||
Bug Description
---------- Forwarded message (some info irrelevant to this bug has been removed) ----------
From: Ville Skyttä
Date: Fri, Jun 1, 2012 at 4:54 PM
Subject: Updating pbzip2 in Fedora/EPEL to 1.1.6
...
See attached patches I've prepared for this - the buildflags patch is something that I believe would be useful to merge upstream for future pbzip2 versions.
Revision history for this message
| Yavor Nikolov (yavor-nikolov) wrote | #1 |
Revision history for this message
| Yavor Nikolov (yavor-nikolov) wrote | #2 |
Revision history for this message
| Yavor Nikolov (yavor-nikolov) wrote | #3 |
| Changed in pbzip2: | |
| assignee: | nobody → Yavor Nikolov (yavor-nikolov) |
| status: | New → In Progress |
| importance: | Undecided → Medium |
| Changed in pbzip2: | |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
* I wonder if it makes sense to change in Makefile assignments from "=" to "+=".
* I took a look at the Ubuntu packaging customizations (Debian should be same) - seems they're setting relevant flags outside and we make is called with arguments:
make CFLAGS=... LDFLAGS=...
which seems to take priority over all CFLAGS and LDFLAGS assignments we have in the Makefile.
* In Gentoo:
- they have similar to Fedora approach - they're removing initial CC and CFLAGS assignments and leaving all rest with +=
- they're replacing CFLAGS with CXXFLAGS, CC with CXX, LDFLAGS with LIBS (and are still actually passing LDFLAGS to compiler so it's more like they separate ld flags from libs).
So:
* If anyone wants to pass additional flags or overwrite the ones in Makefile: it's possible to do so. (Even if we don't change = to +=)
* Splitting LDFLAGS and LIBS maybe makes sense too. It's unlikely someone to want to replace LIBS, more often LDFLAGS will be tweaked.
* Having OPTFLAGS separated from CFLAGS/CXXFLAGS may make some sense too.
* Changes on these may affect customizations patches of the various package maintainers. (Shouldn't be a huge problem, it's not a big change, we don't do this very frequently, will hopefully allow better alignment with their environments).